New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 896420 link

Starred by 1 user
Status: Duplicate
Merged: issue 892428
Owner:
martiniss@chromium.org
Closed: Oct 17
Cc:
█ iannucci@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

led runs from "Build Recipes Tester" don't set recipe_module.tryserver.is_tryserver

Project Member Reported by bpastene@google.com, Oct 17 
See https://chromium-review.googlesource.com/c/chromium/tools/build/+/1287114/1 where I tried testing the recipe change on a bot that runs the chromium_libfuzzer_trybot.py recipe. That recipe includes the line "assert api.tryserver.is_tryserver" to ensure it's got a patch to test. That assert failed on the led runs:
https://luci-milo.appspot.com/swarming/task/409c7c22bed5f610

That should be true for tools/build CQ runs, no? Stephen, could you take a look?

Comment 1 by martiniss@chromium.org, Oct 17 

The led job it's triggering has no patch, so the recipe thinks it's not on the tryserver.  bug 892428  is tracking work I need to do to add a patch the builder applies.

Comment 2 by bpastene@google.com, Oct 17

Mergedinto: 892428
Status: Duplicate (was: Assigned)
Gotcha. I think it makes sense to dupe into  bug 892428  in that case.
►

Sign in to add a comment