New issue
Advanced search Search tips

Issue 896417 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 21
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 852161



Sign in to add a comment

dlcservice: API to get a list of supported DLCs

Project Member Reported by xiaochu@chromium.org, Oct 17

Issue description

GetInstalled returns a list of installed DLC modules.

This is required by Update Engine when it updates installed DLC modules.
 
Blocking: 852161
Description: Show this description
Description: Show this description
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/d4bfa8712a412566639105cf7cb0b35328f35ec0

commit d4bfa8712a412566639105cf7cb0b35328f35ec0
Author: Xiaochu Liu <xiaochu@chromium.org>
Date: Tue Oct 23 20:01:32 2018

system_api: add dlcservice d-bus constants&protobuf

The serialized protobuf is the return value of GetInstalledDlcList.

BUG= chromium:896417 
TEST=emerge-kefka system_api

Change-Id: I8f174c681b2d409c83528b918167435a1f5414e4
Reviewed-on: https://chromium-review.googlesource.com/1294252
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Xiaochu Liu <xiaochu@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/d4bfa8712a412566639105cf7cb0b35328f35ec0/system_api/system_api.gyp
[modify] https://crrev.com/d4bfa8712a412566639105cf7cb0b35328f35ec0/system_api/system_api.pc
[add] https://crrev.com/d4bfa8712a412566639105cf7cb0b35328f35ec0/system_api/dbus/dlcservice/dlcservice.proto
[add] https://crrev.com/d4bfa8712a412566639105cf7cb0b35328f35ec0/system_api/dbus/dlcservice/dbus-constants.h

Project Member

Comment 5 by bugdroid1@chromium.org, Oct 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/6e979f1f3351cff7dd36c9133b3b55bc2d7f6e43

commit 6e979f1f3351cff7dd36c9133b3b55bc2d7f6e43
Author: Xiaochu Liu <xiaochu@chromium.org>
Date: Tue Oct 23 20:01:32 2018

chromeos-base/system_api: add new dbus constant folder

Edit dir to include dlcservice so it install dlcservice dbus constants.

BUG= chromium:896417 
TEST=emerge-kefka system_api
CQ-DEPEND=CL:1294252

Change-Id: I07f8a6b15f8c50443744787d29b71be6bc6c9c94
Reviewed-on: https://chromium-review.googlesource.com/1294158
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Xiaochu Liu <xiaochu@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/6e979f1f3351cff7dd36c9133b3b55bc2d7f6e43/chromeos-base/system_api/system_api-9999.ebuild

Labels: Pri-2
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/a4ccf03476e2a40c6fdfa3f5844bc351323af89d

commit a4ccf03476e2a40c6fdfa3f5844bc351323af89d
Author: Xiaochu Liu <xiaochu@chromium.org>
Date: Wed Nov 14 14:27:16 2018

dlcservice: depends on more *-client

Add missing build dependencies.

BUG= chromium:896417 
TEST=USE="dlc" emerge-kefka dlcservice

Change-Id: Ibb03b8cd224137544b210dbae019d9e03599fb30
Reviewed-on: https://chromium-review.googlesource.com/1330164
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Xiaochu Liu <xiaochu@chromium.org>
Reviewed-by: Amin Hassani <ahassani@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/a4ccf03476e2a40c6fdfa3f5844bc351323af89d/chromeos-base/dlcservice/dlcservice-9999.ebuild

Status: Fixed (was: Untriaged)

Sign in to add a comment