New issue
Advanced search Search tips

Issue 896414 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 5
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Remove feature flag for SmbNative

Project Member Reported by baileyberro@google.com, Oct 17

Issue description

Since SmbNative is enabled by default in M70, we should be able to remove the feature flag in M72.
 
Components: UI>Settings
Owner: jimmyxgong@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3528f3ffe7ad1ec722c636a1719706838a5ce0e1

commit 3528f3ffe7ad1ec722c636a1719706838a5ce0e1
Author: Jimmy Gong <jimmyxgong@google.com>
Date: Tue Oct 30 20:11:11 2018

Remove NativeSMB feature flag

- SMB file sharing can still be disable through managed policies.

Bug:  chromium:896414 
Test: end-to-end
Change-Id: I4158249d14812a7e28a775af54cc6ed4ee35714f
Reviewed-on: https://chromium-review.googlesource.com/c/1297640
Commit-Queue: jimmy gong <jimmyxgong@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603994}
[modify] https://crrev.com/3528f3ffe7ad1ec722c636a1719706838a5ce0e1/chrome/browser/about_flags.cc
[modify] https://crrev.com/3528f3ffe7ad1ec722c636a1719706838a5ce0e1/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/3528f3ffe7ad1ec722c636a1719706838a5ce0e1/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/3528f3ffe7ad1ec722c636a1719706838a5ce0e1/chrome/browser/resources/settings/downloads_page/downloads_page.html
[modify] https://crrev.com/3528f3ffe7ad1ec722c636a1719706838a5ce0e1/chrome/browser/resources/settings/downloads_page/downloads_page.js
[modify] https://crrev.com/3528f3ffe7ad1ec722c636a1719706838a5ce0e1/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/3528f3ffe7ad1ec722c636a1719706838a5ce0e1/tools/metrics/histograms/enums.xml

Status: Fixed (was: Assigned)

Sign in to add a comment