confirmed/triaging

Chrome 69.0.3497.100 Stable
for query=2+2:
type=search-calculator-answer / rel=1251 / contents=4

Chrome 72.0.3583.0 Canary
+1 to pkasting's report, agree it's likely to be switch to rich suggestions?
for query=2+2:
type=search-calculator-answer / rel=1251 / contents=2+2

I'm sheriffing and this *might* be straightforward so I'll try to pick this up

possibly 
https://chromium-review.googlesource.com/c/chromium/src/+/1197342

checking if fill_into_edit could be special-cased around here:
https://codesearch.chromium.org/chromium/src/components/omnibox/browser/base_search_provider.cc?l=317&rcl=c926d3bb2f3b7d166c59aa2bb4fde82eb351a5b3
or if that would just be duct tape. 

This change was intentional.

If the result ("50") is put in fill_into_edit, then you have the option of using it in a series of calculations in the omnibox itself. Which is kind of cool but pretty non-obvious that you can use it this way. Actually *using* the suggestion, however, produces a generally useless search results page.

If the operands ("10*5") are put into fill_into_edit, then using the suggestion takes you to a calculator on the SRP. This is arguably more useful than typing calculations into the omnibox, but is definitely something users are more likely to actually do, since clicking on suggestions is what you're supposed to do.

for the case in #3, the proposed change shows the result (50) in the omnibox, while hitting enter on it or clicking the suggestion goes to the SRP with a calculator with the query and answer filled in that calculator. 

May have missed an edge case but the intention was to keep krb@'s fix for URLs (agree it's better that way) while allowing the edit text to be the answer rather than the suggestion.

of course if that's mixing too many behaviors, understood.

@3: The big need is not repeated calculations in the omnibox (that's a side effect), but copying the answer.  I claim copying the answer is a much more common case than wanting to hit enter to search for this and go get a calculator page for any reason.  (I don't believe we have the machinery to measure this claim.)

I support the clever hack Travis is describing to "have our cake and eat it too", which hopefully raises few enough hackles to work as a compromise.  But even without that, I'm convinced that we made a well-intentioned mistake with this change.

I think going to the calculator on the SRP is very common, but fortunately skare's change saves us from having to debate this. :)

skare: sorry, I didn't look carefully at your CL. Sounds like a good idea.

nah, I tried to keep the cl description short. Probably too short. Also added a comment to explain some existing behavior but not the new behavior which probably put focus on it. 

I'll ping for the other review and submit then. thanks!

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64e2a6e79632ea8e05682fe8a3ed3d5f3002241d

commit 64e2a6e79632ea8e05682fe8a3ed3d5f3002241d
Author: Travis Skare <skare@chromium.org>
Date: Mon Oct 22 20:31:52 2018

[omnibox] Rich calculator suggestions: use answer for fill_into_edit.

Putting the result of the calculation into fill_into_edit places it in the
omnibox when the user focuses the suggestion, allowing them to copy the
result or use it as the basis of another calculation. Whereas leaving the
query as the operands allows the user to still use the suggestion to
get to a SRP with a calculator on it, which is more useful than searching
for the result.

Bug:  896407 
Change-Id: Ie42ad7d21824af6d518414b6d2bb5212bba7580c
Reviewed-on: https://chromium-review.googlesource.com/c/1287181
Commit-Queue: Travis Skare <skare@chromium.org>
Reviewed-by: Kevin Bailey <krb@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601712}
[modify] https://crrev.com/64e2a6e79632ea8e05682fe8a3ed3d5f3002241d/components/omnibox/browser/base_search_provider.cc

We did see a few user reports in Chrome 71 complaining about this behavior, but it appears this is fixed now.

"I liked it when I could type in a simple calculation on the search bar and then I could select and *copy* the answer of the calculation to somewhere else - now I have to press enter and get the google calculator, and it's much more inconvinient."

"The new version of chrome (71) has removed very useful functionality from the address bar calculator feature! Before, after typing in an equation, you could press the down arrow to get the resulting value in the address bar. This allowed you to copy the result, or proceed with further calculations on the result, just like pressing equals on a calculator does. Now the original equation stays in the address bar and there is no way to select the result without leaving the page you are on. Please bring it back!"