New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 896388 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 24
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

gdisp unit test failure causing build failures

Project Member Reported by sureshraj@google.com, Oct 17

Issue description

Cc: mikenichols@chromium.org seobrien@chromium.org amstan@google.com josephsih@chromium.org
Labels: -Pri-1 Pri-3
Sheriffs, if this starts to affect the CQ, mark them all experimental: we don't block ChromeOS CL's landing because Jetstream is having a breakage. 

-> P3 per our bug SLO.

Uploaded CL to disable the flaky test to return CQ to green 
https://chrome-internal-review.googlesource.com/c/chromeos/platform/gdisp/+/699802

Pending review
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 17

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/platform/gdisp/+/7e2d424971b83ef3feaa55631c608ad2e936c22e

commit 7e2d424971b83ef3feaa55631c608ad2e936c22e
Author: Tao Jin <jintao@google.com>
Date: Wed Oct 17 20:01:23 2018

Cc: jintao@chromium.org sureshraj@chromium.org mxt@chromium.org
Owner: mtyin@chromium.org
Re-assigning this to mtyin to land the proper fix for the flaky failure
Sorry my fault. It was a singleton test with test order dependency. I'll fix it today.
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 18

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/platform/gdisp/+/59e121f37d499a4b4cc1d5d3008925da4434ce60

commit 59e121f37d499a4b4cc1d5d3008925da4434ce60
Author: Mingtian Yin <mtyin@google.com>
Date: Thu Oct 18 17:55:40 2018

Fix uploaded, wait for one goldeneye build to verify.
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 19

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/platform/gdisp/+/e2ff88c883565f6370fcbd1d2e8a4f1a1b39be13

commit e2ff88c883565f6370fcbd1d2e8a4f1a1b39be13
Author: Mingtian Yin <mtyin@google.com>
Date: Fri Oct 19 05:38:00 2018

Cc: -seobrien@chromium.org
Is this fixed?
Status: Fixed (was: Assigned)
Mark fixed.

Sign in to add a comment