New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 896383 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit 20 days ago
Closed: Oct 25
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Disambiguate starting the android messages service worker on session start vs. NoControllees

Project Member Reported by jonm...@google.com, Oct 17

Issue description

Currently we always send a 'start_streaming_connection' message to start the service worker.  In the NoControllees case we should send 'resume_streaming_connection' instead.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb19371760eee8c9391745b8b955816389f59aee

commit eb19371760eee8c9391745b8b955816389f59aee
Author: Jon Mann <jonmann@chromium.org>
Date: Tue Oct 23 21:54:23 2018

[Android Messages] Add ability to resume streaming session.

This ensures connection to the Android Messages backend is not taken if
another device is active and the user closes the tab or PWA. When the
service worker connects with the backend it needs to send a
START_STREAMING message if the device wasn't previously connected in
order to start receiving messages.  If this message is sent when a
different device is conencted, the other device will lose the
connection. Closing the active tab or PWA is not an action which should
take the connection from another device so in this case we don't want
to send the start message.  This new 'resume_streaming_connection'
informs the service worker that it should connect and not send the
START_STREAMING message.

Bug:  896383 
Change-Id: Ie0e27461d29679c7c969bfd45c39e1dfb39da515
Reviewed-on: https://chromium-review.googlesource.com/c/1287264
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Jon Mann <jonmann@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602118}
[modify] https://crrev.com/eb19371760eee8c9391745b8b955816389f59aee/chrome/browser/chromeos/android_sms/connection_establisher.h
[modify] https://crrev.com/eb19371760eee8c9391745b8b955816389f59aee/chrome/browser/chromeos/android_sms/connection_establisher_impl.cc
[modify] https://crrev.com/eb19371760eee8c9391745b8b955816389f59aee/chrome/browser/chromeos/android_sms/connection_establisher_impl.h
[modify] https://crrev.com/eb19371760eee8c9391745b8b955816389f59aee/chrome/browser/chromeos/android_sms/connection_establisher_impl_unittest.cc
[modify] https://crrev.com/eb19371760eee8c9391745b8b955816389f59aee/chrome/browser/chromeos/android_sms/connection_manager.cc
[modify] https://crrev.com/eb19371760eee8c9391745b8b955816389f59aee/chrome/browser/chromeos/android_sms/fake_connection_establisher.cc
[modify] https://crrev.com/eb19371760eee8c9391745b8b955816389f59aee/chrome/browser/chromeos/android_sms/fake_connection_establisher.h

Status: Fixed (was: Assigned)

Sign in to add a comment