Download home v2: Enable feature on trunk. |
||
Issue descriptionChrome Version: 72.* OS: Android We can enable kDownloadHomeV2 feature on trunk for M72. The A/B testing will be managed by finch and might target M71.
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fb6997c9b2c0d13adeafeb51187a93ad24c3b8b6 commit fb6997c9b2c0d13adeafeb51187a93ad24c3b8b6 Author: Xing Liu <xingliu@chromium.org> Date: Tue Oct 23 17:21:21 2018 Download home v2: Enable feature by default on Android. This CL enables download home v2 feature. The A/B testing in the future will be managed by finch. Bug: 896374 Change-Id: I0c2c87425ea91b336bf4dc0b2378d40e156043a2 Reviewed-on: https://chromium-review.googlesource.com/c/1286284 Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#602000} [modify] https://crrev.com/fb6997c9b2c0d13adeafeb51187a93ad24c3b8b6/chrome/browser/android/chrome_feature_list.cc
,
Oct 23
,
Oct 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/afcda86dcb222069a47c18e16e0468ea9c58ef38 commit afcda86dcb222069a47c18e16e0468ea9c58ef38 Author: Xing Liu <xingliu@chromium.org> Date: Thu Oct 25 02:07:52 2018 Revert "Download home v2: Enable feature by default on Android." This reverts commit fb6997c9b2c0d13adeafeb51187a93ad24c3b8b6. Reason for revert: Shouldn't enable in code base and totally rely on finch. Original change's description: > Download home v2: Enable feature by default on Android. > > This CL enables download home v2 feature. The A/B testing in the future > will be managed by finch. > > Bug: 896374 > Change-Id: I0c2c87425ea91b336bf4dc0b2378d40e156043a2 > Reviewed-on: https://chromium-review.googlesource.com/c/1286284 > Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Commit-Queue: Xing Liu <xingliu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#602000} TBR=dtrainor@chromium.org,shaktisahu@chromium.org,xingliu@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 896374 Change-Id: Ica6a6107edd03e06a77414b0f57886f28f70241f Reviewed-on: https://chromium-review.googlesource.com/c/1298733 Reviewed-by: Xing Liu <xingliu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#602578} [modify] https://crrev.com/afcda86dcb222069a47c18e16e0468ea9c58ef38/chrome/browser/android/chrome_feature_list.cc |
||
►
Sign in to add a comment |
||
Comment 1 by xingliu@chromium.org
, Oct 17