Depot Tools not reporting metrics on Windows |
||
Issue descriptionBigQuery metrics for depot tools does not include any results for windows. You can validate this by running the following query: SELECT host_os, command FROM metrics.depot_tools WHERE host_os != "linux" AND host_os != "mac" and see that there are no results. What is the expected result? There should be some data for Windows. Query written as is because I wasn't 100% sure if the os would be "win", "windows" or something else. But it would show up regardless with the above query. What happens instead? There are no results. Please provide any additional information below. Attach a screenshot if possible.
,
Oct 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/4ac892e4d1266937a48f77a87bb4d16b86982230 commit 4ac892e4d1266937a48f77a87bb4d16b86982230 Author: Edward Lemur <ehmaldonado@chromium.org> Date: Thu Oct 18 00:41:56 2018 Use lowercase machine architecture. Bug: 896355 Change-Id: I83a3c27478029d90206b5bb26e26797df47a90f6 Reviewed-on: https://chromium-review.googlesource.com/c/1287244 Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> [modify] https://crrev.com/4ac892e4d1266937a48f77a87bb4d16b86982230/detect_host_arch.py
,
Oct 18
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/b74c3b27b1fb8f60c969e9f158c86d49b56f3d4b commit b74c3b27b1fb8f60c969e9f158c86d49b56f3d4b Author: Edward Lemur <ehmaldonado@chromium.org> Date: Thu Oct 18 00:59:38 2018 depot_tools-metrics: Log errors. Bug: 896355 Change-Id: Ib34aceab4bd73b4ef984d008563d956de59658df Reviewed-on: https://chromium-review.googlesource.com/c/1287022 Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#18420} [modify] https://crrev.com/b74c3b27b1fb8f60c969e9f158c86d49b56f3d4b/go/src/infra/appengine/depot_tools_metrics/metrics/app.go
,
Oct 18
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/a9a0c8f66767b54626ab563091a101b14d0b6a86 commit a9a0c8f66767b54626ab563091a101b14d0b6a86 Author: Edward Lemur <ehmaldonado@chromium.org> Date: Thu Oct 18 01:50:59 2018 depot_tools-metrics: Fix schema. x86 is a valid architecture, and 2.7.6 is a valid Python version. Bug: 896355 Change-Id: I639dbafcde8c185ec03cc2b247a7a81631061765 Reviewed-on: https://chromium-review.googlesource.com/c/1287589 Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#18428} [modify] https://crrev.com/a9a0c8f66767b54626ab563091a101b14d0b6a86/go/src/infra/appengine/depot_tools_metrics/metrics/metrics_schema.json
,
Oct 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3fdee98c1c33b01fcfe216f15e73d991d3bc1d1e commit 3fdee98c1c33b01fcfe216f15e73d991d3bc1d1e Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Oct 18 04:38:04 2018 Roll src/third_party/depot_tools 08faab99d41b..488362624b6d (5 commits) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/08faab99d41b..488362624b6d git log 08faab99d41b..488362624b6d --date=short --no-merges --format='%ad %ae %s' 2018-10-18 ehmaldonado@chromium.org metrics: Add a mechanism to notify users when we want to collect additional metrics. 2018-10-18 tandrii@chromium.org git cl land: remove Rietveld-only options. 2018-10-18 tandrii@chromium.org Reland "git cl: delete no longer used Rietveld methods." 2018-10-18 ehmaldonado@chromium.org Use lowercase machine architecture. 2018-10-17 jbudorick@chromium.org bot_update: stop failing with a KeyError in the recipe on failure. Created with: gclient setdep -r src/third_party/depot_tools@488362624b6d The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None,chromium:770408,chromium:770408,chromium:895784,chromium:896355 TBR=agable@chromium.org Change-Id: I0a0fc6c3a5b488b1480c808f4b0d2f5d791cfa38 Reviewed-on: https://chromium-review.googlesource.com/c/1288015 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#600659} [modify] https://crrev.com/3fdee98c1c33b01fcfe216f15e73d991d3bc1d1e/DEPS
,
Oct 18
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/240cdbfdfb1bc63b1e09b6aee2272bb68f36382d commit 240cdbfdfb1bc63b1e09b6aee2272bb68f36382d Author: Edward Lemur <ehmaldonado@chromium.org> Date: Thu Oct 18 17:54:24 2018 depot_tools_metrics: Add AMD64 to known archs. This was fixed for depot_tools on crrev.com/c/1287244 but some developers still have an outdated checkout. Tbr: tandrii@chromium.org Bug: 896355 Change-Id: Iffa7bde01e658ed7cf2111f73892cda1ba1984bf Reviewed-on: https://chromium-review.googlesource.com/c/1289000 Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#18443} [modify] https://crrev.com/240cdbfdfb1bc63b1e09b6aee2272bb68f36382d/go/src/infra/appengine/depot_tools_metrics/metrics/metrics_schema.json
,
Oct 18
|
||
►
Sign in to add a comment |
||
Comment 1 by mmenke@chromium.org
, Oct 17