New issue
Advanced search Search tips

Issue 896334 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 5
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

AEC3: Faster delay detection is needed

Project Member Reported by peah@chromium.org, Oct 17

Issue description

The delay estimator in AEC3 should as rapidly as possibly achieve an delay estimate. The earlier that is, the better the transparency is, and the lower the risk is for echo leakage.

Test results indicate that there are issues with choppy audio, and one potential culprit for this could be a slow delay detection.
 
 
Status: Assigned (was: Untriaged)
Assigning these all to you, since it looks like you reported them and they're about AEC3. Untriaged needs to get triaged. :)
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 31

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/8b7d206d37ba42a0b14e34440180ebb8566845b8

commit 8b7d206d37ba42a0b14e34440180ebb8566845b8
Author: Per Åhgren <peah@webrtc.org>
Date: Wed Oct 31 07:29:48 2018

AEC3: Decrease latency until the delay has been detected

This CL utilizes the existing, but unused, ability to set
different histogram thresholds for early and late delay
estimation. It does so by tuning the parameters for these.

On top of that, some corrections are added to correctly
handle resets and the use of the hysteresis thresholds.

Bug: webrtc:19886, chromium:896334 
Change-Id: I950ac107c124541af8f02b4403f477dda71cc1a1
Reviewed-on: https://webrtc-review.googlesource.com/c/106706
Reviewed-by: Sam Zackrisson <saza@webrtc.org>
Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org>
Commit-Queue: Per Åhgren <peah@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25443}
[modify] https://crrev.com/8b7d206d37ba42a0b14e34440180ebb8566845b8/api/audio/echo_canceller3_config.h
[modify] https://crrev.com/8b7d206d37ba42a0b14e34440180ebb8566845b8/modules/audio_processing/aec3/block_processor.cc
[modify] https://crrev.com/8b7d206d37ba42a0b14e34440180ebb8566845b8/modules/audio_processing/aec3/block_processor2.cc
[modify] https://crrev.com/8b7d206d37ba42a0b14e34440180ebb8566845b8/modules/audio_processing/aec3/echo_canceller3.cc
[modify] https://crrev.com/8b7d206d37ba42a0b14e34440180ebb8566845b8/modules/audio_processing/aec3/echo_path_delay_estimator.cc
[modify] https://crrev.com/8b7d206d37ba42a0b14e34440180ebb8566845b8/modules/audio_processing/aec3/echo_path_delay_estimator.h
[modify] https://crrev.com/8b7d206d37ba42a0b14e34440180ebb8566845b8/modules/audio_processing/aec3/matched_filter_lag_aggregator.cc
[modify] https://crrev.com/8b7d206d37ba42a0b14e34440180ebb8566845b8/modules/audio_processing/aec3/matched_filter_lag_aggregator.h
[modify] https://crrev.com/8b7d206d37ba42a0b14e34440180ebb8566845b8/modules/audio_processing/aec3/mock/mock_render_delay_controller.h
[modify] https://crrev.com/8b7d206d37ba42a0b14e34440180ebb8566845b8/modules/audio_processing/aec3/render_delay_controller.cc
[modify] https://crrev.com/8b7d206d37ba42a0b14e34440180ebb8566845b8/modules/audio_processing/aec3/render_delay_controller.h
[modify] https://crrev.com/8b7d206d37ba42a0b14e34440180ebb8566845b8/modules/audio_processing/aec3/render_delay_controller2.cc
[modify] https://crrev.com/8b7d206d37ba42a0b14e34440180ebb8566845b8/test/fuzzers/audio_processing_configs_fuzzer.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd7a84174d196972a7885ad883827d40190ef7b0

commit fd7a84174d196972a7885ad883827d40190ef7b0
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Wed Oct 31 11:02:42 2018

Roll src/third_party/webrtc f577ab3d38f9..8b7d206d37ba (1 commits)

https://webrtc.googlesource.com/src.git/+log/f577ab3d38f9..8b7d206d37ba


git log f577ab3d38f9..8b7d206d37ba --date=short --no-merges --format='%ad %ae %s'
2018-10-31 peah@webrtc.org AEC3: Decrease latency until the delay has been detected


Created with:
  gclient setdep -r src/third_party/webrtc@8b7d206d37ba

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG= chromium:896334 
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I4959a12dc3a5557463627b200eac455332ce4249
Reviewed-on: https://chromium-review.googlesource.com/c/1309539
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#604205}
[modify] https://crrev.com/fd7a84174d196972a7885ad883827d40190ef7b0/DEPS

Labels: Merge-Request-71
We would like a merge of this issue to M71 as it addresses the aspect of choppy audio which has been raised as an issue both in M69 and M70.

The CL has been well tested both in Canary an offline and has been shown to perform as designed. The merge is considered safe as it is only active beneath a finch experiment and also has a dedicated kill-switch which can be used to deactivate the feature.
Project Member

Comment 5 by sheriffbot@chromium.org, Nov 5

Labels: -Merge-Request-71 Hotlist-Merge-Review Merge-Review-71
This bug requires manual review: DEPS changes referenced in bugdroid comments.
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-71 Merge-Approved-71
Approving merge to M71 branch 3578 based on comment #4. Please merge ASAP. Thank you.
The CL has now been merged. The merging CL is
-https://webrtc-review.googlesource.com/c/src/+/109463
Labels: -Merge-Approved-71 Merge-Merged
Status: Fixed (was: Assigned)

Sign in to add a comment