New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 896323 link

Starred by 1 user
Status: Fixed
Owner:
dgarr...@chromium.org
Closed: Dec 12
Cc:
█ wonderfly@chromium.org
vapier@chromium.org
athilenius@chromium.org
la...@chromium.org
chromeos-continuous-integration-fire-hose@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature

Blocked on:
issue 897856


Sign in to add a comment

Publish External Build Artifacts

Project Member Reported by dgarr...@chromium.org, Oct 17 
Some of our external builders should have their artifacts published externally. This has been discussed in terms of paladin builders, but on reflection, I think we should be publishing artifacts from our "full"builders.

I will confirm, but I don't believe any of the full builders run hwtests.

That means it should be fairly straight forward to move the build artifacts they generate to a new external bucket.

I propose creating a new bucket "chromiumos-image-archive" which will be world readadable, and that the full builders start publishing artifacts to it using the same directory layout currently used in chromeos-image-archive.

This can be implemented by setting the build config value "gs_path" for the full builders.

We then need to publish pointers to the new bucket externally.

Comment 1 by vapier@chromium.org, Oct 18 

all the public builders we already were using "public-read" for their ACLs so people could access the files directly

creating a new "chromiumos-image-archive" with world-readable default ACLs sounds good

we could set a better/harder expiration on these too i think since no released image would rely on them

Comment 2 by dgarr...@chromium.org, Oct 19

Owner: dgarr...@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/ad51a83216ec21394e07572fabee1bfb5d7f00b6

commit ad51a83216ec21394e07572fabee1bfb5d7f00b6
Author: Don Garrett <dgarrett@google.com>
Date: Sun Oct 21 22:28:10 2018

chromeos_config: full builder to chromiumos-image-archive.

Move the build artifacts for full builders to the world readable
chromiumos-image-archive bucket.

BUG= chromium:896323 
TEST=run_tests

Change-Id: I04b46fae8b37d2c7bfb96e1b9e2338aaabfa85d1
Reviewed-on: https://chromium-review.googlesource.com/1292670
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Jason Clinton <jclinton@chromium.org>

[modify] https://crrev.com/ad51a83216ec21394e07572fabee1bfb5d7f00b6/config/chromeos_config.py
[modify] https://crrev.com/ad51a83216ec21394e07572fabee1bfb5d7f00b6/config/config_dump.json

Comment 4 by dgarr...@chromium.org, Oct 22 

The new artifacts are being published, but we need to confirm that access works correctly, and document it appropriately.
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 22 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/e95b3501075939b7f5fb18960e44613981729edf

commit e95b3501075939b7f5fb18960e44613981729edf
Author: Don Garrett <dgarrett@chromium.org>
Date: Mon Oct 22 19:59:28 2018

Revert "chromeos_config: full builder to chromiumos-image-archive."

This reverts commit ad51a83216ec21394e07572fabee1bfb5d7f00b6.

Reason for revert: https://crbug.com/897856

Original change's description:
> chromeos_config: full builder to chromiumos-image-archive.
>
> Move the build artifacts for full builders to the world readable
> chromiumos-image-archive bucket.
>
> BUG= chromium:896323 
> TEST=run_tests
>
> Change-Id: I04b46fae8b37d2c7bfb96e1b9e2338aaabfa85d1
> Reviewed-on: https://chromium-review.googlesource.com/1292670
> Commit-Ready: Don Garrett <dgarrett@chromium.org>
> Tested-by: Don Garrett <dgarrett@chromium.org>
> Reviewed-by: Jason Clinton <jclinton@chromium.org>

Bug:  chromium:896323 
Change-Id: I1938bf36896d096967f4f829ef97c667d65d41ce
Reviewed-on: https://chromium-review.googlesource.com/1294273
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/e95b3501075939b7f5fb18960e44613981729edf/config/chromeos_config.py
[modify] https://crrev.com/e95b3501075939b7f5fb18960e44613981729edf/config/config_dump.json

Comment 6 by dgarr...@chromium.org, Nov 5

Blockedon: 897856

Comment 7 by jclinton@chromium.org, Dec 12

Labels: -Type-Bug Type-Feature
Status: Fixed (was: Started)
►

Sign in to add a comment