Issue 896303 link

Starred by 2 users

Issue metadata

Status:	Available
Owner:	----
Cc:	mastiz@chromium.org treib@chromium.org ios-bugs@chromium.org █ tschumann@chromium.org
Components:	Services>Sync
EstimatedDays:	----
NextAction:	----
OS:	Linux , Android , Windows , iOS , Chrome , Mac
Pri:	3
Type:	Task
sync-fixit-2018q4

Evaluate split between components/sync vs components/browser_sync

Project Member Reported by treib@chromium.org, Oct 17

Issue description

I *think* the main difference is that components/browser_sync has dependencies to all the individual data type implementations. However, then it seems like large parts of /browser_sync could move up into /sync, in particular ProfileSyncService and SyncAuthManager - basically only ProfileSyncComponentsFactoryImpl would remain in /browser_sync.

Project Member

Comment 1 by bugdroid1@chromium.org, Oct 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95af8b1210304750d16a3cad3ad73734526abf42

commit 95af8b1210304750d16a3cad3ad73734526abf42
Author: Marc Treib <treib@chromium.org>
Date: Thu Oct 18 12:53:57 2018

Remove unnecessary dependencies from /components/sync and /browser_sync

Bug: 896303
Change-Id: Icf856bfa95640cbb44e75d35cc0e8514aac69e62
Reviewed-on: https://chromium-review.googlesource.com/c/1286850
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600739}
[modify] https://crrev.com/95af8b1210304750d16a3cad3ad73734526abf42/components/browser_sync/BUILD.gn
[modify] https://crrev.com/95af8b1210304750d16a3cad3ad73734526abf42/components/browser_sync/DEPS
[modify] https://crrev.com/95af8b1210304750d16a3cad3ad73734526abf42/components/browser_sync/profile_sync_components_factory_impl.cc
[modify] https://crrev.com/95af8b1210304750d16a3cad3ad73734526abf42/components/browser_sync/profile_sync_service.cc
[modify] https://crrev.com/95af8b1210304750d16a3cad3ad73734526abf42/components/sync/BUILD.gn
[modify] https://crrev.com/95af8b1210304750d16a3cad3ad73734526abf42/components/sync/DEPS
[modify] https://crrev.com/95af8b1210304750d16a3cad3ad73734526abf42/components/sync/driver/DEPS

Comment 2 by treib@chromium.org, Oct 31

Labels: sync-fixit-2018q4

►

Issue 896303 link

Issue metadata

Evaluate split between components/sync vs components/browser_sync

Issue description

Comment 1 by bugdroid1@chromium.org, Oct 18

Comment 1 Deleted

Comment 2 by treib@chromium.org, Oct 31

Comment 2 Deleted

Sign in to add a comment