New issue
Advanced search Search tips

Issue 896296 link

Starred by 1 user
Status: Fixed
Owner:
tbansal@chromium.org
Closed: Nov 6
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Restrict GetWifiSSID() call to OS_ANDROID

Project Member Reported by tbansal@chromium.org, Oct 17 
In data proxy, GetWifiSSID() call is made to get WiFi SSID. However, calling this on non-Android platforms may result in hung IO loops (See Issue 823823).

One simple (and somewhat hacky) way to get around this is to restrict the GetWifiSSID() call in DataProxy to OS_ANDROID.

Comment 1 by ryansturm@chromium.org, Oct 30

Owner: tbansal@chromium.org
Can you mark this as available or assigned?

Comment 2 by tbansal@chromium.org, Oct 31

Status: Assigned (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/40f1c350d018b34ff7aa0c85a0fbc899d943d204

commit 40f1c350d018b34ff7aa0c85a0fbc899d943d204
Author: Tarun Bansal <tbansal@chromium.org>
Date: Tue Nov 06 19:19:05 2018

In DRP, call net::GetWiFiSSID only on Android.

In data reduction proxy, do not call GetWiFiSSID()
on non-Android platforms since it may call hung IO
loop. See the associated bug.

Bug:  896296 
Change-Id: I85ca975465505696f627e77594c27a4ddbe1838e
Reviewed-on: https://chromium-review.googlesource.com/c/1319329
Reviewed-by: rajendrant <rajendrant@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605776}
[modify] https://crrev.com/40f1c350d018b34ff7aa0c85a0fbc899d943d204/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc

Comment 4 by tbansal@chromium.org, Nov 6

Status: Fixed (was: Assigned)
►

Sign in to add a comment