New issue
Advanced search Search tips

Issue 896295 link

Starred by 2 users
Status: Assigned
Owner:
schenney@chromium.org
Cc:
arthurso...@chromium.org
vmp...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

text decorations are not included in the visual overflow for elements

Project Member Reported by arthurso...@chromium.org, Oct 17 
Google Chrome:	69.0.3497.100 (Official Build) (64-bit)
Revision: 8920e690dd011895672947112477d10d5c8afb09-refs/branch-heads/3497@{#948}
OS: Linux

What steps will reproduce the problem?
(1) Go to https://css-tricks.com/almanac/properties/t/text-decoration-style/
(2) Scroll the iframe.
(3) Look at the bottom of the iframe. You should be able to see remaining of previous drawing. (See video)
out-26.ogv
2.8 MB View Download

Comment 1 by arthurso...@chromium.org, Oct 17

Summary: Iframe's render buffer not properly invalidated after a scroll. (was: text-decoration-style wavy not cleared after scrolling in an iframe.)
Updating title. I can reproduce with text-decoration-style: double. So this is probably not related to "wavy" and maybe not related to "text-decoration-style".

Comment 2 by arthurso...@chromium.org, Oct 17

Components: -Blink>Paint Blink>Paint>Invalidation

Comment 3 by schenney@chromium.org, Oct 17

Components: -Internals>Compositing>Scroll
Labels: -Pri-3 Pri-1
Status: Available (was: Untriaged)
It's an invalidation bug that's actually been around a while, though it might have got worse with raster changes.

All the underline styles are not accounted for, it seems, in the invalidation rect for the text box.

We need to fix this.

Comment 4 by schenney@chromium.org, Oct 17

Owner: schenney@chromium.org
I'll try to generate a reduced test case.

Comment 5 by schenney@chromium.org, Oct 17

Status: Assigned (was: Available)
I'm guessing we knew about this but never looked into it.

https://bugs.chromium.org/p/chromium/issues/detail?id=496320

Comment 6 by schenney@chromium.org, Oct 17 

Reduced test case. Scroll slowly.
cr896295.html
1.6 KB View Download

Comment 7 by chrishtr@chromium.org, Nov 24 

The paint rectangles clearly indicate that the invalidation is not reaching the
full extent of a wavy or double underline.

Comment 8 by schenney@chromium.org, Dec 3 

The issue is that the visual rects for the decorations are not included, because they are not known about until painting (and not even clearly computed then). I got started on refactoring to make it possible, but it's not high enough priority right now.

Comment 9 by schenney@chromium.org, Dec 6

Summary: text decorations are not included in the visual overflow for elements (was: Iframe's render buffer not properly invalidated after a scroll.)

Comment 10 by schenney@chromium.org, Dec 6

Labels: -Pri-1 Pri-2

Comment 11 by schenney@chromium.org, Jan 17 (6 days ago) 

 Issue 922272  has been merged into this issue.
►

Sign in to add a comment