New issue
Advanced search Search tips

Issue 896285 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 19
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

SetProxyOverride method should not allow a null host string

Project Member Reported by laisminchillo@google.com, Oct 17

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Oct 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4964a91688af7cab4a3ebbd731ef6f47b34a21eb

commit 4964a91688af7cab4a3ebbd731ef6f47b34a21eb
Author: Laís Minchillo <laisminchillo@chromium.org>
Date: Thu Oct 18 11:48:56 2018

[aw] Don't allow null host string in setProxyOverride

Null Java strings shouldn't be passed down to C++ code. This CL adds
code to check for a null host string or null strings in exclusionList
and throw a null pointer exception.

Bug:  896285 
Change-Id: I6af64350de8a93031741c8951a7efe2df7111ccd
Reviewed-on: https://chromium-review.googlesource.com/c/1286849
Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Commit-Queue: Laís Minchillo <laisminchillo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600731}
[modify] https://crrev.com/4964a91688af7cab4a3ebbd731ef6f47b34a21eb/android_webview/glue/java/src/com/android/webview/chromium/SharedStatics.java

Labels: Merge-Request-71
Project Member

Comment 3 by sheriffbot@chromium.org, Oct 19

Labels: -Merge-Request-71 Hotlist-Merge-Approved Merge-Approved-71
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Fixed (was: Started)
Project Member

Comment 5 by sheriffbot@chromium.org, Oct 22

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by sheriffbot@chromium.org, Oct 26

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Approved -Merge-Approved-71
Please add the manual verification steps if any.

Comment 9 by laisminchillo@chromium.org, Jan 17 (5 days ago)

To manually verify this just run tests in AwProxyControllerTest

Sign in to add a comment