WPR: Support appending single urls to existing archive |
||||
Issue descriptionIn order to stabilise certain benchmarks it seems crucial to be able to manually append certain get requests to an existing archive. The process is roughly as follows: 1. replay benchmark, store failing requests into a.log 2. replay benchmark, store failing reguests into b.log 3. find matching 404 requests in a.log and b.log 4. append found requests to existing archive
,
Nov 2
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/a6ef719b69f40c9fa53185c757ff742d91c08260 commit a6ef719b69f40c9fa53185c757ff742d91c08260 Author: Camillo Bruni <cbruni@chromium.org> Date: Fri Nov 02 13:22:51 2018 [wpr] Add httparchive.go merge command The new command merges two wpr archives into a single archive. All requests where the query doesn't fully match are added for completeness. Bug: chromium:896280 Change-Id: I9ee1ad8a623dc1eeed2260ad043f56286aa80ee1 Reviewed-on: https://chromium-review.googlesource.com/c/1299034 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Ned Nguyen <nednguyen@google.com> [modify] https://crrev.com/a6ef719b69f40c9fa53185c757ff742d91c08260/telemetry/telemetry/internal/binary_dependencies.json [modify] https://crrev.com/a6ef719b69f40c9fa53185c757ff742d91c08260/web_page_replay_go/src/webpagereplay/archive_test.go [modify] https://crrev.com/a6ef719b69f40c9fa53185c757ff742d91c08260/web_page_replay_go/src/webpagereplay/archive.go [modify] https://crrev.com/a6ef719b69f40c9fa53185c757ff742d91c08260/telemetry/bin/update_wpr_go_binary [modify] https://crrev.com/a6ef719b69f40c9fa53185c757ff742d91c08260/web_page_replay_go/src/httparchive.go
,
Nov 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/10d433b7dc970ce02e48623efa6fabcd4c14b892 commit 10d433b7dc970ce02e48623efa6fabcd4c14b892 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Nov 02 15:22:39 2018 Roll src/third_party/catapult 971689c0597c..a6ef719b69f4 (1 commits) https://chromium.googlesource.com/catapult.git/+log/971689c0597c..a6ef719b69f4 git log 971689c0597c..a6ef719b69f4 --date=short --no-merges --format='%ad %ae %s' 2018-11-02 cbruni@chromium.org [wpr] Add httparchive.go merge command Created with: gclient setdep -r src/third_party/catapult@a6ef719b69f4 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG= chromium:896280 TBR=sullivan@chromium.org Change-Id: I618bb6d1addf22744622d33888dd53a452625cf7 Reviewed-on: https://chromium-review.googlesource.com/c/1314104 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604926} [modify] https://crrev.com/10d433b7dc970ce02e48623efa6fabcd4c14b892/DEPS
,
Nov 19
I've successfully patched up existing archives and greatly reduced the number of failing network requests: https://v2spa-dot-chromeperf.appspot.com/#session=c1a5e940d5ef0794e3b076185d849ffff590ec6215a074aee395cf5d98e28045
,
Dec 13
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/203676d4b1866069d98657bdf1ba3e5bddbaae97 commit 203676d4b1866069d98657bdf1ba3e5bddbaae97 Author: Camillo Bruni <cbruni@chromium.org> Date: Thu Dec 13 13:23:42 2018 [wpr] Add --overwrite-existing and --skip-existing flags to httparchive.go - Introduce AddMode for Archive.addArchivedRequest - add addUrl helper function - Introduce command line flags for add and addAll: --overwrite-existing Replace any existing requests in the archive with the same URL --skip-existing Do not modify existing requests in the archive with matching URLs Drive-by-fix: - Fix archive.ForEach usage in list command Bug: chromium:896280 Change-Id: If25295b5d07161b0840a23bbbf31bcecd9cc3527 Reviewed-on: https://chromium-review.googlesource.com/c/1339920 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Yiming Zhou <uwyiming@google.com> Reviewed-by: Ned Nguyen <nednguyen@google.com> [modify] https://crrev.com/203676d4b1866069d98657bdf1ba3e5bddbaae97/web_page_replay_go/src/httparchive.go [modify] https://crrev.com/203676d4b1866069d98657bdf1ba3e5bddbaae97/web_page_replay_go/src/webpagereplay/archive_test.go [modify] https://crrev.com/203676d4b1866069d98657bdf1ba3e5bddbaae97/telemetry/telemetry/internal/binary_dependencies.json [modify] https://crrev.com/203676d4b1866069d98657bdf1ba3e5bddbaae97/web_page_replay_go/src/webpagereplay/archive.go
,
Dec 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bc8527b0db416c0a5003b51e9d52ad98467c1346 commit bc8527b0db416c0a5003b51e9d52ad98467c1346 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Dec 13 14:34:36 2018 Roll src/third_party/catapult 368ebf1e07cb..203676d4b186 (1 commits) https://chromium.googlesource.com/catapult.git/+log/368ebf1e07cb..203676d4b186 git log 368ebf1e07cb..203676d4b186 --date=short --no-merges --format='%ad %ae %s' 2018-12-13 cbruni@chromium.org [wpr] Add --overwrite-existing and --skip-existing flags to httparchive.go Created with: gclient setdep -r src/third_party/catapult@203676d4b186 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG= chromium:896280 TBR=sullivan@chromium.org Change-Id: Ib2d5f203bf9ddd45b704441ed4c54230477bf50f Reviewed-on: https://chromium-review.googlesource.com/c/1375543 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#616305} [modify] https://crrev.com/bc8527b0db416c0a5003b51e9d52ad98467c1346/DEPS
,
Jan 16
(6 days ago)
,
Jan 16
(6 days ago)
|
||||
►
Sign in to add a comment |
||||
Comment 1 by cbruni@google.com
, Oct 31