New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 896276 link

Starred by 1 user
Status: Fixed
Owner:
█ wnwen@chromium.org
OOO until Feb 4th
Closed: Oct 25
Cc:
smaier@chromium.org
mheikal@chromium.org
boliu@chromium.org
ssid@chromium.org
yfried...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Feature



Sign in to add a comment

Add CrashKey for Clank in foreground vs background

Project Member Reported by wnwen@chromium.org, Oct 17 
Similar to updating clean_shutdown_beacon when Clank transitions between foreground and background (onPause/onResume), update a CrashKey so that minidumps contain this information too.

See more pros/cons and context here: http://go/background-uma#bookmark=id.uy22ltpxikrz

Comment 1 by wnwen@chromium.org, Oct 17

Labels: -M-72 Target-72

Comment 2 by wnwen@chromium.org, Oct 17

Labels: -Type-Bug Type-Feature

Comment 4 by wnwen@chromium.org, Oct 22

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/423ed0b543b81f87923d3c3a2c76920c38fa86ea

commit 423ed0b543b81f87923d3c3a2c76920c38fa86ea
Author: Peter Wen <wnwen@chromium.org>
Date: Thu Oct 25 15:48:56 2018

Android: Add crash key for app status

Adding whether the app was in foreground or background to browser
crashes allows us to better triage and prioritize crashes server side.

Only adding this for the browser process since it is where we can
reliably determine application status.

Bug:  896276 
Change-Id: Ia1625f8eafe65f1bcaeefedf95ca7b04d37c8fc3
Reviewed-on: https://chromium-review.googlesource.com/c/1286901
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602720}
[modify] https://crrev.com/423ed0b543b81f87923d3c3a2c76920c38fa86ea/chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java
[add] https://crrev.com/423ed0b543b81f87923d3c3a2c76920c38fa86ea/chrome/android/java/src/org/chromium/chrome/browser/crash/ApplicationStatusTracker.java
[modify] https://crrev.com/423ed0b543b81f87923d3c3a2c76920c38fa86ea/chrome/android/java/src/org/chromium/chrome/browser/crash/CrashKeys.java
[modify] https://crrev.com/423ed0b543b81f87923d3c3a2c76920c38fa86ea/chrome/android/java_sources.gni
[modify] https://crrev.com/423ed0b543b81f87923d3c3a2c76920c38fa86ea/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabTabPersistencePolicyTest.java
[modify] https://crrev.com/423ed0b543b81f87923d3c3a2c76920c38fa86ea/chrome/browser/android/crash/crash_keys_android.cc
[modify] https://crrev.com/423ed0b543b81f87923d3c3a2c76920c38fa86ea/chrome/browser/android/crash/crash_keys_android.h

Comment 6 by wnwen@chromium.org, Oct 25

Status: Fixed (was: Started)
Just need to monitor for the next canary/dev.
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 29 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e75e2bee26db726503c752796c03b7e06a6b57a

commit 4e75e2bee26db726503c752796c03b7e06a6b57a
Author: Peter Wen <wnwen@chromium.org>
Date: Mon Oct 29 14:55:45 2018

Android: Reduce method count

Actually implementing the listener avoids the need for a lambda inner
class and avoids the need for a new singleton.

Bug:  896276 
Change-Id: I420b1348e5f896bb6b7dc4fad663f88c8c71e997
Reviewed-on: https://chromium-review.googlesource.com/c/1300096
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603490}
[modify] https://crrev.com/4e75e2bee26db726503c752796c03b7e06a6b57a/chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java
[modify] https://crrev.com/4e75e2bee26db726503c752796c03b7e06a6b57a/chrome/android/java/src/org/chromium/chrome/browser/crash/ApplicationStatusTracker.java
►

Sign in to add a comment