Following the design doc below, if the number of open incognito windows are more than 1, show the number besides the incognito icon on the toolbar, and make the button clickable to show more info and offer closing all windows. https://docs.google.com/presentation/d/1jLmXwybjtUhImwfc4WtlCNaujkqfcfmA_ceRA1_um6o
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c158b18f51adaf33bc327179c0727e1669db8c3a commit c158b18f51adaf33bc327179c0727e1669db8c3a Author: Ramin Halavati <rhalavati@chromium.org> Date: Thu Oct 18 14:04:54 2018 Add feature::kEnableIncognitoWindowCounter for incognito window count. A feature and flag is added to control adding an incognito window counter to the incognito icon on toolbar. Bug: 896235 Change-Id: Ic0766f2344d9caefc7ede1e5266df053d32ef2d5 Reviewed-on: https://chromium-review.googlesource.com/c/1286423 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by: Ramin Halavati <rhalavati@chromium.org> Reviewed-by: Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#600751} [modify] https://crrev.com/c158b18f51adaf33bc327179c0727e1669db8c3a/chrome/browser/about_flags.cc [modify] https://crrev.com/c158b18f51adaf33bc327179c0727e1669db8c3a/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/c158b18f51adaf33bc327179c0727e1669db8c3a/chrome/browser/flag_descriptions.h [modify] https://crrev.com/c158b18f51adaf33bc327179c0727e1669db8c3a/chrome/common/chrome_features.cc [modify] https://crrev.com/c158b18f51adaf33bc327179c0727e1669db8c3a/chrome/common/chrome_features.h [modify] https://crrev.com/c158b18f51adaf33bc327179c0727e1669db8c3a/tools/metrics/histograms/enums.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4b84a13b80c41675b66fc596d07698109e9dfac9 commit 4b84a13b80c41675b66fc596d07698109e9dfac9 Author: Ramin Halavati <rhalavati@chromium.org> Date: Mon Oct 22 11:48:10 2018 Add number of incognito windows to toolbar icon. When more than one incognito windows are open, adds the number of open incognito windows to the incognito icon on the toolbar. The change is behind kEnableIncognitoWindowCounter flag and is off by default. Bug: 896235 Change-Id: I52c08700bd0ff75f355104738b7e49f9f8076a15 Reviewed-on: https://chromium-review.googlesource.com/c/1290938 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#601530} [modify] https://crrev.com/4b84a13b80c41675b66fc596d07698109e9dfac9/chrome/browser/ui/browser.cc [modify] https://crrev.com/4b84a13b80c41675b66fc596d07698109e9dfac9/chrome/browser/ui/browser_list.cc [modify] https://crrev.com/4b84a13b80c41675b66fc596d07698109e9dfac9/chrome/browser/ui/browser_list.h [modify] https://crrev.com/4b84a13b80c41675b66fc596d07698109e9dfac9/chrome/browser/ui/views/profiles/avatar_toolbar_button.cc [modify] https://crrev.com/4b84a13b80c41675b66fc596d07698109e9dfac9/chrome/browser/ui/views/profiles/avatar_toolbar_button.h
Issue 519290 has been merged into this issue.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/83d91ec06233d68ad78e43a7905e415b764763c6 commit 83d91ec06233d68ad78e43a7905e415b764763c6 Author: Ramin Halavati <rhalavati@chromium.org> Date: Tue Oct 30 08:10:10 2018 Add incognito window counter bubble. A bubble is added that is activated when user clicks on incognito icon on taskbar. The dialog provides the number of open incognito windows and an option to close them all. The feature is behind the off by default kEnableIncognitoWindowCounter flag. Bug: 896235 Change-Id: Idc5d73c4fdce0cf1e31aa09dd22799d967f2acc4 Reviewed-on: https://chromium-review.googlesource.com/c/1299155 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#603829} [modify] https://crrev.com/83d91ec06233d68ad78e43a7905e415b764763c6/chrome/app/generated_resources.grd [add] https://crrev.com/83d91ec06233d68ad78e43a7905e415b764763c6/chrome/app/generated_resources_grd/IDS_INCOGNITO_WINDOW_COUNTER_CLOSE_BUTTON.png.sha1 [add] https://crrev.com/83d91ec06233d68ad78e43a7905e415b764763c6/chrome/app/generated_resources_grd/IDS_INCOGNITO_WINDOW_COUNTER_MESSAGE.png.sha1 [add] https://crrev.com/83d91ec06233d68ad78e43a7905e415b764763c6/chrome/app/generated_resources_grd/IDS_INCOGNITO_WINDOW_COUNTER_TITLE.png.sha1 [modify] https://crrev.com/83d91ec06233d68ad78e43a7905e415b764763c6/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/83d91ec06233d68ad78e43a7905e415b764763c6/chrome/browser/ui/browser_dialogs.h [modify] https://crrev.com/83d91ec06233d68ad78e43a7905e415b764763c6/chrome/browser/ui/views/profiles/avatar_toolbar_button.cc [add] https://crrev.com/83d91ec06233d68ad78e43a7905e415b764763c6/chrome/browser/ui/views/profiles/incognito_window_count_view.cc [add] https://crrev.com/83d91ec06233d68ad78e43a7905e415b764763c6/chrome/browser/ui/views/profiles/incognito_window_count_view.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ae799d2d12aa581cf4441a654723d858abebe0a6 commit ae799d2d12aa581cf4441a654723d858abebe0a6 Author: Ramin Halavati <rhalavati@chromium.org> Date: Wed Jan 09 09:53:45 2019 Update Incognito Window Counter icon and menu. Updates toolbar button and menu for incognito windows count. Bug: 896235 Change-Id: Ic58cde658fc574bbb7b42bb159866107eafe84c9 Reviewed-on: https://chromium-review.googlesource.com/c/1350750 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#621094} [modify] https://crrev.com/ae799d2d12aa581cf4441a654723d858abebe0a6/chrome/app/generated_resources.grd [modify] https://crrev.com/ae799d2d12aa581cf4441a654723d858abebe0a6/chrome/app/generated_resources_grd/IDS_INCOGNITO_WINDOW_COUNTER_CLOSE_BUTTON.png.sha1 [modify] https://crrev.com/ae799d2d12aa581cf4441a654723d858abebe0a6/chrome/app/generated_resources_grd/IDS_INCOGNITO_WINDOW_COUNTER_MESSAGE.png.sha1 [modify] https://crrev.com/ae799d2d12aa581cf4441a654723d858abebe0a6/chrome/app/vector_icons/BUILD.gn [add] https://crrev.com/ae799d2d12aa581cf4441a654723d858abebe0a6/chrome/app/vector_icons/incognito_circle.icon [modify] https://crrev.com/ae799d2d12aa581cf4441a654723d858abebe0a6/chrome/browser/ui/views/profiles/avatar_toolbar_button.cc [modify] https://crrev.com/ae799d2d12aa581cf4441a654723d858abebe0a6/chrome/browser/ui/views/profiles/avatar_toolbar_button.h [modify] https://crrev.com/ae799d2d12aa581cf4441a654723d858abebe0a6/chrome/browser/ui/views/profiles/incognito_window_count_view.cc [modify] https://crrev.com/ae799d2d12aa581cf4441a654723d858abebe0a6/chrome/browser/ui/views/profiles/incognito_window_count_view.h
Comment 1 by rhalavati@chromium.org
, Oct 17