Issue metadata
Sign in to add a comment
|
Regression : 'I Agree' button font is huge than 'Skip' button in 'Google Play Terms of Service' window which available after 'You're signed in!' screen |
||||||||||||||||||||||
Issue descriptionChrome Version: 70.0.3538.69/11021.51.0 0 dev-channel Kip,Daisy and Reks OS: Chrome What steps will reproduce the problem? (1)Recover Build ->In Sign in Screen enter valid Email and Password ->After 'Please wait..' screen , 'You're signed in!' screen is seen -> click on 'Accept and continue' (2)Now in 'Google Play Terms of Service' window click on 'More' button -> observe 'I Agree' button font is huge than 'Skip' button (Please refer video and Screenshot) Expected: 'I Agree' button font should be same as font of 'Skip' button Actual: Instead 'I Agree' button font is huge than 'Skip' button This is Regression Issue as same is working fine in M-68
,
Dec 28
,
Dec 28
,
Dec 28
crrev.com/c/1392110 is in review.
,
Jan 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7ff495ca3fda2a44778a9607e6cd03a9a3a130ed commit 7ff495ca3fda2a44778a9607e6cd03a9a3a130ed Author: khmel@chromium.org <khmel@chromium.org> Date: Wed Jan 02 19:34:16 2019 arc: Fix different font for buttons in OOBE TEST=Manually BUG= 896221 Change-Id: I4be49faac0574372b52a009f912dabeb85ec7283 Reviewed-on: https://chromium-review.googlesource.com/c/1392110 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#619455} [modify] https://crrev.com/7ff495ca3fda2a44778a9607e6cd03a9a3a130ed/chrome/browser/resources/chromeos/login/arc_terms_of_service.html [modify] https://crrev.com/7ff495ca3fda2a44778a9607e6cd03a9a3a130ed/chrome/browser/resources/chromeos/login/screen_arc_terms_of_service.js
,
Jan 2
Requesting M72 merge.
,
Jan 2
,
Jan 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f0d1928a77b4b4f62b50a68bb7636382687a1b3e commit f0d1928a77b4b4f62b50a68bb7636382687a1b3e Author: khmel@chromium.org <khmel@chromium.org> Date: Wed Jan 02 22:58:19 2019 [Merge M72] arc: Fix different font for buttons in OOBE TEST=Manually BUG= 896221 Change-Id: I4be49faac0574372b52a009f912dabeb85ec7283 Reviewed-on: https://chromium-review.googlesource.com/c/1392110 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yury Khmel <khmel@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#619455}(cherry picked from commit 7ff495ca3fda2a44778a9607e6cd03a9a3a130ed) Reviewed-on: https://chromium-review.googlesource.com/c/1392604 Reviewed-by: Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#543} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/f0d1928a77b4b4f62b50a68bb7636382687a1b3e/chrome/browser/resources/chromeos/login/arc_terms_of_service.html [modify] https://crrev.com/f0d1928a77b4b4f62b50a68bb7636382687a1b3e/chrome/browser/resources/chromeos/login/screen_arc_terms_of_service.js
,
Jan 2
Here's a summary of the rules that were executed: - OnlyMergeApprovedChange: Rule Failed -- Revision f0d1928a77b4b4f62b50a68bb7636382687a1b3e was merged to refs/branch-heads/3626 branch with no merge approval from a TPM! Please explain why this change was merged to the branch! - AcknowledgeMerge: Notification Required --
,
Jan 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f0d1928a77b4b4f62b50a68bb7636382687a1b3e Commit: f0d1928a77b4b4f62b50a68bb7636382687a1b3e Author: khmel@chromium.org Commiter: khmel@chromium.org Date: 2019-01-02 22:58:19 +0000 UTC [Merge M72] arc: Fix different font for buttons in OOBE TEST=Manually BUG= 896221 Change-Id: I4be49faac0574372b52a009f912dabeb85ec7283 Reviewed-on: https://chromium-review.googlesource.com/c/1392110 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yury Khmel <khmel@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#619455}(cherry picked from commit 7ff495ca3fda2a44778a9607e6cd03a9a3a130ed) Reviewed-on: https://chromium-review.googlesource.com/c/1392604 Reviewed-by: Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#543} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
,
Jan 2
#9 Merge-Approved-72 was granted in #7
,
Jan 3
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by khmel@chromium.org
, Oct 17