New issue
Advanced search Search tips

Issue 896194 link

Starred by 1 user
Status: Untriaged
Owner: ----
Cc:
japhet@chromium.org
leszeks@chromium.org
delph...@chromium.org
hirosh...@chromium.org
peter@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Console messages can have junk line numbers

Project Member Reported by leszeks@chromium.org, Oct 17 
Console messages get their source position through some inference, first checking if there is an active V8 stack, then looking for an active HTML parser.

It looks like this inference can go wrong, which manifests itself as flakiness in the source location, which becomes flakiness in layout tests that print console messages. It appears that in these flaky cases, there are source line numbers with no associated source name.

Comment 1 by leszeks@chromium.org, Oct 17

Cc: delph...@chromium.org
cf. bugs  894792  and  894795 , and +delphick who experienced this with setTimeout behaviour changes.
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee70ab471ed6b18491e40b7e7586801f8e686abf

commit ee70ab471ed6b18491e40b7e7586801f8e686abf
Author: Leszek Swirski <leszeks@chromium.org>
Date: Wed Oct 17 14:09:47 2018

[tests] Ignore console line numbers without source files

Decrease scheduler flakes of layout tests which can incorrectly infer
console message line numbers depending on execution scheduling. Do this
by ignoring line numbers of console messages which do not have an
associated discovered source file.

Bug:  894792 
Bug:  894795 
Bug: 896194
Change-Id: Ic8565ba7ac4a2e036f9d333c319544efdc8a3601
Reviewed-on: https://chromium-review.googlesource.com/c/1283037
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Dan Elphick <delphick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600380}
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/content/shell/test_runner/web_frame_test_client.cc
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set-multiple-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/fast/css-grid-layout/named-grid-line-get-set-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/fast/dom/custom/element-upgrade-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/fast/dom/custom/exception-from-constructor-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/fast/dom/custom/isolated-world-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/fast/dom/shadow/apply-deep-in-document-scope-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-disable-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/fast/domurl/check-instanceof-domurl-functions-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/fast/events/event-isolated-world-clone-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/fast/events/events-in-isolated-world-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/fast/events/init-custom-event-isolated-world-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/fast/events/init-message-event-isolated-world-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/fast/forms/ValidityState-stepMismatch-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/fast/forms/color/color-value-sanitization-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/fast/forms/form-collection-radio-node-list-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/fast/forms/select/select-max-length-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/fast/frames/frame-name-reset-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/fast/frames/sandboxed-iframe-plugins-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/fast/mediastream/getusermedia-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-datachannel-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/fast/xmlhttprequest/xmlhttprequest-set-responsetype-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/html5lib/generated/run-webkit01-write-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/html5lib/webkit-resumer-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/http/tests/pointer-lock/iframe-sandboxed-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/http/tests/pointer-lock/iframe-sandboxed-nested-disallow-then-allow-pointer-lock-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/iframe-inside-csp-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/http/tests/security/isolatedWorld/bypass-main-world-csp-for-inline-script-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/http/tests/security/isolatedWorld/no-bypass-main-world-csp-for-delayed-execution-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/http/tests/security/isolatedWorld/sandboxed-iframe-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/http/tests/security/popup-allowed-by-sandbox-is-sandboxed-control-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/http/tests/security/popup-allowed-by-sandbox-is-sandboxed-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/http/tests/security/xss-exception-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/http/tests/websocket/bufferedAmount-after-close-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/http/tests/websocket/bufferedAmount-after-close-in-busy-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/getResponseHeader-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/07-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/08-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/09-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/10-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/11-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/12-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/13-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/14-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/15-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/16-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/17-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/18-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/19-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/20-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/21-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/22-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/23-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/24-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/25-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/26-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/27-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/28-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/29-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/30-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/31-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/32-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/33-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/34-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/35-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/36-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/37-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/38-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/39-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/40-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/41-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/42-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/43-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/44-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/45-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/46-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/47-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/redirect-cross-origin-tripmine-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/xhr-to-blob-in-isolated-world-expected.txt
[modify] https://crrev.com/ee70ab471ed6b18491e40b7e7586801f8e686abf/third_party/WebKit/LayoutTests/webexposed/custom-elements-expected.txt

Comment 3 by hirosh...@chromium.org, Oct 18

Cc: hirosh...@chromium.org japhet@chromium.org
►

Sign in to add a comment