New issue
Advanced search Search tips

Issue 896180 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 19
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 883318
issue 883330



Sign in to add a comment

Convert //chrome unittests that use identity_test_utils.h to use IdentityTestEnvironmentProfileAdaptor

Project Member Reported by blundell@chromium.org, Oct 17

Issue description

--
 
This allows us to remove dependencies on SigninManager/ProfileOAuth2TokenService from these tests.
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c3eb58e66506a97bf3f2797af8b3df57630c3f0

commit 5c3eb58e66506a97bf3f2797af8b3df57630c3f0
Author: Colin Blundell <blundell@chromium.org>
Date: Thu Oct 18 08:02:50 2018

Convert MediaRouterContextualMenu unittest to IdentityTestEnvironment

This change is possible now that there is infrastructure for glueing
an IdentityTestEnvironment to a Profile.

Bug:  896180 
Change-Id: I444b847636b4f709c9003ac3047bfc8e848bc049
Reviewed-on: https://chromium-review.googlesource.com/c/1286459
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600684}
[modify] https://crrev.com/5c3eb58e66506a97bf3f2797af8b3df57630c3f0/chrome/browser/ui/toolbar/media_router_contextual_menu_unittest.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e60ebe32177913db756006f18c0fa65f1833a6c

commit 5e60ebe32177913db756006f18c0fa65f1833a6c
Author: Colin Blundell <blundell@chromium.org>
Date: Thu Oct 18 08:37:17 2018

Remove stale identity_test_utils.h includes

Forgot to do this in the CLs converting away from these utils.

TBR=sdefresne@chromium.org

Bug:  896180 
Change-Id: Ifa1766efc5ec91c5313658d65fdfc0fc48bc9fe1
Reviewed-on: https://chromium-review.googlesource.com/c/1288529
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600695}
[modify] https://crrev.com/5e60ebe32177913db756006f18c0fa65f1833a6c/chrome/browser/ui/search/search_tab_helper_unittest.cc
[modify] https://crrev.com/5e60ebe32177913db756006f18c0fa65f1833a6c/chrome/browser/ui/toolbar/media_router_contextual_menu_unittest.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64cbe66322b277223ff15b529ae787f544e6013c

commit 64cbe66322b277223ff15b529ae787f544e6013c
Author: Colin Blundell <blundell@chromium.org>
Date: Thu Oct 18 10:16:51 2018

Port GaiaInfoUpdateService unittest to use IdentityTestEnvironment

This is possible now that we have infrastructure that glues an
IdentityTestEnvironment instance to a Profile, and it enables removing
the test's knowledge of SigninManager.

Bug:  896180 
Change-Id: I074c0d2886561b264612ce2d34c5ca41b81de3be
Reviewed-on: https://chromium-review.googlesource.com/c/1286810
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600715}
[modify] https://crrev.com/64cbe66322b277223ff15b529ae787f544e6013c/chrome/browser/profiles/gaia_info_update_service_unittest.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Oct 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6196b626c6c17d4dc5d00c4d1b0b595967f3d400

commit 6196b626c6c17d4dc5d00c4d1b0b595967f3d400
Author: Colin Blundell <blundell@chromium.org>
Date: Thu Oct 18 15:28:23 2018

Port EasyUnlockService unittest to IdentityTestEnvironment

This is possible now that there is //chrome-level infrastructure for
glueing an IdentityTestEnvironment instance to a Profile.

Note that this particular test is somewhat unusual in that it builds
multiple Profiles but does not require IdentityTestEnvironment to
interact with those Profiles beyond doing initial configuration. For
simplicity, we use local variables for the IdentityTestEnvironment
associated with each Profile; otherwise, we would need to introduce
distinct instance variables for the two.

This CL also modifies the relevant
IdentityTestEnvironmentProfileAdaptor APIs to return the
TestingProfiles that they create as TestingProfiles; this avoids a
cast that this test would otherwise require and clarifies the APIs.

TBR=droger@chcromium.org

Bug:  896180 
Change-Id: Icba8cdc67c1667949636a96078f05e15fd79649c
Reviewed-on: https://chromium-review.googlesource.com/c/1283038
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600767}
[modify] https://crrev.com/6196b626c6c17d4dc5d00c4d1b0b595967f3d400/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_unittest_chromeos.cc
[modify] https://crrev.com/6196b626c6c17d4dc5d00c4d1b0b595967f3d400/chrome/browser/signin/identity_test_environment_profile_adaptor.cc
[modify] https://crrev.com/6196b626c6c17d4dc5d00c4d1b0b595967f3d400/chrome/browser/signin/identity_test_environment_profile_adaptor.h

Project Member

Comment 6 by bugdroid1@chromium.org, Oct 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9cec94065ff28b18a4c31743ac55f7e687a8bd77

commit 9cec94065ff28b18a4c31743ac55f7e687a8bd77
Author: Colin Blundell <blundell@chromium.org>
Date: Thu Oct 18 16:06:27 2018

Remove stale identity_test_utils.h include

Forgot to do this (again) in the CL converting away from these utils.

TBR=droger@chromium.org

Bug:  896180 
Change-Id: I3845417f5884d5adfb048d919931a6e021221e6f
Reviewed-on: https://chromium-review.googlesource.com/c/1288869
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600781}
[modify] https://crrev.com/9cec94065ff28b18a4c31743ac55f7e687a8bd77/chrome/browser/profiles/gaia_info_update_service_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment