New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 896178 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 23
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

performance_test_suite failing on chromium.win/Win7 Tests (dbg)(1)

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Oct 17

Issue description

From the logs:

No benchmark named "dummy_benchmark.histogram_benchmark_1".



Do you mean any of those benchmarks below?

Available benchmarks are:

  dummy_benchmark.noisy_benchmark_1  A noisy benchmark with mean=50 & std=20.

  dummy_benchmark.stable_benchmark_1 A low noise benchmark with mean=100 & std=1.

Pass --browser to list benchmarks for another browser.




Suspecting https://chromium-review.googlesource.com/c/chromium/src/+/1282220
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d409d280361cb801137a9b856c4c1b6022422fec

commit d409d280361cb801137a9b856c4c1b6022422fec
Author: Christos Froussios <cfroussios@chromium.org>
Date: Wed Oct 17 09:37:00 2018

Revert "[Perf] Delete dummy_benchmark.histogram_benchmark_1"

This reverts commit b9f373852554ef8c6f5436a7ce25bff3dd323dc7.

Reason for revert: Suspected of breaking performance_test_suite on Win7 Tests (dbg)

Bug:  896178 

Original change's description:
> [Perf] Delete dummy_benchmark.histogram_benchmark_1
> 
> No longer needed.
> 
> Change-Id: I48e7073aba7861d7265337996c3ce6146d972f50
> Reviewed-on: https://chromium-review.googlesource.com/c/1282220
> Commit-Queue: Ethan Kuefner <eakuefner@chromium.org>
> Reviewed-by: Ned Nguyen <nednguyen@google.com>
> Cr-Commit-Position: refs/heads/master@{#600169}

TBR=eakuefner@chromium.org,nednguyen@google.com

Change-Id: I0358e9aaf36257b7a6f43d900361d75d04b95c21
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/1286457
Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600327}
[modify] https://crrev.com/d409d280361cb801137a9b856c4c1b6022422fec/tools/perf/benchmark.csv
[modify] https://crrev.com/d409d280361cb801137a9b856c4c1b6022422fec/tools/perf/benchmarks/dummy_benchmark.py
[modify] https://crrev.com/d409d280361cb801137a9b856c4c1b6022422fec/tools/perf/core/shard_maps/android-go-perf_map.json
[modify] https://crrev.com/d409d280361cb801137a9b856c4c1b6022422fec/tools/perf/core/shard_maps/android-nexus5x-perf_map.json
[modify] https://crrev.com/d409d280361cb801137a9b856c4c1b6022422fec/tools/perf/core/shard_maps/android_nexus5_perf_map.json
[modify] https://crrev.com/d409d280361cb801137a9b856c4c1b6022422fec/tools/perf/core/shard_maps/android_nexus5x_webview_perf_map.json
[modify] https://crrev.com/d409d280361cb801137a9b856c4c1b6022422fec/tools/perf/core/shard_maps/android_nexus6_webview_perf_map.json
[modify] https://crrev.com/d409d280361cb801137a9b856c4c1b6022422fec/tools/perf/core/shard_maps/linux-perf_map.json
[modify] https://crrev.com/d409d280361cb801137a9b856c4c1b6022422fec/tools/perf/core/shard_maps/mac-10_12_laptop_low_end-perf_map.json
[modify] https://crrev.com/d409d280361cb801137a9b856c4c1b6022422fec/tools/perf/core/shard_maps/mac-10_13_laptop_high_end-perf_map.json
[modify] https://crrev.com/d409d280361cb801137a9b856c4c1b6022422fec/tools/perf/core/shard_maps/win-10-perf_map.json
[modify] https://crrev.com/d409d280361cb801137a9b856c4c1b6022422fec/tools/perf/core/shard_maps/win_7_nvidia_gpu_perf_map.json
[modify] https://crrev.com/d409d280361cb801137a9b856c4c1b6022422fec/tools/perf/core/shard_maps/win_7_perf_map.json
[modify] https://crrev.com/d409d280361cb801137a9b856c4c1b6022422fec/tools/perf/core/undocumented_benchmarks.py

Labels: -Sheriff-Chromium
Owner: eakuefner@chromium.org
Status: Assigned (was: Available)
The problem seems fixed.
Assigning to the author of the reverted CL.
Cc: nedngu...@google.com
Ned, can you help me figure out what step I'm missing when deleting the benchmark? I ran generate_perf_sharding and generate_perf_data for the CL before landing.

Alternately, can I just assign ownership to you as originally planned so that you can take on cleaning up the benchmark?
#4: can you assign ownership to Ben or Sean instead? 
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/77f7e421c1b05f8d8ce3c748dfb9843867f9e01f

commit 77f7e421c1b05f8d8ce3c748dfb9843867f9e01f
Author: Ned Nguyen <nednguyen@google.com>
Date: Thu Oct 18 22:01:20 2018

Remove dummy_benchmark.histogram_benchmark_1

Bug:896178
Change-Id: I3bfd2d4925d7dbb3e802d2e94566c23099c3357a

TBR=eakuefner@chromium.org

Change-Id: I3bfd2d4925d7dbb3e802d2e94566c23099c3357a
Reviewed-on: https://chromium-review.googlesource.com/c/1289669
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#600930}
[modify] https://crrev.com/77f7e421c1b05f8d8ce3c748dfb9843867f9e01f/tools/perf/benchmark.csv
[modify] https://crrev.com/77f7e421c1b05f8d8ce3c748dfb9843867f9e01f/tools/perf/benchmarks/dummy_benchmark.py
[modify] https://crrev.com/77f7e421c1b05f8d8ce3c748dfb9843867f9e01f/tools/perf/core/shard_maps/android-go-perf_map.json
[modify] https://crrev.com/77f7e421c1b05f8d8ce3c748dfb9843867f9e01f/tools/perf/core/shard_maps/android-nexus5x-perf_map.json
[modify] https://crrev.com/77f7e421c1b05f8d8ce3c748dfb9843867f9e01f/tools/perf/core/shard_maps/android_nexus5_perf_map.json
[modify] https://crrev.com/77f7e421c1b05f8d8ce3c748dfb9843867f9e01f/tools/perf/core/shard_maps/android_nexus5x_webview_perf_map.json
[modify] https://crrev.com/77f7e421c1b05f8d8ce3c748dfb9843867f9e01f/tools/perf/core/shard_maps/android_nexus6_webview_perf_map.json
[modify] https://crrev.com/77f7e421c1b05f8d8ce3c748dfb9843867f9e01f/tools/perf/core/shard_maps/linux-perf_map.json
[modify] https://crrev.com/77f7e421c1b05f8d8ce3c748dfb9843867f9e01f/tools/perf/core/shard_maps/mac-10_12_laptop_low_end-perf_map.json
[modify] https://crrev.com/77f7e421c1b05f8d8ce3c748dfb9843867f9e01f/tools/perf/core/shard_maps/mac-10_13_laptop_high_end-perf_map.json
[modify] https://crrev.com/77f7e421c1b05f8d8ce3c748dfb9843867f9e01f/tools/perf/core/shard_maps/smoke_test_benchmark_shard_map.json
[modify] https://crrev.com/77f7e421c1b05f8d8ce3c748dfb9843867f9e01f/tools/perf/core/shard_maps/win-10-perf_map.json
[modify] https://crrev.com/77f7e421c1b05f8d8ce3c748dfb9843867f9e01f/tools/perf/core/shard_maps/win_7_nvidia_gpu_perf_map.json
[modify] https://crrev.com/77f7e421c1b05f8d8ce3c748dfb9843867f9e01f/tools/perf/core/shard_maps/win_7_perf_map.json
[modify] https://crrev.com/77f7e421c1b05f8d8ce3c748dfb9843867f9e01f/tools/perf/core/undocumented_benchmarks.py

Status: Fixed (was: Assigned)
It appears that the reland has stuck, so I'm going to go ahead and close this. Thanks Ned for relanding.

Sign in to add a comment