New issue
Advanced search Search tips

Issue 896171 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 25
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

sizes failing on multiple builders

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Oct 17

Issue description

Components: Infra
The stdout of these tests isn't helpful to determine a culprit.

In fact, the output itself seems broken. The section summary is
sizes sizes
sizes
<div class="BuildResultInfo">
</div>

Taken from 
https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20Linux%20x64/36828

An infra issue?
Labels: Infra-Troopers
Cc: bpastene@chromium.org jbudorick@chromium.org mmoss@chromium.org
Components: -Infra Infra>Client>Chrome
Status: WontFix (was: Available)
This seems to have gone away, so marking as WontFix.

cc-ing a few people who might know if anything changed.
Status: Untriaged (was: WontFix)
Still happening: https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20Linux%20x64/
Cc: thakis@chromium.org
Owner: thakis@chromium.org
Status: Assigned (was: Untriaged)
thakis@, I see you landed changes to this recently in https://chromium.googlesource.com/chromium/src/+/d0a1b1a0ba18a5412148c24b69ce277ec72ed0f7. Is the the result of your changes? Or maybe you're fixing these problems?

If not, can you help triage? 
Cc: thomasanderson@chromium.org
Owner: martiniss@chromium.org
I'm not looking at any internal bots, and since the failures precede my changes they aren't caused by that.

I tried clicking around on those bots a bit but can't figure out how to see error stdout / stderr output -- without that, this is impossible to diagnose. So step 1 would be to figure out how to get this information out of logdog, which looks like an infra-shaped issue, so back to you for that.

(+thomasanderson since he touched sizes a while ago, but for now this looks independent of his change.)
Labels: -Sheriff-Chromium
Removing the sheriff label..
https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20Linux%20x64/36972's contains both https://crrev.com/a932158f926e1dd0752306d7869d04742c125307 and https://crrev.com/d0a1b1a0ba18a5412148c24b69ce277ec72ed0f7, which to me look suspicious. I don't know much about sizes though, so maybe I'm just wrong here. The other bot has been failing for much longer, which means the failures may not be related?

Looking into the stderr issue; it could be a part of the stdout log; I think that's how things usually are. I'll double check with people who know more though.
Ah, https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20Linux%20x64/36972 (the earliest red on linux) does have a change from me, true. I'd say the change is harmless, but it might be related. Looking forward to the actual error message :-)
https://cs.chromium.org/chromium/src/infra/scripts/legacy/scripts/slave/chromium/sizes.py?q=chromium/sizes.py&sq=package:chromium&dr&l=328 seems to indicate that something happened with static initializers. As far as I can read that code, it should be printing things, but it doesn't seem to be.

If si_count == 0, then it could hit that line, and add a failure, but not print anything in the branch on line 332. It turns out that the failures for the results collector are totally ignored in this build, because there's no --failure argument (https://cs.chromium.org/chromium/src/infra/scripts/legacy/scripts/slave/chromium/sizes.py?q=chromium/sizes.py&sq=package:chromium&dr&l=588 means it only outputs added failures if that argument is passed, and we don't pass that in builds). So maybe there's no missing stderr data? I dunno... :/
I think I'm going to add the '--failures' argument to the calls we make to sizes.py to help debug this.

The stderr situation is unclear; this is on buildbot, so it's a bit unclear exactly what's happening with the stderr stream. We can look a bit more into this; i'll ask some more infra folks.
Cc: hinoka@chromium.org
cc-ing hinoka, who might know more about the stderr/stdout situation.
Project Member

Comment 13 by bugdroid1@chromium.org, Oct 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e593b841f664eef3ebf669c6b0775f9c04f32e0c

commit e593b841f664eef3ebf669c6b0775f9c04f32e0c
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Tue Oct 23 19:30:42 2018

Correct nacl_helper SI count on Linux

This is to green up the Google Chrome Linux bot [1].

NaCl now has the same SIs as Chrome [2].  They are:
WelsThreadPool.cpp
atomicops_internals_x86.cc
debugallocation_shim.cc
iostream.cpp
spinlock.cc

[1] https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20Linux%20x64/36988
[2] https://logs.chromium.org/logs/chromium/bb/chromium.chrome/Google_Chrome_Linux_x64/36988/+/recipes/steps/sizes/0/stdout

BUG= 896171 
R=thakis

Change-Id: Ibcb553b9790b08e46e46b6eb343183f4de60b888
Reviewed-on: https://chromium-review.googlesource.com/c/1296049
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602054}
[modify] https://crrev.com/e593b841f664eef3ebf669c6b0775f9c04f32e0c/infra/scripts/legacy/scripts/slave/chromium/sizes.py

Status: Fixed (was: Assigned)
Project Member

Comment 15 by bugdroid1@chromium.org, Oct 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/81f36056b607642373bb26443870f10fd5a3f793

commit 81f36056b607642373bb26443870f10fd5a3f793
Author: Stephen Martinis <martiniss@chromium.org>
Date: Mon Oct 29 17:46:18 2018

sizes.py: Add --failures argument

This should hopefully help debug the linked bug.

Bug:  896171 
Change-Id: I6d43b8b9d1a52121f9f048af0a9d87dfb0271ae0
Reviewed-on: https://chromium-review.googlesource.com/c/1294909
Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>

[modify] https://crrev.com/81f36056b607642373bb26443870f10fd5a3f793/scripts/slave/recipes/cronet.expected/android_cronet_builder__dbg_.json
[modify] https://crrev.com/81f36056b607642373bb26443870f10fd5a3f793/scripts/slave/recipe_modules/chromium/tests/sizes.expected/basic.json
[modify] https://crrev.com/81f36056b607642373bb26443870f10fd5a3f793/scripts/slave/recipes/cronet.expected/android_cronet_x86_builder.json
[modify] https://crrev.com/81f36056b607642373bb26443870f10fd5a3f793/scripts/slave/recipe_modules/cronet/examples/full.expected/gn_test.json
[modify] https://crrev.com/81f36056b607642373bb26443870f10fd5a3f793/scripts/slave/recipes/cronet.expected/android_cronet_arm64_builder.json
[modify] https://crrev.com/81f36056b607642373bb26443870f10fd5a3f793/scripts/slave/recipes/cronet.expected/android_cronet_marshmallow_64bit_builder.json
[modify] https://crrev.com/81f36056b607642373bb26443870f10fd5a3f793/scripts/slave/recipe_modules/cronet/examples/full.expected/local_test.json
[modify] https://crrev.com/81f36056b607642373bb26443870f10fd5a3f793/scripts/slave/recipes/cronet.expected/local_test.json
[modify] https://crrev.com/81f36056b607642373bb26443870f10fd5a3f793/scripts/slave/recipe_modules/chromium_tests/tests/steps/sizes_step.expected/basic.json
[modify] https://crrev.com/81f36056b607642373bb26443870f10fd5a3f793/scripts/slave/README.recipes.md
[modify] https://crrev.com/81f36056b607642373bb26443870f10fd5a3f793/scripts/slave/recipes/cronet.expected/android_cronet_kitkat_builder.json
[modify] https://crrev.com/81f36056b607642373bb26443870f10fd5a3f793/scripts/slave/recipe_modules/chromium/tests/sizes.expected/platform.json
[modify] https://crrev.com/81f36056b607642373bb26443870f10fd5a3f793/scripts/slave/recipe_modules/chromium/api.py
[modify] https://crrev.com/81f36056b607642373bb26443870f10fd5a3f793/scripts/slave/recipes/cronet.expected/android_cronet_x86_builder__dbg_.json
[modify] https://crrev.com/81f36056b607642373bb26443870f10fd5a3f793/scripts/slave/recipes/cronet.expected/android_cronet_arm64_builder__dbg_.json
[modify] https://crrev.com/81f36056b607642373bb26443870f10fd5a3f793/scripts/slave/recipes/cronet.expected/android_cronet_lollipop_builder.json
[modify] https://crrev.com/81f36056b607642373bb26443870f10fd5a3f793/scripts/slave/recipe_modules/cronet/examples/full.expected/mb_test.json

Sign in to add a comment