New issue
Advanced search Search tips

Issue 896162 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 24
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 866708



Sign in to add a comment

MSE_ExternalClearKey/EncryptedMediaTest.RemoveTemporarySession/0 fails with Mojo changes

Project Member Reported by rockot@google.com, Oct 17

Issue description

This browser_tests test fails with this CL applied: https://chromium-review.googlesource.com/c/chromium/src/+/1145692

The only net change the CL makes is that Mojo bindings schedule a separate task for each received message, rather than dispatching messages in batch within a single task when possible. This does not alter any of the explicit guarantees made by Mojo bindings.

It looks like the failure is consistently with this check: https://cs.chromium.org/chromium/src/media/test/data/eme_remove_session_test.html?rcl=10bdfaa4154a1faafea4d48e09bf564e939fc531&l=101

but I haven't been able to make any sense of why that would happen.

jrummel@ or xhwang@ would you be able to help figure this out?
 
rockot: Good bug! Thanks!

jrummell: I think after update() resolves, we should still wait for keystatuseschange event to check the key statuses.
Status: Started (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/13a93254de05552d877bec14d5c0a757f983bafe

commit 13a93254de05552d877bec14d5c0a757f983bafe
Author: John Rummell <jrummell@chromium.org>
Date: Wed Oct 24 00:15:32 2018

Wait for 'keystatuseschange' events before checking them

The test needs to wait for the 'keystatuseschange' event to ensure
the key statuses have been updated properly.

BUG= 896162 
TEST=RemoveTemporarySession tests pass with the additional CL in the bug.

Change-Id: I066743332a575b384db478829cdf4b87cc54606d
Reviewed-on: https://chromium-review.googlesource.com/c/1287439
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602182}
[modify] https://crrev.com/13a93254de05552d877bec14d5c0a757f983bafe/media/test/data/eme_player_js/utils.js
[modify] https://crrev.com/13a93254de05552d877bec14d5c0a757f983bafe/media/test/data/eme_remove_session_test.html

Status: Fixed (was: Started)

Sign in to add a comment