New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 896160 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocked on:
issue 898200



Sign in to add a comment

Jumbo android compilation problems in explore_sites related to kFaviconsPerCategoryImage

Project Member Reported by brat...@opera.com, Oct 17

Issue description

A duplicate set of kFaviconsPerCategoryImage constants cause compilation problems in Android jumbo builds where the constants end up in the same translation unit.

A fix landed a bit late on master through https://chromium-review.googlesource.com/c/chromium/src/+/1275895 so the M71 branch was cut in the meantime and has the same problem. This is to track backporting to M71.

Requesting approval to backport to M71 so that embedders and others building Android builds with use_jumbo_build=true for much faster compilations won't get any compilation errors.


 
Project Member

Comment 1 by sheriffbot@chromium.org, Oct 18

Labels: -Merge-Request-71 Hotlist-Merge-Approved Merge-Approved-71
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Thanks, landed on the M71 branch through https://chromium-review.googlesource.com/c/chromium/src/+/1288569
Labels: -Merge-Approved-71
Blockedon: 898200

Sign in to add a comment