WithOutOfBlinkCors/ResourceDispatcherHostTest.DataSentBeforeDetach/0 breaks with Mojo changes |
|||
Issue descriptionThis test fails with this CL applied: https://chromium-review.googlesource.com/c/chromium/src/+/1145692 The only net change the CL makes is that Mojo bindings schedule a separate task for each received message, rather than dispatching messages in batch within a single task. This does not alter any of the explicit guarantees made by Mojo bindings. A brief inspection reveals that the TestURLLoaderClient receives an OnComplete message without first receiving OnStartLoadingResponseBody, resulting in a this expectation failing: EXPECT_TRUE(client.response_body().is_valid()); yhirano@ are you familiar enough with this code that you might be able to take a look at this? If not please reassign to me and I'll find a way to get this fixed.
,
Oct 23
Any updates on this toyoshim@?
,
Oct 24
Sorry. I'm now really slow for a business trip, and haven't noticed this issue was assigned to me. I'll try finding time tonight, but definitely this is a area yhirano@ has more expertise. Though he is also in a trip.
,
Oct 24
No problem. This is the last blocker, so I will also take a look today and update if I find anything.
,
Oct 25
Just to update, I was not able to find anything conclusive in the time I had available.
,
Oct 29
,
Oct 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c0d27f826f1ad350d7366a139c2cd497a83e5347 commit c0d27f826f1ad350d7366a139c2cd497a83e5347 Author: Yutaka Hirano <yhirano@chromium.org> Date: Wed Oct 31 04:59:27 2018 Fix ResourceDispatcherHostTest.DataSentBeforeDetach Wait until the response body arrives at the client side before cancelling the loader in order not to rely on a certain scheduling policy. Bug: 896159 Change-Id: Ifdacae1bd257ca12f57e64aed2fbffb5b5d1ab72 Reviewed-on: https://chromium-review.googlesource.com/c/1304173 Reviewed-by: Ken Rockot <rockot@google.com> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#604158} [modify] https://crrev.com/c0d27f826f1ad350d7366a139c2cd497a83e5347/content/browser/loader/resource_dispatcher_host_unittest.cc
,
Oct 31
|
|||
►
Sign in to add a comment |
|||
Comment 1 by yhirano@chromium.org
, Oct 17Components: Blink>SecurityFeature>CORS
Owner: toyoshim@chromium.org