Issue metadata
Sign in to add a comment
|
A page can't use the service worker API when opened via Files app |
||||||||||||||||||||||
Issue descriptionCan't open Google Drive files from Chrome OS Files app. You might need to enable Docs Offline Service Workers and try to open a Doc to see this. This was fixed in https://chromium-review.googlesource.com/c/chromium/src/+/861558 for the non-NetworkService, non-ServiceWorkerServicification path. When NetworkService is enabled, the bug still occurs. When ServiceWorkerServicification is enabled, but not NetworkService, the bug doesn't occur. Either way, ServiceWorkerRequestHandlerTest.InitializeForNavigation_ExternalFileScheme on a Chrome OS build fails with either NS or SWS on.
,
Oct 17
It might not have to do with service workers. The original bug was the "externalfile:" URL redirected to a Google Docs page. The page loaded and tried to register a service worker, and registration failed. However in this case the page itself totally doesn't open with a "Google Chrome OS can't open this page" error. It seems to occur before any redirect. Maybe the problem is just that NetworkService and externalfile URLs aren't working well? Resetting this to Untriaged.
,
Oct 17
There are two bugs. - When ServiceWorkerServicification is on (but NetworkService is off), you can navigate to the page but any Service Worker related API will fail with an exception. This was the original issue in the non-servicification path fixed by https://chromium-review.googlesource.com/c/chromium/src/+/861558. - When NetworkService is on, you cannot navigate to the page. I can fix the first issue by doing the same thing as the linked CL in the servicification path, but it doesn't fix the second issue.
,
Oct 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c2997950ca4bf61f062e4efef8909feadfe9d911 commit c2997950ca4bf61f062e4efef8909feadfe9d911 Author: Matt Falkenhagen <falken@chromium.org> Date: Wed Oct 17 10:08:40 2018 S13nServiceWorker: Make the provider host for externalfile scheme navigations. This fixes ServiceWorkerRequestHandlerTest.InitializeForNavigation_ExternalFileScheme when ServiceWorkerServicification or NetworkService is enabled. It's the same fix as the non-servicification path, done in r528590. Bug: 895187 , 896157 Change-Id: I8949c0bf002b329a01b1755913d16634dd80e7cd Reviewed-on: https://chromium-review.googlesource.com/c/1286021 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#600336} [modify] https://crrev.com/c2997950ca4bf61f062e4efef8909feadfe9d911/content/browser/service_worker/service_worker_request_handler.cc
,
Oct 23
This is a simple fix for a bug when ServiceWorkerServicification is on.
,
Oct 23
,
Oct 23
,
Oct 24
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4467858024735cdf0091ef6d12b835fdb305c00f commit 4467858024735cdf0091ef6d12b835fdb305c00f Author: Matt Falkenhagen <falken@chromium.org> Date: Wed Oct 24 15:34:23 2018 M71: S13nServiceWorker: Make the provider host for externalfile scheme navigations. This fixes ServiceWorkerRequestHandlerTest.InitializeForNavigation_ExternalFileScheme when ServiceWorkerServicification or NetworkService is enabled. It's the same fix as the non-servicification path, done in r528590. Bug: 895187 , 896157 Change-Id: I8949c0bf002b329a01b1755913d16634dd80e7cd Reviewed-on: https://chromium-review.googlesource.com/c/1286021 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#600336}(cherry picked from commit c2997950ca4bf61f062e4efef8909feadfe9d911) Reviewed-on: https://chromium-review.googlesource.com/c/1297147 Reviewed-by: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#291} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/4467858024735cdf0091ef6d12b835fdb305c00f/content/browser/service_worker/service_worker_request_handler.cc
,
Oct 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4467858024735cdf0091ef6d12b835fdb305c00f Commit: 4467858024735cdf0091ef6d12b835fdb305c00f Author: falken@chromium.org Commiter: falken@chromium.org Date: 2018-10-24 15:34:23 +0000 UTC M71: S13nServiceWorker: Make the provider host for externalfile scheme navigations. This fixes ServiceWorkerRequestHandlerTest.InitializeForNavigation_ExternalFileScheme when ServiceWorkerServicification or NetworkService is enabled. It's the same fix as the non-servicification path, done in r528590. Bug: 895187 , 896157 Change-Id: I8949c0bf002b329a01b1755913d16634dd80e7cd Reviewed-on: https://chromium-review.googlesource.com/c/1286021 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#600336}(cherry picked from commit c2997950ca4bf61f062e4efef8909feadfe9d911) Reviewed-on: https://chromium-review.googlesource.com/c/1297147 Reviewed-by: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#291} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Oct 24
The part of the bug about service worker API calls failing is fixed. To reduce noise I'll close this bug and open a new one for "Can't open Google Drive files from Files app" which is, I believe, far more serious.
,
Oct 26
Meant to change the summary in c#11 to reflect what was fixed.
,
Oct 29
The bug for "Can't open Google Drive files from Files app" is issue 898517 . |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by falken@chromium.org
, Oct 17