Reorganize third_party/webrtc_overrides |
||
Issue descriptionThe build configuration of //third_party/webrtc_overrides needs some work in order to lower the number of targets and make it sure it is easier to understand what it does. As of today, there are at least 2 build targets that should be merged (:init_webrtc and :webrtc). The desired end goal is to have only one ":webrtc_overrides" build target that will take care of everything and Chromium will just depend on it. I am opening this bug because I need to add 2 dependencies on a CL and I need to comment why I am doing that, while it should be implicit.
,
Oct 18
,
Oct 18
The following revision refers to this bug: https://webrtc.googlesource.com/src.git/+/6347bda432bdf503377b78051afa092be10fa3df commit 6347bda432bdf503377b78051afa092be10fa3df Author: Mirko Bonadei <mbonadei@webrtc.org> Date: Thu Oct 18 09:02:54 2018 Remove expat from generate_licenses.py. This library is not used by WebRTC anymore. Bug: chromium:896154 Change-Id: Ifc2f30b9425ef7ca3ff665cc03d11932316df71c Reviewed-on: https://webrtc-review.googlesource.com/c/106780 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25248} [modify] https://crrev.com/6347bda432bdf503377b78051afa092be10fa3df/tools_webrtc/libs/generate_licenses.py
,
Oct 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/83a9525bd0a6a0d732539f76ffb4972574dadea7 commit 83a9525bd0a6a0d732539f76ffb4972574dadea7 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Oct 18 17:15:02 2018 Roll src/third_party/webrtc 09beff2cfd84..78416b6e1851 (19 commits) https://webrtc.googlesource.com/src.git/+log/09beff2cfd84..78416b6e1851 git log 09beff2cfd84..78416b6e1851 --date=short --no-merges --format='%ad %ae %s' 2018-10-18 srte@webrtc.org Adds time to initial config in analyzer code. 2018-10-18 ilnik@webrtc.org Correctly slice MediaBitrateRecieved on content type in ReceiveStatisticsProxy 2018-10-18 srte@webrtc.org Adds field trial to AudioPriorityBitrateAllocationStrategy. 2018-10-18 peah@webrtc.org AEC3: Introduce partial adaptive filter resets at echo path changes 2018-10-18 peah@webrtc.org AEC3: Remove ERLE uncertainty code that has no effect 2018-10-18 kwiberg@webrtc.org Relieve perkj@ of some OWNER duties 2018-10-18 mbonadei@webrtc.org Remove expat from generate_licenses.py. 2018-10-18 tzik@chromium.org Add missing #include to absl/memory/memory.h 2018-10-18 mbonadei@webrtc.org Export symbols needed by the Chromium component build (part 4). 2018-10-18 kwiberg@webrtc.org rtc::ZeroOnFreeBuffer: Don't forget to zero memory we free in operator= 2018-10-18 titovartem@webrtc.org Fix: Argv may be corrupted after InitGoogleMock found any related flags 2018-10-18 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision c926d3bb2f..fc405b495a (600547:600654) 2018-10-17 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 8bef2e268b..c926d3bb2f (600433:600547) 2018-10-17 shampson@webrtc.org Adds support for "-" to a=ssrc msid lines. 2018-10-17 sukhanov@webrtc.org Reland "Reland "Propagate media transport to media channel."" 2018-10-17 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision c5242283d9..8bef2e268b (600305:600433) 2018-10-17 benwright@webrtc.org Adds new CryptoOption crypto_options.frame.require_frame_encryption. 2018-10-17 terelius@webrtc.org Track padding and header size in log event. 2018-10-17 srte@webrtc.org Adds AudioNetworkAdaptation support to Scenario tests. Created with: gclient setdep -r src/third_party/webrtc@78416b6e1851 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:none,chromium:895838,chromium:none,chromium:896154,chromium:752720,chromium:None,chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Id10b9aa1d178aca162bff37878204e3bf770c15a Reviewed-on: https://chromium-review.googlesource.com/c/1287895 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#600807} [modify] https://crrev.com/83a9525bd0a6a0d732539f76ffb4972574dadea7/DEPS
,
Oct 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/958b3aa6e3bd63785cb8e2d21c7e567942cb7983 commit 958b3aa6e3bd63785cb8e2d21c7e567942cb7983 Author: Mirko Bonadei <mbonadei@chromium.org> Date: Fri Oct 19 09:36:05 2018 Remove //third_party/webrtc_overrides:jingle_deps. First step in a series of small CLs to try to remove old dependencies and build targets that are not used anymore. Bug: 896154 Change-Id: Id3343e73b182c7468e9da2f68bdd7986b29e3987 Reviewed-on: https://chromium-review.googlesource.com/c/1286859 Reviewed-by: Henrik Grunell <grunell@chromium.org> Reviewed-by: Tommi <tommi@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#601092} [modify] https://crrev.com/958b3aa6e3bd63785cb8e2d21c7e567942cb7983/third_party/webrtc_overrides/BUILD.gn
,
Oct 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/05f1d46eb8550764fb6bd5088ff55dcf23fb1548 commit 05f1d46eb8550764fb6bd5088ff55dcf23fb1548 Author: Mirko Bonadei <mbonadei@chromium.org> Date: Wed Oct 24 20:43:08 2018 Stop exposing libjingle_xmpp:rtc_task_runner from webrtc_overrides. There is no reason to depend on libjingle_xmpp:rtc_task_runner from //third_party/webrtc_overrides. It was causing symbol visibility errors in the WebRTC component build and after looking more carefully into it, it seems that WebRTC doesn't need it, it is used in //jingle so this CL moves the dependency where it is needed. Bug: 896154 Change-Id: Icf24838a7b6220d5cabce1878b128caa3fe2fc9e Reviewed-on: https://chromium-review.googlesource.com/c/1297359 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Henrik Grunell <grunell@chromium.org> Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#602433} [modify] https://crrev.com/05f1d46eb8550764fb6bd5088ff55dcf23fb1548/jingle/BUILD.gn [modify] https://crrev.com/05f1d46eb8550764fb6bd5088ff55dcf23fb1548/third_party/webrtc_overrides/BUILD.gn
,
Oct 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ade3316d37970673cf294f297a8d88fdcd475f9a commit ade3316d37970673cf294f297a8d88fdcd475f9a Author: Mirko Bonadei <mbonadei@chromium.org> Date: Thu Oct 25 10:14:04 2018 Remove //third_party/webrtc_overrides:jingle_unexported_configs. This CL removes a configuration that was adding a bunch of -I flags to the compiler but they seem to be not needed anymore. Bug: 896154 Change-Id: Ie52203a97b877963ccede759c354036c3609ccba Reviewed-on: https://chromium-review.googlesource.com/c/1298717 Reviewed-by: Tommi <tommi@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#602662} [modify] https://crrev.com/ade3316d37970673cf294f297a8d88fdcd475f9a/third_party/libjingle_xmpp/BUILD.gn [modify] https://crrev.com/ade3316d37970673cf294f297a8d88fdcd475f9a/third_party/webrtc_overrides/BUILD.gn
,
Oct 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c70082d5b34ab29b4c52d7db4bc8e7ceef166b92 commit c70082d5b34ab29b4c52d7db4bc8e7ceef166b92 Author: Mirko Bonadei <mbonadei@chromium.org> Date: Thu Oct 25 13:08:19 2018 Remove /wd4005 from //third_party/webrtc_overrides. Bug: 896154 Change-Id: Ic2ea8bc5b27525ece532797e522a3994bbf7987e Reviewed-on: https://chromium-review.googlesource.com/c/1299134 Reviewed-by: Henrik Grunell <grunell@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#602681} [modify] https://crrev.com/c70082d5b34ab29b4c52d7db4bc8e7ceef166b92/third_party/webrtc_overrides/BUILD.gn
,
Oct 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3dbd8d06a7496709c014edd1dfb25fd80b8b2bb8 commit 3dbd8d06a7496709c014edd1dfb25fd80b8b2bb8 Author: Mirko Bonadei <mbonadei@chromium.org> Date: Thu Oct 25 13:36:31 2018 Remove //third_party/webrtc_overrides:jingle_public_configs. Bug: 896154 Change-Id: I94c083801e96efbb43f70e393665e2149d4b69b6 Reviewed-on: https://chromium-review.googlesource.com/c/1298996 Reviewed-by: Henrik Grunell <grunell@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#602687} [modify] https://crrev.com/3dbd8d06a7496709c014edd1dfb25fd80b8b2bb8/third_party/webrtc_overrides/BUILD.gn
,
Oct 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0573c1b53c8eb166fd67416ae422a63d316362b8 commit 0573c1b53c8eb166fd67416ae422a63d316362b8 Author: Mirko Bonadei <mbonadei@chromium.org> Date: Thu Oct 25 18:16:25 2018 Remove dependency from //third_party/webrtc_overrides to nacl_io. The dependency on //native_client_sdk/src/libraries/nacl_io seems unneeded. It has probably been added some time ago to propagate configurations. Bug: 896154 Change-Id: I7becde7e11dde3c966a07b17bdcc59902df7542c Reviewed-on: https://chromium-review.googlesource.com/c/1299141 Reviewed-by: Tommi <tommi@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#602794} [modify] https://crrev.com/0573c1b53c8eb166fd67416ae422a63d316362b8/third_party/webrtc_overrides/BUILD.gn
,
Jan 18
(4 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ee9c96f1fb4360e53ac7287ba9c30ea8cbb54394 commit ee9c96f1fb4360e53ac7287ba9c30ea8cbb54394 Author: Mirko Bonadei <mbonadei@chromium.org> Date: Fri Jan 18 09:10:00 2019 Do not implicitly depend on libsrtp and usrsctp. When //third_party/webrtc_overrides:init_webrtc is compiled for PNaCl, these dependencies break the build because some system headers are not available. This CL removes them because they are not direct dependencies and other built targets should not rely on these implicit and transitive dependencies to resolve symbols at link time. Bug: 896154 Change-Id: I1c40d90076e870c391f3c3b0a964cb9a3e827cf0 Reviewed-on: https://chromium-review.googlesource.com/c/1419338 Reviewed-by: Tommi <tommi@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#624045} [modify] https://crrev.com/ee9c96f1fb4360e53ac7287ba9c30ea8cbb54394/third_party/webrtc_overrides/BUILD.gn |
||
►
Sign in to add a comment |
||
Comment 1 by mbonadei@chromium.org
, Oct 17