New issue
Advanced search Search tips

Issue 896152 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 18
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 895894



Sign in to add a comment

EnsureComputedStyle called with dirty tree in RadioInputType key event handling

Project Member Reported by futhark@chromium.org, Oct 17

Issue description

EnsureComputedStyle() should only be called on style-clean trees. Introducing a DCHECK() in EnsureComputedStyle() triggers for various layout tests like this:

Check failed: !GetDocument().NeedsLayoutTreeUpdateForNode(*this).
#0 0x0000041a0f3f base::debug::StackTrace::StackTrace()
#1 0x0000040f910b logging::LogMessage::~LogMessage()#1
#2 0x00000622e996 blink::Element::EnsureComputedStyle()
#3 0x00000663870f blink::InputTypeView::ComputedTextDirection()
#4 0x00000664ed79 blink::RadioInputType::HandleKeydownEvent()
#5 0x000006608625 blink::HTMLInputElement::DefaultEventHandler()

 

Comment 1 Deleted

Owner: futhark@chromium.org
Status: Started (was: Available)
https://chromium-review.googlesource.com/c/chromium/src/+/1286139
Status: Fixed (was: Started)
Landed here instead:

https://chromium-review.googlesource.com/c/chromium/src/+/1286413

Sign in to add a comment