New issue
Advanced search Search tips

Issue 896144 link

Starred by 2 users
Status: Started
Owner:
manucornet@chromium.org
Cc:
ajha@chromium.org
yamaguchi@chromium.org
tetsui@chromium.org
sgabr...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Track of disabled toggle button is missing in ubertray

Project Member Reported by kebalaji@chromium.org, Oct 17 
Chrome Version: 72.0.3582.0/11166.0.0 dev-channel Kip,Daisy,Reks
OS: Chrome OS

What steps will reproduce the problem?
(1)Recover build>> Click on Ubertray, disable any toggle button and observe only knob is seen and slider is missing

Actual: Slider of disabled toggle button is missing in ubertray
Expected: No such issue should be seen

This is a Regression issue as same is working fine in M71

Attaching screencast for reference...
ActualSliderUT.mp4
4.5 MB View Download

Comment 1 by tetsui@chromium.org, Oct 17

Status: WontFix (was: Untriaged)
Couldn't reproduce on 72.0.3583.0

Comment 2 by kebalaji@chromium.org, Oct 23

Owner: tetsui@chromium.org
Status: Assigned (was: WontFix)
Able to reproduce the issue on 72.0.3587.0/11183.0.0 Kip, Daisy & Reks. Hence, re-opening the issue.

Comment 3 by tetsui@chromium.org, Oct 23

Labels: -Pri-1 -ReleaseBlock-Stable Pri-2
Owner: manucornet@chromium.org
manucornet@: Could you take a look? Thank you!

Unified System Tray will be handed over to MTV (owner: manucornet@)

Comment 4 by manucornet@chromium.org, Dec 12

Cc: sgabr...@chromium.org
Indeed, it seems like the slider color is the same as the overall background color, so the slider can't be seen. @Sébastien what color should that be? My apologies if that's already in a spec somewhere :-)

Comment 5 by sgabr...@chromium.org, Dec 13 

Sorry I forgot to spec the new toggle button for the darker theming of the ubetray.
The "track" of the toggle (called slider here) should be #F1F3F4 32%. The "Knob" should be #F1F3F4 100%. See preview
toggle preview.png
4.9 KB View Download

Comment 6 by manucornet@chromium.org, Dec 13

Summary: Track of disabled toggle button is missing in ubertray (was: Regression: Slider of disabled toggle button is missing in ubertray)

Comment 7 by manucornet@chromium.org, Dec 13

Status: Started (was: Assigned)

Comment 8 by manucornet@chromium.org, Dec 16 

For the sake of discussion on the CL, here are a few examples of how this toggle is used "in the wild" :-)
2018-12-16-124803_958x598_scrot.png
50.1 KB View Download
2018-12-16-124823_958x598_scrot.png
58.1 KB View Download
2018-12-16-124918_958x598_scrot.png
63.1 KB View Download
2018-12-16-125456_958x598_scrot.png
71.7 KB View Download

Comment 9 by sgabr...@chromium.org, Dec 17 

Wait, you show 2 images of settings, which is WebUI. I believe the implementation of toggles is different from System menu correct(Web vs. native)?

Because if we use the same implementation, the "off" state won't be visible if we change it as specced here, as this change is meant to match the dark UI of the system menu.
►

Sign in to add a comment