audio_AudioBasicExternalMicrophone.quality failure |
|||||||
Issue description
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/9e6bb65583bf0646e33df70425beb4ff1d3c4708 commit 9e6bb65583bf0646e33df70425beb4ff1d3c4708 Author: Yu-Hsuan Hsu <yuhsuan@google.com> Date: Tue Oct 23 20:01:52 2018 [autotest] audio_AudioBasicExternalMicrophone: Change test frequency We use 0.0015 ms as block size when checking quality. When the rate is 48000, it is equal to 48000 * 0.0015 = 72 frames. However, the length of one wave in 440 HZ stream is 48000 / 440 = 109 frames. It is too large to test. So we change the higher frequency file, 48000 / 1330 = 36 frames is enough. BUG=chromium:896141 TEST=run audio_AudioBasicExternalMicrophone.quality test. Change-Id: I451ab0a992b80d57bfa015576c26ca88f4b000ce Reviewed-on: https://chromium-review.googlesource.com/1292695 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Yu-Hsuan Hsu <yuhsuan@chromium.org> Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org> [modify] https://crrev.com/9e6bb65583bf0646e33df70425beb4ff1d3c4708/server/site_tests/audio_AudioBasicExternalMicrophone/audio_AudioBasicExternalMicrophone.py
,
Oct 24
Request merge to M71. It is the fix for audio autotest. It won't break anything. Thanks.
,
Oct 24
Hello @kalin, I am curious why we only schedule this test suite(chameleon_audio_nightly) on tot-1 but not tot. Thanks.
,
Oct 25
Approving merge to M71 Chrome OS.
,
Oct 25
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/b01de89c25b27971eaa6c138621f82da8080958c commit b01de89c25b27971eaa6c138621f82da8080958c Author: Yu-Hsuan Hsu <yuhsuan@google.com> Date: Thu Oct 25 02:13:29 2018 [autotest] audio_AudioBasicExternalMicrophone: Change test frequency We use 0.0015 ms as block size when checking quality. When the rate is 48000, it is equal to 48000 * 0.0015 = 72 frames. However, the length of one wave in 440 HZ stream is 48000 / 440 = 109 frames. It is too large to test. So we change the higher frequency file, 48000 / 1330 = 36 frames is enough. BUG=chromium:896141 TEST=run audio_AudioBasicExternalMicrophone.quality test. Change-Id: I451ab0a992b80d57bfa015576c26ca88f4b000ce Previous-Reviewed-on: https://chromium-review.googlesource.com/1292695 (cherry picked from commit 625e9f8613c8dd1249915e614af02aa4374c8f24) Reviewed-on: https://chromium-review.googlesource.com/c/1297876 Reviewed-by: Yu-Hsuan Hsu <yuhsuan@chromium.org> Commit-Queue: Yu-Hsuan Hsu <yuhsuan@chromium.org> Tested-by: Yu-Hsuan Hsu <yuhsuan@chromium.org> [modify] https://crrev.com/b01de89c25b27971eaa6c138621f82da8080958c/server/site_tests/audio_AudioBasicExternalMicrophone/audio_AudioBasicExternalMicrophone.py
,
Oct 29
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 1
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by yuhsuan@chromium.org
, Oct 19