bluetooth: Finish implementing BluetoothSystem::SetPowered. |
|
Issue descriptionBluetoothSystem::SetPowered currently forwards the calls to BlueZ but that's not enough for Chrome OS. There are two missing features: 1. BluetoothSystem should remember what state the user was in, so that the next time the user sign in the state remains the same. 2. SetPowered() should support concurrent calls.
,
Oct 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9d6307e37a8a781c97e1ed8c2f4764bab78e0f82 commit 9d6307e37a8a781c97e1ed8c2f4764bab78e0f82 Author: Giovanni Ortuño Urquidi <ortuno@chromium.org> Date: Mon Oct 22 22:10:16 2018 bluetooth: Small test improvement Changes two tests to reset the received events before continuing the test. This makes it more consistent with other tests and makes it clearer how the state changes at each point in the tests. Bug: 896113 Change-Id: I06b963fa0cab0f0a1bf8bb72145711636c77ddae Reviewed-on: https://chromium-review.googlesource.com/c/1292663 Reviewed-by: Ovidio Henriquez <odejesush@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#601747} [modify] https://crrev.com/9d6307e37a8a781c97e1ed8c2f4764bab78e0f82/services/device/bluetooth/bluetooth_system_unittest.cc
,
Oct 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d11d38fcf6b927dbd5223f57671e7d64b2b1e1a5 commit d11d38fcf6b927dbd5223f57671e7d64b2b1e1a5 Author: Giovanni Ortuño Urquidi <ortuno@chromium.org> Date: Tue Oct 30 00:21:39 2018 bluetooth: Add test for the adapter being removed during SetPowered Changes TestBluetoothAdapterClient::Properties to save Set callbacks if there is no next response set. Just like in real devices, these callbacks are run after the adapter gets removed. Also adds a test to make sure that when the adapter gets removed during a SetPowered call the state is correctly updated and there are no extra State Changed events. Bug: 896113 Change-Id: Iecc55cc2a8f4b2ff4d93fcacfd5e1a64095b2b7d Reviewed-on: https://chromium-review.googlesource.com/c/1304033 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by: Ovidio Henriquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#603700} [modify] https://crrev.com/d11d38fcf6b927dbd5223f57671e7d64b2b1e1a5/services/device/bluetooth/BUILD.gn [modify] https://crrev.com/d11d38fcf6b927dbd5223f57671e7d64b2b1e1a5/services/device/bluetooth/bluetooth_system_unittest.cc |
|
►
Sign in to add a comment |
|
Comment 1 by bugdroid1@chromium.org
, Oct 22