Collapsed recipe steps just rolled out on Fuchsia, which is nice.
Would it be possible to autoexpand the failed step(s) though? For example on a failed build, it'd be nice to have the thing that contains the failure open to save an extra click.
scott, do you have a link to a concrete build with a failed nested step?
as a workaround, i believe "Non-Green" option should do it (still an extra click though)
IMHO this would be fairly simple to implement in HTML templates, and I'd be happy to do that. IIUC correctly what we want is to have all steps collapsed, but non-green expanded. Rather than changing the Collapsed mode, I'd prefer to add a new mode called Default for this. Otherwise, it might be slightly confusing to users since "collapsed" seems to imply everything should be collapsed.
Ryan, Nodir, please let me what behavior you'd like me to implement and assign the bug to me.
As for defaults, I like "Expanded", "Default", "Non-green only", as suggested in #3 and #4.
Of course, there's another issue that the OP pointed out, which is that the checkboxes are subtle and it's easy to miss them. It's possible they need to be more prominent.
One idea might be to add the number of items next to each of the options. Eg.
Expanded (35) | Default (20) | Non-green only (2)
CL: https://crrev.com/c/1288630. This changes Collapsed to Default.
I am not sure if counters will help to make the option visible. Perhaps a one-time popup highlighting the Show selector? OTH, popups are already so annoying on the Web. I'd hate to be one implementing yet another one.
CL changing Collapsed to Default has landed pending deployment. I'll send an email to chromium-dev@ after it is deployed and explain the purpose of the Show selector. Hopefully, this will be enough and I'll be able to mark this issue as resolved.
Owner: serg...@chromium.org Status: Started (was: Available)
Oh. sorry, last comment was intended for another bug. This one actually had correct status. The last remaining AI on this bug is to send PSA, which I plan to do tomorrow.
Comment 1 by no...@chromium.org
, Oct 17