New issue
Advanced search Search tips

Issue 896107 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Autoexpand collapsed recipe steps on failure

Project Member Reported by scottmg@google.com, Oct 17

Issue description

Collapsed recipe steps just rolled out on Fuchsia, which is nice.

Would it be possible to autoexpand the failed step(s) though? For example on a failed build, it'd be nice to have the thing that contains the failure open to save an extra click.
 
Cc: serg...@chromium.org
+sergiyb who implemented this, in case sergiy still has cycles. Otherwise hinoka might be a better owner
scott, do you have a link to a concrete build with a failed nested step?

as a workaround, i believe "Non-Green" option should do it (still an extra click though)
IMHO this would be fairly simple to implement in HTML templates, and I'd be happy to do that. IIUC correctly what we want is to have all steps collapsed, but non-green expanded. Rather than changing the Collapsed mode, I'd prefer to add a new mode called Default for this. Otherwise, it might be slightly confusing to users since "collapsed" seems to imply everything should be collapsed.

Ryan, Nodir, please let me what behavior you'd like me to implement and assign the bug to me.
I think with 4 modes, Collapsed would end up unused.
I doubt users will miss everything-collapsed mode if they have green-collapsed mode
Sorry, should have included an example: https://ci.chromium.org/p/fuchsia/builders/luci.fuchsia.try/sdk-garnet-x64-mac/b8932484575402101344 where there's 3 drill-down clicks before getting to the error log.

TBH, I'd never noticed those checkboxes there! Setting to "Expanded" is probably fine too (that seems to be sticky?)
To focus on the errors only you can also try out 'Non-Green' option. The setting is sticky.
As for defaults, I like "Expanded", "Default", "Non-green only", as suggested in #3 and #4.

Of course, there's another issue that the OP pointed out, which is that the checkboxes are subtle and it's easy to miss them.  It's possible they need to be more prominent.

One idea might be to add the number of items next to each of the options.  Eg.
Expanded (35) | Default (20) | Non-green only (2)
Owner: serg...@chromium.org
Status: Started (was: Untriaged)
CL: https://crrev.com/c/1288630. This changes Collapsed to Default.

I am not sure if counters will help to make the option visible. Perhaps a one-time popup highlighting the Show selector? OTH, popups are already so annoying on the Web. I'd hate to be one implementing yet another one.
P.S. I could also email chromium-dev@ to announce nested steps as well as highlighting the new Show selector. WDYT?
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 19

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/18b75972df3e1d4eba158935b4e9ef1f781c5281

commit 18b75972df3e1d4eba158935b4e9ef1f781c5281
Author: Sergiy Byelozyorov <sergiyb@chromium.org>
Date: Fri Oct 19 11:49:41 2018

Change Collapsed mode to Default that only collapses succeeded steps

R=hinoka@google.com

Bug:  896107 
Change-Id: I21f126fe1cd3760684068bde6dcd890ebd74cfe9
Reviewed-on: https://chromium-review.googlesource.com/c/1288630
Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/18b75972df3e1d4eba158935b4e9ef1f781c5281/milo/buildsource/buildbot/expectations/CrWinGoma.30608.build.json
[modify] https://crrev.com/18b75972df3e1d4eba158935b4e9ef1f781c5281/milo/buildsource/buildbot/expectations/chromium_presubmit.426944.build.json
[modify] https://crrev.com/18b75972df3e1d4eba158935b4e9ef1f781c5281/milo/buildsource/buildbot/expectations/gerritCL.1234.build.json
[modify] https://crrev.com/18b75972df3e1d4eba158935b4e9ef1f781c5281/milo/buildsource/buildbot/expectations/newline.1234.build.json
[modify] https://crrev.com/18b75972df3e1d4eba158935b4e9ef1f781c5281/milo/buildsource/buildbot/expectations/win_chromium_rel_ng.246309.build.json
[modify] https://crrev.com/18b75972df3e1d4eba158935b4e9ef1f781c5281/milo/buildsource/swarming/expectations/build-canceled.json
[modify] https://crrev.com/18b75972df3e1d4eba158935b4e9ef1f781c5281/milo/buildsource/swarming/expectations/build-exception.json
[modify] https://crrev.com/18b75972df3e1d4eba158935b4e9ef1f781c5281/milo/buildsource/swarming/expectations/build-expired.json
[modify] https://crrev.com/18b75972df3e1d4eba158935b4e9ef1f781c5281/milo/buildsource/swarming/expectations/build-finished-logdog-expired-stream.json
[modify] https://crrev.com/18b75972df3e1d4eba158935b4e9ef1f781c5281/milo/buildsource/swarming/expectations/build-gerrit.json
[modify] https://crrev.com/18b75972df3e1d4eba158935b4e9ef1f781c5281/milo/buildsource/swarming/expectations/build-internal.json
[modify] https://crrev.com/18b75972df3e1d4eba158935b4e9ef1f781c5281/milo/buildsource/swarming/expectations/build-link.json
[modify] https://crrev.com/18b75972df3e1d4eba158935b4e9ef1f781c5281/milo/buildsource/swarming/expectations/build-nested.json
[modify] https://crrev.com/18b75972df3e1d4eba158935b4e9ef1f781c5281/milo/buildsource/swarming/expectations/build-patch-failure.json
[modify] https://crrev.com/18b75972df3e1d4eba158935b4e9ef1f781c5281/milo/buildsource/swarming/expectations/build-pending-logdog.json
[modify] https://crrev.com/18b75972df3e1d4eba158935b4e9ef1f781c5281/milo/buildsource/swarming/expectations/build-pending.json
[modify] https://crrev.com/18b75972df3e1d4eba158935b4e9ef1f781c5281/milo/buildsource/swarming/expectations/build-running-logdog-no-annotation-stream.json
[modify] https://crrev.com/18b75972df3e1d4eba158935b4e9ef1f781c5281/milo/buildsource/swarming/expectations/build-running-logdog.json
[modify] https://crrev.com/18b75972df3e1d4eba158935b4e9ef1f781c5281/milo/buildsource/swarming/expectations/build-running.json
[modify] https://crrev.com/18b75972df3e1d4eba158935b4e9ef1f781c5281/milo/buildsource/swarming/expectations/build-timeout.json
[modify] https://crrev.com/18b75972df3e1d4eba158935b4e9ef1f781c5281/milo/buildsource/swarming/expectations/build-unicode.json
[modify] https://crrev.com/18b75972df3e1d4eba158935b4e9ef1f781c5281/milo/buildsource/swarming/testdata/html_data.go
[modify] https://crrev.com/18b75972df3e1d4eba158935b4e9ef1f781c5281/milo/frontend/appengine/static/common/js/build.js
[modify] https://crrev.com/18b75972df3e1d4eba158935b4e9ef1f781c5281/milo/frontend/appengine/templates/pages/build.html
[modify] https://crrev.com/18b75972df3e1d4eba158935b4e9ef1f781c5281/milo/frontend/expectations/buildbot.build-Debug_page-_CrWinGoma_30608.html
[modify] https://crrev.com/18b75972df3e1d4eba158935b4e9ef1f781c5281/milo/frontend/expectations/buildbot.build-Debug_page-_chromium_presubmit_426944.html
[modify] https://crrev.com/18b75972df3e1d4eba158935b4e9ef1f781c5281/milo/frontend/expectations/buildbot.build-Debug_page-_gerritCL_1234.html
[modify] https://crrev.com/18b75972df3e1d4eba158935b4e9ef1f781c5281/milo/frontend/expectations/buildbot.build-Debug_page-_newline_1234.html
[modify] https://crrev.com/18b75972df3e1d4eba158935b4e9ef1f781c5281/milo/frontend/expectations/buildbot.build-Debug_page-_win_chromium_rel_ng_246309.html
[modify] https://crrev.com/18b75972df3e1d4eba158935b4e9ef1f781c5281/milo/frontend/expectations/swarming.build-build-canceled.html
[modify] https://crrev.com/18b75972df3e1d4eba158935b4e9ef1f781c5281/milo/frontend/expectations/swarming.build-build-exception.html
[modify] https://crrev.com/18b75972df3e1d4eba158935b4e9ef1f781c5281/milo/frontend/expectations/swarming.build-build-finished-logdog-expired-stream.html
[modify] https://crrev.com/18b75972df3e1d4eba158935b4e9ef1f781c5281/milo/frontend/expectations/swarming.build-build-gerrit.html
[modify] https://crrev.com/18b75972df3e1d4eba158935b4e9ef1f781c5281/milo/frontend/expectations/swarming.build-build-internal.html
[modify] https://crrev.com/18b75972df3e1d4eba158935b4e9ef1f781c5281/milo/frontend/expectations/swarming.build-build-link.html
[modify] https://crrev.com/18b75972df3e1d4eba158935b4e9ef1f781c5281/milo/frontend/expectations/swarming.build-build-nested.html
[modify] https://crrev.com/18b75972df3e1d4eba158935b4e9ef1f781c5281/milo/frontend/expectations/swarming.build-build-patch-failure.html
[modify] https://crrev.com/18b75972df3e1d4eba158935b4e9ef1f781c5281/milo/frontend/expectations/swarming.build-build-running-logdog-no-annotation-stream.html
[modify] https://crrev.com/18b75972df3e1d4eba158935b4e9ef1f781c5281/milo/frontend/expectations/swarming.build-build-running-logdog.html
[modify] https://crrev.com/18b75972df3e1d4eba158935b4e9ef1f781c5281/milo/frontend/expectations/swarming.build-build-running.html
[modify] https://crrev.com/18b75972df3e1d4eba158935b4e9ef1f781c5281/milo/frontend/expectations/swarming.build-build-timeout.html
[modify] https://crrev.com/18b75972df3e1d4eba158935b4e9ef1f781c5281/milo/frontend/expectations/swarming.build-build-unicode.html
[modify] https://crrev.com/18b75972df3e1d4eba158935b4e9ef1f781c5281/milo/frontend/routes_test.go
[modify] https://crrev.com/18b75972df3e1d4eba158935b4e9ef1f781c5281/milo/frontend/ui/build.go
[modify] https://crrev.com/18b75972df3e1d4eba158935b4e9ef1f781c5281/milo/frontend/view_build.go

CL changing Collapsed to Default has landed pending deployment. I'll send an email to chromium-dev@ after it is deployed and explain the purpose of the Show selector. Hopefully, this will be enough and I'll be able to mark this issue as resolved.
Owner: ----
Status: Available (was: Started)
Given it's low priority, I do not plan on working on this any time soon. Marking bug as available.
Owner: serg...@chromium.org
Status: Started (was: Available)
Oh. sorry, last comment was intended for another bug. This one actually had correct status. The last remaining AI on this bug is to send PSA, which I plan to do tomorrow.
Status: Fixed (was: Started)
Emails sent to v8-dev@googlegroups.com and infra-announce@chromium.org.

Sign in to add a comment