New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 896091 link

Starred by 1 user
Status: Started
Owner:
hsuregan@chromium.org
Cc:
█ jlklein@chromium.org
hsuregan@chromium.org
nohle@chromium.org
khorimoto@chromium.org
█ jordynass@chromium.org
hansberry@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Migrate setup flow from SystemWebDialog to WebDialog

Project Member Reported by hansberry@chromium.org, Oct 17 
As per discussions on crbug.com/888711, the Chrome UI team is probably going to be changing the behavior of SystemWebDialog (our setup flow is a SystemWebDialog) such that it does not maximize to fullscreen in tablet mode (this is the opposite of the current behavior). We need to migrate our flow to just a WebDialog so that we have the flexibility to maximize our dialog in tablet mode. The migration should be trivial.

The fix for crbug.com/888711 is aimed for M72, so I've set the milestone for this bug to M72 as well.

Comment 1 by hansberry@chromium.org, Nov 29

Labels: -M-72 M-73
There was no movement on crbug.com/888711 in M72. This can be punted to M73 (and even then, only needs to be addressed if crbug.com/888711 is moved on).

Comment 2 by hsuregan@chromium.org, Jan 3

Owner: hsuregan@chromium.org
Status: Started (was: Available)

Comment 3 by hansberry@google.com, Jan 4

Labels: -Pri-1 Pri-3
Discussed offline -- I don't see this as super high priority, because even though crbug.com/888711 was addressed, our dialog still works properly. I originally anticipated that our dialog would be broken but that doesn't seem to be the case (unless I'm unaware of a newfound breakage).
►

Sign in to add a comment