New issue
Advanced search Search tips

Issue 896089 link

Starred by 1 user
Status: Fixed
Owner:
anthonyvd@chromium.org
Closed: Oct 30
Cc:
yyushkina@chromium.org
benmason@chromium.org
anthonyvd@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Add Shadows to scrolled explicit language ask list

Project Member Reported by bshealy@chromium.org, Oct 17 
Clank

The header should scroll with the rest of the list instead of stay fixed in the viewport

Comment 1 by yyushkina@chromium.org, Oct 17

Components: UI>Browser>Language
Labels: OS-Android
Owner: anthonyvd@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by anthonyvd@chromium.org, Oct 26 

Here are some screenshots of the shadows as of https://chromium-review.googlesource.com/c/chromium/src/+/1301875
top_shadow.png
49.4 KB View Download
bottom_shadow.png
52.1 KB View Download
both_shadows.png
51.4 KB View Download
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6694d3fcdcb74e8b618284ecbe78c9f33f905fcf

commit 6694d3fcdcb74e8b618284ecbe78c9f33f905fcf
Author: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Date: Sun Oct 28 18:36:23 2018

Add shadows when explicit language ask list is scrollable

Bug:  896089 
Change-Id: Ifbf356ab0cb0e7fa222db7e9440adef927246e3a
Reviewed-on: https://chromium-review.googlesource.com/c/1301875
Reviewed-by: Becky Zhou <huayinz@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603386}
[add] https://crrev.com/6694d3fcdcb74e8b618284ecbe78c9f33f905fcf/chrome/android/java/res/layout/language_ask_prompt_content.xml
[modify] https://crrev.com/6694d3fcdcb74e8b618284ecbe78c9f33f905fcf/chrome/android/java/src/org/chromium/chrome/browser/language/LanguageAskPrompt.java

Comment 4 by anthonyvd@chromium.org, Oct 29

Labels: Merge-Request-71

Comment 5 by anthonyvd@chromium.org, Oct 29

Labels: -Pri-3 Pri-1
Project Member

Comment 6 by sheriffbot@chromium.org, Oct 29

Labels: -Merge-Request-71 Hotlist-Merge-Review Merge-Review-71
This bug requires manual review: M71 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by benmason@chromium.org, Oct 30

Labels: -Merge-Review-71 Merge-Approved-71
Approved for merge to 71, branch 3578.

Comment 8 by benmason@chromium.org, Oct 30

Cc: benmason@chromium.org
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 30

Labels: -merge-approved-71 merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/24e0173c2624d32da539c49c8370a95a39ce9b2e

commit 24e0173c2624d32da539c49c8370a95a39ce9b2e
Author: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Date: Tue Oct 30 14:01:09 2018

Add shadows when explicit language ask list is scrollable

Bug:  896089 
Change-Id: Ifbf356ab0cb0e7fa222db7e9440adef927246e3a
Reviewed-on: https://chromium-review.googlesource.com/c/1301875
Reviewed-by: Becky Zhou <huayinz@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#603386}(cherry picked from commit 6694d3fcdcb74e8b618284ecbe78c9f33f905fcf)
Reviewed-on: https://chromium-review.googlesource.com/c/1307576
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#389}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[add] https://crrev.com/24e0173c2624d32da539c49c8370a95a39ce9b2e/chrome/android/java/res/layout/language_ask_prompt_content.xml
[modify] https://crrev.com/24e0173c2624d32da539c49c8370a95a39ce9b2e/chrome/android/java/src/org/chromium/chrome/browser/language/LanguageAskPrompt.java

Comment 10 by anthonyvd@chromium.org, Oct 30

Status: Fixed (was: Assigned)

Comment 11 by anthonyvd@chromium.org, Oct 30

Status: Started (was: Fixed)
Project Member

Comment 12 by cr-audit...@appspot.gserviceaccount.com, Oct 30

Labels: Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/24e0173c2624d32da539c49c8370a95a39ce9b2e

Commit: 24e0173c2624d32da539c49c8370a95a39ce9b2e
Author: anthonyvd@chromium.org
Commiter: anthonyvd@chromium.org
Date: 2018-10-30 14:01:09 +0000 UTC

Add shadows when explicit language ask list is scrollable

Bug:  896089 
Change-Id: Ifbf356ab0cb0e7fa222db7e9440adef927246e3a
Reviewed-on: https://chromium-review.googlesource.com/c/1301875
Reviewed-by: Becky Zhou <huayinz@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#603386}(cherry picked from commit 6694d3fcdcb74e8b618284ecbe78c9f33f905fcf)
Reviewed-on: https://chromium-review.googlesource.com/c/1307576
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#389}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}

Comment 13 by anthonyvd@chromium.org, Oct 30

Status: Fixed (was: Started)
Summary: Add Shadows to scrolled explicit language ask list (was: Scroll header off screen on explicit language ask UI)
Closing this one and tracking scrolling header in crbug.com/899243
►

Sign in to add a comment