New issue
Advanced search Search tips

Issue 896080 link

Starred by 1 user
Status: Fixed
Owner:
mukai@chromium.org
Closed: Oct 24
Cc:
mustash-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

WindowActivityWatcherTest is failing with SingleProcessMash

Project Member Reported by mukai@chromium.org, Oct 17 
WindowActivityWatcherTest is failing with --enable-features=SingleProcessMash.

It seems that Mash creates an additional metric, and tab_ukm_test_helper recognizes this as an error.

The new metric appears through hiding the WindowTreeHost:

#2 0x00000d20f9d4 ukm::TestUkmRecorder::AddEntry()
#3 0x7f71471cea0e ukm::DelegatingUkmRecorder::Delegate::AddEntry()
#4 0x7f71471ce915 ukm::DelegatingUkmRecorder::AddEntry()
#5 0x7f71471dd665 ukm::internal::UkmEntryBuilderBase::Record()
#6 0x00000bd117eb (anonymous namespace)::LogWindowMetricsUkmEntry()
#7 0x00000bd11e9e WindowActivityWatcher::BrowserWatcher::MaybeLogWindowMetricsUkmEntry()
#8 0x00000bd11587 WindowActivityWatcher::OnBrowserNoLongerActive()
#9 0x00000bc8028d BrowserList::NotifyBrowserNoLongerActive()
#10 0x00000c27f3c7 BrowserView::OnWidgetActivationChanged()
#11 0x7f71513997c3 views::Widget::OnNativeWidgetActivationChanged()
#12 0x7f71513d3914 views::DesktopNativeWidgetAura::HandleActivationChanged()
#13 0x7f7139745848 views::DesktopWindowTreeHostMus::OnActiveFocusClientChanged()
#14 0x7f7143ee0fe3 aura::FocusSynchronizer::SetActiveFocusClient()
#15 0x7f7139745bd3 views::DesktopWindowTreeHostMus::HideImpl()
#16 0x7f7143f83d1d aura::WindowTreeHost::Hide()
#17 0x7f71513d7a60 views::DesktopNativeWidgetAura::Hide()
#18 0x7f715139829d views::Widget::Hide()
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7566f8d3267fd417992de8c43da0af10bf34115f

commit 7566f8d3267fd417992de8c43da0af10bf34115f
Author: Jun Mukai <mukai@chromium.org>
Date: Wed Oct 24 03:38:11 2018

Change the timing of Hide and losing Focus in Mash

This CL changes the order of HideImpl and giving up the focus
within DesktopWindowTreeHostMus. As is written in the comment,
this is because some code like WindowActivityWatcher assumes
the window is already invisible when the window gives up the
focus.

BUG= 896080 
TEST=interactive_ui_tests --enable-features=SingleProcessMash

Change-Id: I48a45bbea87c2e66d9827d2f7776b038edfca512
Reviewed-on: https://chromium-review.googlesource.com/c/1297401
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602245}
[modify] https://crrev.com/7566f8d3267fd417992de8c43da0af10bf34115f/testing/buildbot/filters/chromeos.single_process_mash.interactive_ui_tests.filter
[modify] https://crrev.com/7566f8d3267fd417992de8c43da0af10bf34115f/ui/views/mus/desktop_window_tree_host_mus.cc

Comment 2 by mukai@chromium.org, Oct 24

Status: Fixed (was: Assigned)
►

Sign in to add a comment