New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 896057 link

Starred by 1 user
Status: Fixed
Owner:
azeemarshad@chromium.org
Closed: Nov 13
Cc:
azeemarshad@chromium.org
█ elizabethchiu@chromium.org
█ jlklein@chromium.org
shibasheikh@chromium.org
nohle@chromium.org
jessejames@chromium.org
khorimoto@chromium.org
█ jordynass@chromium.org
█ jhawkins@chromium.org
hansberry@chromium.org
█ shihuis@chromium.org
█ jonmann@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug


Participants' hotlists:
Better-Together-Launch-Blockers


Sign in to add a comment

"Remember this computer" does not always default to true on prod

Project Member Reported by jlklein@chromium.org, Oct 16 
It seems that when using the prod Messages endpoint, the timing works out such that the "Remember this computer" does not always default to true as expected. It does work often, but it's pretty easy to reproduce a failure.

We may need to rethink a bit of how we default this bit to true... It may warrant just setting a cookie in the messages domain to indicate the state of better together on the chromebook:

Basically, we should follow the logic of when the app is installed by AndroidSmsAppInstallingStatusObserver, but also set the cookie to false when the feature is disabled for one reason or another. I can try to start looking at this a bit tomorrow.

Comment 1 by jlklein@chromium.org, Oct 16

Status: Assigned (was: Available)

Comment 2 by jlklein@chromium.org, Oct 16

Cc: azeemarshad@chromium.org jonmann@chromium.org shihuis@chromium.org

Comment 3 by azeemarshad@chromium.org, Oct 30

Owner: azeemarshad@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a34aedfa81ccc128d16a34600f0003ae9f3a1a6

commit 5a34aedfa81ccc128d16a34600f0003ae9f3a1a6
Author: Azeem Arshad <azeemarshad@chromium.org>
Date: Thu Nov 08 03:32:13 2018

[Multidevice] Add default-to-persist cookie logic in PWA installation

This CL adds logic to set a default-to-persist cookie that will force
the messages PWA to default to persisting the pairing. Also fixes issue
with PWA installing unexpectedly when disabling features.

Bug:  896057 , 900799 
Change-Id: I77354ecbbccf69e1b9a97e1bcff82bccaeeb44b1
Reviewed-on: https://chromium-review.googlesource.com/c/1312305
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Commit-Queue: Azeem Arshad <azeemarshad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606319}
[modify] https://crrev.com/5a34aedfa81ccc128d16a34600f0003ae9f3a1a6/chrome/browser/chromeos/multidevice_setup/android_sms_app_helper_delegate_impl.cc
[modify] https://crrev.com/5a34aedfa81ccc128d16a34600f0003ae9f3a1a6/chrome/browser/chromeos/multidevice_setup/android_sms_app_helper_delegate_impl.h
[modify] https://crrev.com/5a34aedfa81ccc128d16a34600f0003ae9f3a1a6/chrome/browser/chromeos/multidevice_setup/android_sms_app_helper_delegate_impl_unittest.cc
[modify] https://crrev.com/5a34aedfa81ccc128d16a34600f0003ae9f3a1a6/chrome/browser/ui/webui/settings/chromeos/multidevice_handler.cc
[modify] https://crrev.com/5a34aedfa81ccc128d16a34600f0003ae9f3a1a6/chromeos/services/multidevice_setup/android_sms_app_installing_status_observer.cc
[modify] https://crrev.com/5a34aedfa81ccc128d16a34600f0003ae9f3a1a6/chromeos/services/multidevice_setup/android_sms_app_installing_status_observer.h
[modify] https://crrev.com/5a34aedfa81ccc128d16a34600f0003ae9f3a1a6/chromeos/services/multidevice_setup/android_sms_app_installing_status_observer_unittest.cc
[modify] https://crrev.com/5a34aedfa81ccc128d16a34600f0003ae9f3a1a6/chromeos/services/multidevice_setup/feature_state_manager_impl.cc
[modify] https://crrev.com/5a34aedfa81ccc128d16a34600f0003ae9f3a1a6/chromeos/services/multidevice_setup/feature_state_manager_impl_unittest.cc
[modify] https://crrev.com/5a34aedfa81ccc128d16a34600f0003ae9f3a1a6/chromeos/services/multidevice_setup/public/cpp/android_sms_app_helper_delegate.h
[modify] https://crrev.com/5a34aedfa81ccc128d16a34600f0003ae9f3a1a6/chromeos/services/multidevice_setup/public/cpp/fake_android_sms_app_helper_delegate.cc
[modify] https://crrev.com/5a34aedfa81ccc128d16a34600f0003ae9f3a1a6/chromeos/services/multidevice_setup/public/cpp/fake_android_sms_app_helper_delegate.h

Comment 5 by azeemarshad@chromium.org, Nov 13

Status: Fixed (was: Started)
►

Sign in to add a comment