Smart Lock signin attempts signin on every click |
||||||
Issue descriptionSee b/117343194. EasyUnlockService retries an auth attempt every time the user photo is clicked, messing up the first attempt. This breaks Smart Lock signin.
,
Oct 17
,
Oct 18
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 18
,
Oct 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/566fe5230cd0cbaef31ff92573ea439aded41055 commit 566fe5230cd0cbaef31ff92573ea439aded41055 Author: Kyle Horimoto <khorimoto@google.com> Date: Thu Oct 18 00:45:46 2018 Smart Lock: Do not start multiple auth attempts. EasyUnlockService previously re-instantiated an EasyUnlockAuthAttempt every time the user profile picture was tapped or clicked. This was unnecessary, and caused situations where the account's cryptohome could not be decrypted. TBR=hansberry@chromium.org (cherry picked from commit faf0b7f8bab4d4b321646a98d32186db9d7a5479) Bug: 896045 Change-Id: I959ed3209caeb8d83519c8300d863a6288984740 Reviewed-on: https://chromium-review.googlesource.com/c/1285118 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#600190} Reviewed-on: https://chromium-review.googlesource.com/c/1287629 Cr-Commit-Position: refs/branch-heads/3578@{#111} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/566fe5230cd0cbaef31ff92573ea439aded41055/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service.cc
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/566fe5230cd0cbaef31ff92573ea439aded41055 Commit: 566fe5230cd0cbaef31ff92573ea439aded41055 Author: khorimoto@google.com Commiter: khorimoto@chromium.org Date: 2018-10-18 00:45:46 +0000 UTC Smart Lock: Do not start multiple auth attempts. EasyUnlockService previously re-instantiated an EasyUnlockAuthAttempt every time the user profile picture was tapped or clicked. This was unnecessary, and caused situations where the account's cryptohome could not be decrypted. TBR=hansberry@chromium.org (cherry picked from commit faf0b7f8bab4d4b321646a98d32186db9d7a5479) Bug: 896045 Change-Id: I959ed3209caeb8d83519c8300d863a6288984740 Reviewed-on: https://chromium-review.googlesource.com/c/1285118 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#600190} Reviewed-on: https://chromium-review.googlesource.com/c/1287629 Cr-Commit-Position: refs/branch-heads/3578@{#111} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Oct 16