ESP: category title should be at top, and 'more' should navigate to the 4th category |
||||||
Issue descriptionSee title
,
Oct 17
,
Oct 17
Pls apply appropriate OSs label.
,
Oct 17
,
Oct 18
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/72b780488ad614f98cd9da170b28d69b8ec0cdd7 commit 72b780488ad614f98cd9da170b28d69b8ec0cdd7 Author: Cathy Li <chili@chromium.org> Date: Fri Oct 19 19:46:43 2018 [Explore sites:] Fix scrolling so 'more' would bring up the 4th category, and scrolling would bring category to top. Bug: 896044 Change-Id: Ifd000b49a08fb82ceae1f95a2552355143558f3c Reviewed-on: https://chromium-review.googlesource.com/c/1285119 Reviewed-by: Justin DeWitt <dewittj@chromium.org> Commit-Queue: Cathy Li <chili@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#600198}(cherry picked from commit c00e16ab15a6375c0a639875d8f8caa8e8d5d688) Reviewed-on: https://chromium-review.googlesource.com/c/1292449 Reviewed-by: Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#165} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/72b780488ad614f98cd9da170b28d69b8ec0cdd7/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/CategoryCardAdapter.java [modify] https://crrev.com/72b780488ad614f98cd9da170b28d69b8ec0cdd7/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesPage.java
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/72b780488ad614f98cd9da170b28d69b8ec0cdd7 Commit: 72b780488ad614f98cd9da170b28d69b8ec0cdd7 Author: chili@chromium.org Commiter: chili@chromium.org Date: 2018-10-19 19:46:43 +0000 UTC [Explore sites:] Fix scrolling so 'more' would bring up the 4th category, and scrolling would bring category to top. Bug: 896044 Change-Id: Ifd000b49a08fb82ceae1f95a2552355143558f3c Reviewed-on: https://chromium-review.googlesource.com/c/1285119 Reviewed-by: Justin DeWitt <dewittj@chromium.org> Commit-Queue: Cathy Li <chili@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#600198}(cherry picked from commit c00e16ab15a6375c0a639875d8f8caa8e8d5d688) Reviewed-on: https://chromium-review.googlesource.com/c/1292449 Reviewed-by: Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#165} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Oct 17