New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 896044 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit 21 days ago
Closed: Oct 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

ESP: category title should be at top, and 'more' should navigate to the 4th category

Project Member Reported by chili@chromium.org, Oct 16

Issue description

See title
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c00e16ab15a6375c0a639875d8f8caa8e8d5d688

commit c00e16ab15a6375c0a639875d8f8caa8e8d5d688
Author: Cathy Li <chili@chromium.org>
Date: Tue Oct 16 23:59:51 2018

[Explore sites:] Fix scrolling so 'more' would bring up the 4th category, and scrolling would bring category to top.

Bug:  896044 
Change-Id: Ifd000b49a08fb82ceae1f95a2552355143558f3c
Reviewed-on: https://chromium-review.googlesource.com/c/1285119
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Commit-Queue: Cathy Li <chili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600198}
[modify] https://crrev.com/c00e16ab15a6375c0a639875d8f8caa8e8d5d688/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/CategoryCardAdapter.java
[modify] https://crrev.com/c00e16ab15a6375c0a639875d8f8caa8e8d5d688/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesPage.java

Labels: Merge-Request-71
Status: Fixed (was: Assigned)
Pls apply appropriate OSs label. 
Labels: OS-Android
Project Member

Comment 5 by sheriffbot@chromium.org, Oct 18

Labels: -Merge-Request-71 Hotlist-Merge-Approved Merge-Approved-71
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 19

Labels: -merge-approved-71 merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/72b780488ad614f98cd9da170b28d69b8ec0cdd7

commit 72b780488ad614f98cd9da170b28d69b8ec0cdd7
Author: Cathy Li <chili@chromium.org>
Date: Fri Oct 19 19:46:43 2018

[Explore sites:] Fix scrolling so 'more' would bring up the 4th category, and scrolling would bring category to top.

Bug:  896044 
Change-Id: Ifd000b49a08fb82ceae1f95a2552355143558f3c
Reviewed-on: https://chromium-review.googlesource.com/c/1285119
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Commit-Queue: Cathy Li <chili@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#600198}(cherry picked from commit c00e16ab15a6375c0a639875d8f8caa8e8d5d688)
Reviewed-on: https://chromium-review.googlesource.com/c/1292449
Reviewed-by: Cathy Li <chili@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#165}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/72b780488ad614f98cd9da170b28d69b8ec0cdd7/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/CategoryCardAdapter.java
[modify] https://crrev.com/72b780488ad614f98cd9da170b28d69b8ec0cdd7/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesPage.java

Labels: Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/72b780488ad614f98cd9da170b28d69b8ec0cdd7

Commit: 72b780488ad614f98cd9da170b28d69b8ec0cdd7
Author: chili@chromium.org
Commiter: chili@chromium.org
Date: 2018-10-19 19:46:43 +0000 UTC

[Explore sites:] Fix scrolling so 'more' would bring up the 4th category, and scrolling would bring category to top.

Bug:  896044 
Change-Id: Ifd000b49a08fb82ceae1f95a2552355143558f3c
Reviewed-on: https://chromium-review.googlesource.com/c/1285119
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Commit-Queue: Cathy Li <chili@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#600198}(cherry picked from commit c00e16ab15a6375c0a639875d8f8caa8e8d5d688)
Reviewed-on: https://chromium-review.googlesource.com/c/1292449
Reviewed-by: Cathy Li <chili@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#165}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}

Sign in to add a comment