FileWatcher::Watch called on UI thread in Cast ozone platform |
|||
Issue descriptionThis change(crrev.com/c/1243366) made this call blocking, causing a crash here, since this is run on a UI_TYPE thread: https://cs.chromium.org/chromium/src/ui/events/ozone/device/device_manager_manual.cc?rcl=37eac9aac4bc503d8e1073538228c1d2c3d82f97&l=61
,
Oct 17
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c46360849bf0106aa846b1ca4db2b0010f1d5f08 commit c46360849bf0106aa846b1ca4db2b0010f1d5f08 Author: Chris Findeisen <cfindeisen@chromium.org> Date: Tue Oct 23 16:23:37 2018 Watches DeviceManager files on non-UI thread FileWatcher::Watch function now blocks, making it unsuitable for the UI thread. It is now posted to task_runner with May_Block trait. Bug: 896043 Test: Tested on device. No crash. Change-Id: I03389927a5154f39131adb8b2e51c0b9902b699d Reviewed-on: https://chromium-review.googlesource.com/c/1285053 Reviewed-by: Michael Spang <spang@chromium.org> Reviewed-by: Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Chris Findeisen <cfindeisen@chromium.org> Cr-Commit-Position: refs/heads/master@{#601978} [modify] https://crrev.com/c46360849bf0106aa846b1ca4db2b0010f1d5f08/ui/events/ozone/device/device_manager_manual.cc [modify] https://crrev.com/c46360849bf0106aa846b1ca4db2b0010f1d5f08/ui/events/ozone/device/device_manager_manual.h
,
Oct 23
|
|||
►
Sign in to add a comment |
|||
Comment 1 by cfindeisen@google.com
, Oct 16