[Windows Host] 'Shared with' dialog can be to obtrusive for collaborative Me2Me sessions |
||||||
Issue descriptionWe've received feedback on the Disconnect window impl that the dialog being reshown in the middle of the screen is too obtrusive when there is a collaborative session going on (e.g. if Me2Me is used as a remote support mechanism rather than purely for remote access). We should consider alternatives for the dialog placement and use them for subsequent dialog reshows.
,
Oct 17
Requesting a merge for M71. This change is for Chrome Remote Desktop and does not affect the browser.
,
Oct 17
Approving merge to M71 branch 3578 based on comment #2. Please merge. Thank you.
,
Oct 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/00e6df29c0775aab2f4659d9ff1db09ecd1e26ee commit 00e6df29c0775aab2f4659d9ff1db09ecd1e26ee Author: Joe Downing <joedow@chromium.org> Date: Wed Oct 17 04:03:47 2018 Allow disconnect window to be moved after local user input Per feedback reports we have received, the disconnect window positioning logic is frustrating for users who are providing remote support via Me2Me. This CL updates the logic so that we only place the dialog in the center of the screen until we see local user input. At that point we honor the placement of the dialog unless a monitor change event occurs. At that point we place it above the taskbar which is less obtrusive but still visible. Bug: 896026 Change-Id: Ib40155e8207aec5e3d653695718204194e34cd44 Reviewed-on: https://chromium-review.googlesource.com/c/1285450 Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#600226}(cherry picked from commit 18bb64123afeb4240cce687d04c361da0d7acbaa) Reviewed-on: https://chromium-review.googlesource.com/c/1286189 Reviewed-by: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#82} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/00e6df29c0775aab2f4659d9ff1db09ecd1e26ee/remoting/host/disconnect_window_win.cc
,
Oct 17
Thanks! Fix has been merged into M71 branch.
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/00e6df29c0775aab2f4659d9ff1db09ecd1e26ee Commit: 00e6df29c0775aab2f4659d9ff1db09ecd1e26ee Author: joedow@chromium.org Commiter: joedow@chromium.org Date: 2018-10-17 04:03:47 +0000 UTC Allow disconnect window to be moved after local user input Per feedback reports we have received, the disconnect window positioning logic is frustrating for users who are providing remote support via Me2Me. This CL updates the logic so that we only place the dialog in the center of the screen until we see local user input. At that point we honor the placement of the dialog unless a monitor change event occurs. At that point we place it above the taskbar which is less obtrusive but still visible. Bug: 896026 Change-Id: Ib40155e8207aec5e3d653695718204194e34cd44 Reviewed-on: https://chromium-review.googlesource.com/c/1285450 Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#600226}(cherry picked from commit 18bb64123afeb4240cce687d04c361da0d7acbaa) Reviewed-on: https://chromium-review.googlesource.com/c/1286189 Reviewed-by: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#82} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Oct 17