New issue
Advanced search Search tips

Issue 896020 link

Starred by 1 user
Status: Assigned
Owner:
asavery@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 655192



Sign in to add a comment

autotest: Check TrimIntegrity works with NVMe

Project Member Reported by gwendal@chromium.org, Oct 16 
TrimIntegrity should check if NVMe device are sending back 0's when reading trimmed area. Because we don't, we presently return TestNA.

[NVME 1.3 spec, section 6.7.1.1 Deallocate]

Today, TrimIntegrity is only able to tell to check for trimmed data on eMMC device (always trimmed) or SATA/SCSI device (hdparm).

Comment 1 by gwendal@chromium.org, Oct 18 

SSD does not support TRIM: dlfeat is 0.
If bit 1 was set, all trimmed region should read 0.

In consequence, the test should return TestNA, as we can not verify if the trimmed data as been really invalidated.

localhost ~ # nvme id-ns -n 1 /dev/nvme0n1
NVME Identify Namespace 1:
nsze    : 0x1dcf32b0
ncap    : 0x1dcf32b0
nuse    : 0
nsfeat  : 0
nlbaf   : 0
flbas   : 0
mc      : 0
dpc     : 0
dps     : 0
nmic    : 0
rescap  : 0
fpi     : 0
dlfeat  : 0
nawun   : 0
nawupf  : 0
nacwu   : 0
nabsn   : 0
nabo    : 0
nabspf  : 0
noiob   : 0
nvmcap  : 256060514304
nvmsetid: 0
endgid  : 0
nguid   : 00000000000000000000000000000000
eui64   : 0000000000000000
lbaf  0 : ms:0   lbads:9  rp:0 (in use)

Comment 2 by benhenry@google.com, Jan 11

Status: Assigned (was: Untriaged)
This issue has an owner, a component and a priority, but is still listed as untriaged or unconfirmed. By definition, this bug is triaged. Changing status to "assigned". Please reach out to me if you disagree with how I've done this.
►

Sign in to add a comment