New issue
Advanced search Search tips

Issue 896001 link

Starred by 1 user
Status: Fixed
Owner:
ryansturm@chromium.org
Closed: Nov 2
Cc:
bengr@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Move previews initialization out of profile_impl_io_data

Project Member Reported by ryansturm@chromium.org, Oct 16 
Because this file will go away, we should find a better place for initialization such as:
chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec445d80cf57ec4c0e28c3adc7a47d0da527ac7a

commit ec445d80cf57ec4c0e28c3adc7a47d0da527ac7a
Author: Ryan Sturm <ryansturm@chromium.org>
Date: Thu Nov 01 23:47:30 2018

Moving Previews Initialization call out of profile_impl_io_data

This CL moves the call to Init Previews into ProfileManager alongside
similar calls.

Bug:  896001 
Change-Id: If1bcecd73b9b5cab9f4ec101bd1e0e09867dba28
Reviewed-on: https://chromium-review.googlesource.com/c/1308990
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604757}
[modify] https://crrev.com/ec445d80cf57ec4c0e28c3adc7a47d0da527ac7a/chrome/browser/previews/previews_lite_page_decider.cc
[modify] https://crrev.com/ec445d80cf57ec4c0e28c3adc7a47d0da527ac7a/chrome/browser/profiles/profile_impl_io_data.cc
[modify] https://crrev.com/ec445d80cf57ec4c0e28c3adc7a47d0da527ac7a/chrome/browser/profiles/profile_manager.cc

Comment 2 by ryansturm@chromium.org, Nov 2

Status: Fixed (was: Assigned)
►

Sign in to add a comment