New issue
Advanced search Search tips

Issue 895992 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Oct 25
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 3
Type: Bug-Regression



Sign in to add a comment

No way to disable animation in Chrome settings

Reported by charles....@gmail.com, Oct 16

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.140 Safari/537.36 Edge/17.17134

Steps to reproduce the problem:
1. Set Windows 10 Ease of Access to Show animation off
2. In Chrome, set chrome://flags Smooth Scrolling to Disabled
3. In Chrome, choose Settings
4. Click Advanced

What is the expected behavior?
Advanced options appear without smooth scrolling

What went wrong?
Advance options appear and smooth-scroll onto the screen

Did this work before? N/A 

Chrome version: 64.0.3282.140  Channel: stable
OS Version: 10.0
Flash Version:
 
Corrected Chrome version: Version 69.0.3497.100 (Official Build) (64-bit)
Additional steps:

5. Click Content settings
6. Click location

What is the expected behavior?
Location options appear without smooth scrolling

What went wrong?
Location options appear and smooth-scroll horizontally onto the screen


Labels: Needs-Milestone
Components: -UI UI>Settings
Labels: -Type-Bug -Pri-2 RegressedIn-69 Triaged-ET Target-70 Target-71 Target-72 FoundIn-72 M-72 FoundIn-71 FoundIn-70 hasbisect OS-Linux Pri-1 Type-Bug-Regression
Owner: aee@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on Windows 10 and Ubuntu 14.04 using chrome reported version #69.0.3497.100 and latest canary #72.0.3582.0. Issue is specific to OS-win and OS-linux.

Bisect Information:
=====================
Good build: 69.0.3464.0
Bad Build : 69.0.3465.0

Change Log URL: 
https://chromium.googlesource.com/chromium/src/+log/96bff731f1338e6c8971dcc52198b81df63dc760..4096750b19cf2b629427ef2ee7938036697b7762

From the above change log suspecting below change
Change-Id: I83171f753c73b50e7d674e3f588cd5eb6e3f01d7
Reviewed-on: https://chromium-review.googlesource.com/1089643

aee@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thanks...!!
Status: Started (was: Assigned)
Labels: -Pri-1 Pri-3
Does chrome://settings need to obey the smooth-scrolling flag? I am not sure if we need to do anything here. 
The scrolling preference is based on a system property in Mac and chrome://flags for the other platforms. I have a fix for this that is in the process of getting merged.

https://chromium-review.googlesource.com/c/chromium/src/+/1298079

I'm okay with leaving that change since it's fairly small change.
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd7129e8933eaa26ce49a42d2c44473daf92d9ef

commit fd7129e8933eaa26ce49a42d2c44473daf92d9ef
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Thu Oct 25 02:06:43 2018

Settings WebUI: respect scroll animator setting when scrolling to advanced

Bug:  895992 
Change-Id: Idc93d8ef2c34399cb02661914d3ce82eb5bcf9a1
Reviewed-on: https://chromium-review.googlesource.com/c/1298079
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602577}
[modify] https://crrev.com/fd7129e8933eaa26ce49a42d2c44473daf92d9ef/chrome/browser/resources/settings/settings_ui/settings_ui.js
[modify] https://crrev.com/fd7129e8933eaa26ce49a42d2c44473daf92d9ef/chrome/browser/ui/webui/settings/md_settings_ui.cc

Status: Fixed (was: Started)
I  don't think that the command line smooth-scrolling flag is supposed to affect how we call [1]. If [1] still works with "smooth" behavior when the flag is both on/off then, that's another proof that smooth-scrolling is unrelated in this context.

Could probably dig more into how this flag is used within Chrome, but from a quick glance I think it has to do with whether scrolling happens in the compositor thread, or some other thread.

For example regardless of what we do in Settings, if scrollTo({behavior: 'smooth'}) works either way, who prevents third-party websites from using it when the flag is off?

Basically I think "smooth" in the flag's name, and "smooth" in [1] are two entirely separate things, they just happen to have the same name. I'd rather revert unless we are sure this is not the case.

[1] https://developer.mozilla.org/en-US/docs/Web/API/Window/scrollTo
Status: Assigned (was: Fixed)
Status: WontFix (was: Assigned)
Reverted.
Project Member

Comment 14 by bugdroid1@chromium.org, Oct 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0beb405851417f05c2495162e18f6b486c6a1145

commit 0beb405851417f05c2495162e18f6b486c6a1145
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Thu Oct 25 19:31:50 2018

Revert "Settings WebUI: respect scroll animator setting when scrolling to advanced"

This reverts commit fd7129e8933eaa26ce49a42d2c44473daf92d9ef.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Settings WebUI: respect scroll animator setting when scrolling to advanced
> 
> Bug:  895992 
> Change-Id: Idc93d8ef2c34399cb02661914d3ce82eb5bcf9a1
> Reviewed-on: https://chromium-review.googlesource.com/c/1298079
> Reviewed-by: Scott Chen <scottchen@chromium.org>
> Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#602577}

TBR=scottchen@chromium.org,aee@chromium.org

Change-Id: Ibbed77301a4627119e29c86806f25bb064540b9c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  895992 
Reviewed-on: https://chromium-review.googlesource.com/c/1299837
Reviewed-by: Esmael El-Moslimany <aee@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602828}
[modify] https://crrev.com/0beb405851417f05c2495162e18f6b486c6a1145/chrome/browser/resources/settings/settings_ui/settings_ui.js
[modify] https://crrev.com/0beb405851417f05c2495162e18f6b486c6a1145/chrome/browser/ui/webui/settings/md_settings_ui.cc

Sign in to add a comment