See flakiness dashboard here: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webgl2_conformance_tests&tests=WebglConformance_conformance2_textures_video_tex Failures occur across multiple builders, but the most consistent is Mac FYI Retina Release (AMD): https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac%20FYI%20Retina%20Release%20%28AMD%29?limit=200 Note that there are earlier flakes in webgl2_conformance_tests unrelated to this. The failures from this class of issues starts in build #8664. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac%20FYI%20Retina%20Release%20%28AMD%29/8664 It appears that we're getting the wrong pixels in this test. From looking at multiple regression ranges across the various failing bots, I suspect that this is due to: https://chromium-review.googlesource.com/c/1168155 sunnyps@, does it seem possible that your CL could be responsible? If so, can you investigate and/or revert? If not, let me know and I can mark this as failing for now while we investigate further.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/063f6d2a2897dcfb9afc3ee80cbb78ef87e9fe2a commit 063f6d2a2897dcfb9afc3ee80cbb78ef87e9fe2a Author: Sunny Sachanandani <sunnyps@chromium.org> Date: Tue Oct 16 20:23:07 2018 Revert "Remove WaitSyncTokenCHROMIUM command" This reverts commit c19106d109d4d36871c11bfb5a683d222583dd15. Reason for revert: Causing multiple mac gpu fyi failures crbug.com/895984 Original change's description: > Remove WaitSyncTokenCHROMIUM command > > After migrating InProcessCommandBuffer to use GPU scheduler, most tasks > are scheduled after their sync token dependencies are satisifed (see > crrev.com/c/1157874). > > The one exception was the WaitSyncToken IPC used by ReturnFrontBuffer > for pepper, which specifies a sync token, and waits while handling the > message. > > Change ReturnFrontBuffer to contain the sync token, and use it to > specify the dependency to the scheduler. > > Remove WaitSyncTokenCHROMIUM command, since sync token dependencies are > specified as task metadata in all cases. > > Make other cleanups such as removing unnecessary sync token tests, and > make sure the sync token code paths are not used where unsupported by > using NOTREACHED. > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: Ieee4f6e2427a59a4e0c4b3c983cb489741241272 > Bug: 778753 > Reviewed-on: https://chromium-review.googlesource.com/c/1168155 > Reviewed-by: Bo <boliu@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599849} TBR=dcheng@chromium.org,boliu@chromium.org,sunnyps@chromium.org,piman@chromium.org Change-Id: I87347c05dded27955410b08e40f37388a484d5f9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 778753 , 895984 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/1284394 Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#600102} [modify] https://crrev.com/063f6d2a2897dcfb9afc3ee80cbb78ef87e9fe2a/android_webview/browser/deferred_gpu_command_service.cc [modify] https://crrev.com/063f6d2a2897dcfb9afc3ee80cbb78ef87e9fe2a/android_webview/browser/deferred_gpu_command_service.h [modify] https://crrev.com/063f6d2a2897dcfb9afc3ee80cbb78ef87e9fe2a/gpu/BUILD.gn [modify] https://crrev.com/063f6d2a2897dcfb9afc3ee80cbb78ef87e9fe2a/gpu/command_buffer/build_gles2_cmd_buffer.py [modify] https://crrev.com/063f6d2a2897dcfb9afc3ee80cbb78ef87e9fe2a/gpu/command_buffer/build_raster_cmd_buffer.py [modify] https://crrev.com/063f6d2a2897dcfb9afc3ee80cbb78ef87e9fe2a/gpu/command_buffer/client/client_test_helper.h [modify] https://crrev.com/063f6d2a2897dcfb9afc3ee80cbb78ef87e9fe2a/gpu/command_buffer/client/gles2_cmd_helper_autogen.h [modify] https://crrev.com/063f6d2a2897dcfb9afc3ee80cbb78ef87e9fe2a/gpu/command_buffer/client/gles2_implementation.cc [modify] https://crrev.com/063f6d2a2897dcfb9afc3ee80cbb78ef87e9fe2a/gpu/command_buffer/client/gles2_implementation_unittest.cc [modify] https://crrev.com/063f6d2a2897dcfb9afc3ee80cbb78ef87e9fe2a/gpu/command_buffer/client/gpu_control.h [modify] https://crrev.com/063f6d2a2897dcfb9afc3ee80cbb78ef87e9fe2a/gpu/command_buffer/client/raster_cmd_helper_autogen.h [modify] https://crrev.com/063f6d2a2897dcfb9afc3ee80cbb78ef87e9fe2a/gpu/command_buffer/client/raster_implementation.cc [modify] https://crrev.com/063f6d2a2897dcfb9afc3ee80cbb78ef87e9fe2a/gpu/command_buffer/client/raster_implementation_unittest.cc [modify] https://crrev.com/063f6d2a2897dcfb9afc3ee80cbb78ef87e9fe2a/gpu/command_buffer/common/gles2_cmd_format_autogen.h [modify] https://crrev.com/063f6d2a2897dcfb9afc3ee80cbb78ef87e9fe2a/gpu/command_buffer/common/gles2_cmd_format_test_autogen.h [modify] https://crrev.com/063f6d2a2897dcfb9afc3ee80cbb78ef87e9fe2a/gpu/command_buffer/common/gles2_cmd_ids_autogen.h [modify] https://crrev.com/063f6d2a2897dcfb9afc3ee80cbb78ef87e9fe2a/gpu/command_buffer/common/raster_cmd_format_autogen.h [modify] https://crrev.com/063f6d2a2897dcfb9afc3ee80cbb78ef87e9fe2a/gpu/command_buffer/common/raster_cmd_format_test_autogen.h [modify] https://crrev.com/063f6d2a2897dcfb9afc3ee80cbb78ef87e9fe2a/gpu/command_buffer/common/raster_cmd_ids_autogen.h [modify] https://crrev.com/063f6d2a2897dcfb9afc3ee80cbb78ef87e9fe2a/gpu/command_buffer/service/command_buffer_direct.cc [modify] https://crrev.com/063f6d2a2897dcfb9afc3ee80cbb78ef87e9fe2a/gpu/command_buffer/service/command_buffer_direct.h [modify] https://crrev.com/063f6d2a2897dcfb9afc3ee80cbb78ef87e9fe2a/gpu/command_buffer/service/decoder_client.h [modify] https://crrev.com/063f6d2a2897dcfb9afc3ee80cbb78ef87e9fe2a/gpu/command_buffer/service/gles2_cmd_decoder.cc [modify] https://crrev.com/063f6d2a2897dcfb9afc3ee80cbb78ef87e9fe2a/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc [modify] https://crrev.com/063f6d2a2897dcfb9afc3ee80cbb78ef87e9fe2a/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_handlers.cc [modify] https://crrev.com/063f6d2a2897dcfb9afc3ee80cbb78ef87e9fe2a/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc [modify] https://crrev.com/063f6d2a2897dcfb9afc3ee80cbb78ef87e9fe2a/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h [modify] https://crrev.com/063f6d2a2897dcfb9afc3ee80cbb78ef87e9fe2a/gpu/command_buffer/service/memory_program_cache_unittest.cc [modify] https://crrev.com/063f6d2a2897dcfb9afc3ee80cbb78ef87e9fe2a/gpu/command_buffer/service/passthrough_program_cache_unittest.cc [modify] https://crrev.com/063f6d2a2897dcfb9afc3ee80cbb78ef87e9fe2a/gpu/command_buffer/service/program_manager_unittest.cc [modify] https://crrev.com/063f6d2a2897dcfb9afc3ee80cbb78ef87e9fe2a/gpu/command_buffer/service/raster_decoder.cc [modify] https://crrev.com/063f6d2a2897dcfb9afc3ee80cbb78ef87e9fe2a/gpu/command_buffer/service/raster_decoder_unittest.cc [modify] https://crrev.com/063f6d2a2897dcfb9afc3ee80cbb78ef87e9fe2a/gpu/command_buffer/service/raster_decoder_unittest_base.cc [modify] https://crrev.com/063f6d2a2897dcfb9afc3ee80cbb78ef87e9fe2a/gpu/command_buffer/service/raster_decoder_unittest_base.h [modify] https://crrev.com/063f6d2a2897dcfb9afc3ee80cbb78ef87e9fe2a/gpu/command_buffer/tests/decoder_perftest.cc [modify] https://crrev.com/063f6d2a2897dcfb9afc3ee80cbb78ef87e9fe2a/gpu/command_buffer/tests/fuzzer_main.cc [add] https://crrev.com/063f6d2a2897dcfb9afc3ee80cbb78ef87e9fe2a/gpu/command_buffer/tests/gl_fence_sync_unittest.cc [modify] https://crrev.com/063f6d2a2897dcfb9afc3ee80cbb78ef87e9fe2a/gpu/command_buffer/tests/gl_manager.cc [modify] https://crrev.com/063f6d2a2897dcfb9afc3ee80cbb78ef87e9fe2a/gpu/command_buffer/tests/gl_manager.h [modify] https://crrev.com/063f6d2a2897dcfb9afc3ee80cbb78ef87e9fe2a/gpu/gles2_conform_support/egl/context.cc [modify] https://crrev.com/063f6d2a2897dcfb9afc3ee80cbb78ef87e9fe2a/gpu/gles2_conform_support/egl/context.h [modify] https://crrev.com/063f6d2a2897dcfb9afc3ee80cbb78ef87e9fe2a/gpu/ipc/client/command_buffer_proxy_impl.cc [modify] https://crrev.com/063f6d2a2897dcfb9afc3ee80cbb78ef87e9fe2a/gpu/ipc/client/command_buffer_proxy_impl.h [modify] https://crrev.com/063f6d2a2897dcfb9afc3ee80cbb78ef87e9fe2a/gpu/ipc/client/gpu_channel_host.cc [modify] https://crrev.com/063f6d2a2897dcfb9afc3ee80cbb78ef87e9fe2a/gpu/ipc/command_buffer_task_executor.h [modify] https://crrev.com/063f6d2a2897dcfb9afc3ee80cbb78ef87e9fe2a/gpu/ipc/common/gpu_messages.h [modify] https://crrev.com/063f6d2a2897dcfb9afc3ee80cbb78ef87e9fe2a/gpu/ipc/gpu_in_process_thread_service.cc [modify] https://crrev.com/063f6d2a2897dcfb9afc3ee80cbb78ef87e9fe2a/gpu/ipc/gpu_in_process_thread_service.h [modify] https://crrev.com/063f6d2a2897dcfb9afc3ee80cbb78ef87e9fe2a/gpu/ipc/in_process_command_buffer.cc [modify] https://crrev.com/063f6d2a2897dcfb9afc3ee80cbb78ef87e9fe2a/gpu/ipc/in_process_command_buffer.h [modify] https://crrev.com/063f6d2a2897dcfb9afc3ee80cbb78ef87e9fe2a/gpu/ipc/service/command_buffer_stub.cc [modify] https://crrev.com/063f6d2a2897dcfb9afc3ee80cbb78ef87e9fe2a/gpu/ipc/service/command_buffer_stub.h [modify] https://crrev.com/063f6d2a2897dcfb9afc3ee80cbb78ef87e9fe2a/gpu/ipc/service/gles2_command_buffer_stub.cc [modify] https://crrev.com/063f6d2a2897dcfb9afc3ee80cbb78ef87e9fe2a/gpu/ipc/service/gles2_command_buffer_stub.h [modify] https://crrev.com/063f6d2a2897dcfb9afc3ee80cbb78ef87e9fe2a/gpu/ipc/service/gpu_channel.cc [modify] https://crrev.com/063f6d2a2897dcfb9afc3ee80cbb78ef87e9fe2a/gpu/ipc/service/raster_command_buffer_stub.cc [modify] https://crrev.com/063f6d2a2897dcfb9afc3ee80cbb78ef87e9fe2a/gpu/ipc/service/raster_command_buffer_stub.h [modify] https://crrev.com/063f6d2a2897dcfb9afc3ee80cbb78ef87e9fe2a/gpu/ipc/service/webgpu_command_buffer_stub.cc [modify] https://crrev.com/063f6d2a2897dcfb9afc3ee80cbb78ef87e9fe2a/gpu/ipc/service/webgpu_command_buffer_stub.h [modify] https://crrev.com/063f6d2a2897dcfb9afc3ee80cbb78ef87e9fe2a/ppapi/proxy/ppapi_command_buffer_proxy.cc [modify] https://crrev.com/063f6d2a2897dcfb9afc3ee80cbb78ef87e9fe2a/ppapi/proxy/ppapi_command_buffer_proxy.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/267428faed554af30b9f1193ce5447f0750621da commit 267428faed554af30b9f1193ce5447f0750621da Author: Sunny Sachanandani <sunnyps@chromium.org> Date: Tue Dec 11 02:21:05 2018 Reland "Remove WaitSyncTokenCHROMIUM command" This reverts commit c19106d109d4d36871c11bfb5a683d222583dd15. Original change's description: > Remove WaitSyncTokenCHROMIUM command > > After migrating InProcessCommandBuffer to use GPU scheduler, most tasks > are scheduled after their sync token dependencies are satisifed (see > crrev.com/c/1157874). > > The one exception was the WaitSyncToken IPC used by ReturnFrontBuffer > for pepper, which specifies a sync token, and waits while handling the > message. > > Change ReturnFrontBuffer to contain the sync token, and use it to > specify the dependency to the scheduler. > > Remove WaitSyncTokenCHROMIUM command, since sync token dependencies are > specified as task metadata in all cases. > > Make other cleanups such as removing unnecessary sync token tests, and > make sure the sync token code paths are not used where unsupported by > using NOTREACHED. > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: Ieee4f6e2427a59a4e0c4b3c983cb489741241272 > Bug: 778753 > Reviewed-on: https://chromium-review.googlesource.com/c/1168155 > Reviewed-by: Bo <boliu@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599849} Bug: 778753 , 895984 TBR=dcheng@chromium.org,boliu@chromium.org,piman@chromium.org Change-Id: I07943fdcbb131566718d51e78f134975ec53b62e Reviewed-on: https://chromium-review.googlesource.com/c/1361870 Reviewed-by: Bo <boliu@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#615387} [modify] https://crrev.com/267428faed554af30b9f1193ce5447f0750621da/android_webview/browser/deferred_gpu_command_service.cc [modify] https://crrev.com/267428faed554af30b9f1193ce5447f0750621da/android_webview/browser/deferred_gpu_command_service.h [modify] https://crrev.com/267428faed554af30b9f1193ce5447f0750621da/gpu/BUILD.gn [modify] https://crrev.com/267428faed554af30b9f1193ce5447f0750621da/gpu/command_buffer/build_gles2_cmd_buffer.py [modify] https://crrev.com/267428faed554af30b9f1193ce5447f0750621da/gpu/command_buffer/build_raster_cmd_buffer.py [modify] https://crrev.com/267428faed554af30b9f1193ce5447f0750621da/gpu/command_buffer/client/client_test_helper.h [modify] https://crrev.com/267428faed554af30b9f1193ce5447f0750621da/gpu/command_buffer/client/gles2_cmd_helper_autogen.h [modify] https://crrev.com/267428faed554af30b9f1193ce5447f0750621da/gpu/command_buffer/client/gles2_implementation.cc [modify] https://crrev.com/267428faed554af30b9f1193ce5447f0750621da/gpu/command_buffer/client/gles2_implementation_unittest.cc [modify] https://crrev.com/267428faed554af30b9f1193ce5447f0750621da/gpu/command_buffer/client/gpu_control.h [modify] https://crrev.com/267428faed554af30b9f1193ce5447f0750621da/gpu/command_buffer/client/raster_cmd_helper_autogen.h [modify] https://crrev.com/267428faed554af30b9f1193ce5447f0750621da/gpu/command_buffer/client/raster_implementation.cc [modify] https://crrev.com/267428faed554af30b9f1193ce5447f0750621da/gpu/command_buffer/client/raster_implementation_unittest.cc [modify] https://crrev.com/267428faed554af30b9f1193ce5447f0750621da/gpu/command_buffer/common/gles2_cmd_format_autogen.h [modify] https://crrev.com/267428faed554af30b9f1193ce5447f0750621da/gpu/command_buffer/common/gles2_cmd_format_test_autogen.h [modify] https://crrev.com/267428faed554af30b9f1193ce5447f0750621da/gpu/command_buffer/common/gles2_cmd_ids_autogen.h [modify] https://crrev.com/267428faed554af30b9f1193ce5447f0750621da/gpu/command_buffer/common/raster_cmd_format_autogen.h [modify] https://crrev.com/267428faed554af30b9f1193ce5447f0750621da/gpu/command_buffer/common/raster_cmd_format_test_autogen.h [modify] https://crrev.com/267428faed554af30b9f1193ce5447f0750621da/gpu/command_buffer/common/raster_cmd_ids_autogen.h [modify] https://crrev.com/267428faed554af30b9f1193ce5447f0750621da/gpu/command_buffer/service/command_buffer_direct.cc [modify] https://crrev.com/267428faed554af30b9f1193ce5447f0750621da/gpu/command_buffer/service/command_buffer_direct.h [modify] https://crrev.com/267428faed554af30b9f1193ce5447f0750621da/gpu/command_buffer/service/decoder_client.h [modify] https://crrev.com/267428faed554af30b9f1193ce5447f0750621da/gpu/command_buffer/service/gles2_cmd_decoder.cc [modify] https://crrev.com/267428faed554af30b9f1193ce5447f0750621da/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc [modify] https://crrev.com/267428faed554af30b9f1193ce5447f0750621da/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_handlers.cc [modify] https://crrev.com/267428faed554af30b9f1193ce5447f0750621da/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc [modify] https://crrev.com/267428faed554af30b9f1193ce5447f0750621da/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h [modify] https://crrev.com/267428faed554af30b9f1193ce5447f0750621da/gpu/command_buffer/service/memory_program_cache_unittest.cc [modify] https://crrev.com/267428faed554af30b9f1193ce5447f0750621da/gpu/command_buffer/service/passthrough_program_cache_unittest.cc [modify] https://crrev.com/267428faed554af30b9f1193ce5447f0750621da/gpu/command_buffer/service/program_manager_unittest.cc [modify] https://crrev.com/267428faed554af30b9f1193ce5447f0750621da/gpu/command_buffer/service/raster_cmd_validation_implementation_autogen.h [modify] https://crrev.com/267428faed554af30b9f1193ce5447f0750621da/gpu/command_buffer/service/raster_decoder.cc [modify] https://crrev.com/267428faed554af30b9f1193ce5447f0750621da/gpu/command_buffer/service/raster_decoder_unittest.cc [modify] https://crrev.com/267428faed554af30b9f1193ce5447f0750621da/gpu/command_buffer/service/raster_decoder_unittest_base.cc [modify] https://crrev.com/267428faed554af30b9f1193ce5447f0750621da/gpu/command_buffer/service/raster_decoder_unittest_base.h [modify] https://crrev.com/267428faed554af30b9f1193ce5447f0750621da/gpu/command_buffer/tests/decoder_perftest.cc [modify] https://crrev.com/267428faed554af30b9f1193ce5447f0750621da/gpu/command_buffer/tests/fuzzer_main.cc [delete] https://crrev.com/be6bec8d74c853d83e9afea2d192d9d1fa463264/gpu/command_buffer/tests/gl_fence_sync_unittest.cc [modify] https://crrev.com/267428faed554af30b9f1193ce5447f0750621da/gpu/command_buffer/tests/gl_manager.cc [modify] https://crrev.com/267428faed554af30b9f1193ce5447f0750621da/gpu/command_buffer/tests/gl_manager.h [modify] https://crrev.com/267428faed554af30b9f1193ce5447f0750621da/gpu/gles2_conform_support/egl/context.cc [modify] https://crrev.com/267428faed554af30b9f1193ce5447f0750621da/gpu/gles2_conform_support/egl/context.h [modify] https://crrev.com/267428faed554af30b9f1193ce5447f0750621da/gpu/ipc/client/command_buffer_proxy_impl.cc [modify] https://crrev.com/267428faed554af30b9f1193ce5447f0750621da/gpu/ipc/client/command_buffer_proxy_impl.h [modify] https://crrev.com/267428faed554af30b9f1193ce5447f0750621da/gpu/ipc/client/gpu_channel_host.cc [modify] https://crrev.com/267428faed554af30b9f1193ce5447f0750621da/gpu/ipc/command_buffer_task_executor.h [modify] https://crrev.com/267428faed554af30b9f1193ce5447f0750621da/gpu/ipc/common/gpu_messages.h [modify] https://crrev.com/267428faed554af30b9f1193ce5447f0750621da/gpu/ipc/gpu_in_process_thread_service.cc [modify] https://crrev.com/267428faed554af30b9f1193ce5447f0750621da/gpu/ipc/gpu_in_process_thread_service.h [modify] https://crrev.com/267428faed554af30b9f1193ce5447f0750621da/gpu/ipc/in_process_command_buffer.cc [modify] https://crrev.com/267428faed554af30b9f1193ce5447f0750621da/gpu/ipc/in_process_command_buffer.h [modify] https://crrev.com/267428faed554af30b9f1193ce5447f0750621da/gpu/ipc/service/command_buffer_stub.cc [modify] https://crrev.com/267428faed554af30b9f1193ce5447f0750621da/gpu/ipc/service/command_buffer_stub.h [modify] https://crrev.com/267428faed554af30b9f1193ce5447f0750621da/gpu/ipc/service/gles2_command_buffer_stub.cc [modify] https://crrev.com/267428faed554af30b9f1193ce5447f0750621da/gpu/ipc/service/gpu_channel.cc [modify] https://crrev.com/267428faed554af30b9f1193ce5447f0750621da/ppapi/proxy/ppapi_command_buffer_proxy.cc [modify] https://crrev.com/267428faed554af30b9f1193ce5447f0750621da/ppapi/proxy/ppapi_command_buffer_proxy.h
Comment 1 by bugdroid1@chromium.org
, Oct 16