New issue
Advanced search Search tips

Issue 895978 link

Starred by 1 user
Status: Available
Owner: ----
Cc:
mbonadei@chromium.org
oprypin@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature


Previous locations:
webrtc:9877


Sign in to add a comment

Running compile bot on rebase.

Project Member Reported by srte@webrtc.org, Oct 15 
When rebasing, we don't currently rerun try bots. This means that if a change is made invalid by an independent commit, we can introduce a build failure in the system. It's practical that we don't have to rerun the full suite just because of a rebase, but it would be nice if at least a compile was run on the final result to avoid this issue.

For an example of build failure happening, see:
https://webrtc-review.googlesource.com/c/src/+/105984

Comment 1 by oprypin@chromium.org, Oct 16

Cc: mbonadei@chromium.org oprypin@chromium.org
Components: -Build
Owner: ----
WebRTC doesn't have much influence on how the commit queue works.

It's also not possible to determine what will be a rebase and what won't be, each tryjob figures that out on its own -- in fact, a rebase *always* happens, just that sometimes it's a no-op.

The only thing we *could* do is, say, run `linux_compile_rel` every time someone touches the "CommitQueue +*" button, like we do for "presubmit" tryjob. But I imagine it would get annoying really quickly.

Having this behavior means that Chromium people decided that taking this kind of risk is worth it. And well, maybe it is.

Comment 2 by oprypin@chromium.org, Oct 16

Project: chromium
Moved issue webrtc:9877 to now be issue chromium:895978.

Comment 3 by oprypin@chromium.org, Oct 16

Components: Infra>Client>WebRTC
Owner: ----

Comment 4 by benhenry@google.com, Jan 11

Labels: Pri-2
Setting defect without priority to Pri-2.
►

Sign in to add a comment