New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 895977 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 19
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

testVariationArgs and testTelemetryUsesChromeClockDomain failures on cros-chrome

Project Member Reported by achuith@chromium.org, Oct 16

Issue description

These tests seem to fail only when run using --browser=cros-chrome and --remote.

See:
https://chromium-review.googlesource.com/c/chromium/src/+/1272237/1/testing/buildbot/chromium.chromiumos.json#369

Stack:
[1/2] core.perf_benchmark_unittest.PerfBenchmarkTest.testVariationArgs failed unexpectedly:
  Traceback (most recent call last):
    File "/usr/local/google/home/achuith/code/chrome/src/tools/perf/core/perf_benchmark_unittest.py", line 66, in testVariationArgs
      possible_browser = browser_finder.FindBrowser(options)
    File "/usr/local/google/home/achuith/code/chrome/src/third_party/catapult/telemetry/telemetry/decorators.py", line 35, in Cacher
      cacher.__cache[key] = obj(*args, **kwargs)
    File "/usr/local/google/home/achuith/code/chrome/src/third_party/catapult/telemetry/telemetry/internal/browser/browser_finder.py", line 59, in FindBrowser
      '--remote requires --browser=cros-chrome or cros-chrome-guest.')
  BrowserFinderException: --remote requires --browser=cros-chrome or cros-chrome-guest.
[2/2] measurements.clock_domain_test.ClockDomainTest.testTelemetryUsesChromeClockDomain failed unexpectedly:
  Chose browser: PossibleCrOSBrowser(browser_type=cros-chrome)
  Tsproxy commandline: ['/usr/local/google/home/achuith/.vpython-root/aadb83/bin/python', '/usr/local/google/home/achuith/code/chrome/src/third_party/catapult/telemetry/third_party/tsproxy/tsproxy.py', '--port=0', '--desthost=127.0.0.1']
  fcntl is supported, try setting non blocking I/O for the ts_proxy process
  TsProxy port: 45893
  CrOsSshForwarder started between 127.0.0.1:45893 and 36643
  (Re)starting the ui (logs the user out)
  Restarting Chrome (pid=11462) with remote port
  dbus-send --system --type=method_call --dest=org.chromium.SessionManager /org/chromium/SessionManager org.chromium.SessionManagerInterface.EnableChromeTesting boolean:true array:string:"--enable-net-benchmarking,--metrics-recording-only,--no-default-browser-check,--no-first-run,--ignore-background-tasks,--enable-gpu-benchmarking,--deny-permission-prompts,--autoplay-policy=no-user-gesture-required,--disable-background-networking,--disable-component-extensions-with-background-pages,--disable-default-apps,--disable-search-geolocation-disclosure,--proxy-server=socks://localhost:36643,--ignore-certificate-errors-spki-list=PhrPvGIaAMmd29hj8BCZOq096yj7uMpRNHpn5PDxI6I=,--enable-smooth-scrolling,--enable-threaded-compositing,--remote-debugging-port=0,--start-maximized,--ash-disable-system-sounds,--oobe-skip-postlogin,--disable-logging-redirect,--vmodule=*/chromeos/net/*=2\,*/chromeos/login/*=2\,chrome_browser_main_posix=2,--allow-failed-policy-fetch-for-test,--disable-gaia-services" array:string:
  CrOsSshForwarder started between 127.0.0.1:42621 and 34621
  Invoking Oobe.loginForTesting
  CrOsSshForwarder started between 127.0.0.1:40541 and 34621
  Browser is up!
  Browser started (pid=11646).
  OS: chromeos 
  Browser command line: /opt/google/chrome/chrome --ui-prioritize-in-gpu-process --use-gl=egl --gpu-sandbox-failures-fatal=no --enable-logging --log-level=1 --use-cras --enable-wayland-server --user-data-dir=/home/chronos --system-developer-mode --login-profile=user --aura-legacy-power-button --enable-features=Crostini,ExperimentalCrostiniUI --enterprise-enrollment-initial-modulus=15 --enterprise-enrollment-modulus-limit=19 --login-manager --enable-net-benchmarking --metrics-recording-only --no-default-browser-check --no-first-run --ignore-background-tasks --enable-gpu-benchmarking --deny-permission-prompts --autoplay-policy=no-user-gesture-required --disable-background-networking --disable-component-extensions-with-background-pages --disable-default-apps --disable-search-geolocation-disclosure --proxy-server=socks://localhost:36643 --ignore-certificate-errors-spki-list=PhrPvGIaAMmd29hj8BCZOq096yj7uMpRNHpn5PDxI6I= --enable-smooth-scrolling --enable-threaded-compositing --remote-debugging-port=0 --start-maximized --ash-disable-system-sounds --oobe-skip-postlogin --disable-logging-redirect --allow-failed-policy-fetch-for-test --disable-gaia-services --testing-channel=NamedTestingInterface:/tmp/.org.chromium.Chromium.vUUMEP/.org.chromium.Chromium.LNXcvA --vmodule=nss_cert_database_chromeos=1,*/assistant/*=1,*chromeos/login/*=1,auto_enrollment_controller=1,*/ui/ozone/*=1,*/ui/display/manager/chromeos/*=1,*night_light*=1,update_engine=1,component_updater_service=1,power_button_observer=2,webui_login_view=2,lock_state_controller=2,webui_screen_locker=2,screen_locker=2,*/chromeos/net/*=2,*/chromeos/login/*=2,chrome_browser_main_posix=2 --enable-features=Crostini,ExperimentalCrostiniUI
  GPU device 0: VENDOR = 0x1af4 (VMware, Inc.), DEVICE = 0x1050 (llvmpipe (LLVM 6.0, 256 bits))
  GPU Attributes:
    amd_switchable      : False
    can_support_threaded_texture_mailbox: False
    direct_rendering    : True
    gl_extensions       : GL_ANGLE_texture_compression_dxt3 GL_ANGLE_texture_compression_dxt5 GL_APPLE_texture_max_level GL_EXT_base_instance GL_EXT_blend_func_extended GL_EXT_blend_minmax GL_EXT_clip_cull_distance GL_EXT_color_buffer_float GL_EXT_compressed_ETC1_RGB8_sub_texture GL_EXT_copy_image GL_EXT_discard_framebuffer GL_EXT_draw_buffers GL_EXT_draw_buffers_indexed GL_EXT_draw_elements_base_vertex GL_EXT_frag_depth GL_EXT_map_buffer_range GL_EXT_multi_draw_arrays GL_EXT_occlusion_query_boolean GL_EXT_polygon_offset_clamp GL_EXT_read_format_bgra GL_EXT_separate_shader_objects GL_EXT_shader_integer_mix GL_EXT_texture_border_clamp GL_EXT_texture_compression_dxt1 GL_EXT_texture_format_BGRA8888 GL_EXT_texture_rg GL_EXT_texture_sRGB_decode GL_EXT_texture_type_2_10_10_10_REV GL_EXT_unpack_subimage GL_KHR_context_flush_control GL_KHR_debug GL_KHR_no_error GL_MESA_shader_integer_functions GL_NV_draw_buffers GL_NV_fbo_color_attachments GL_NV_read_buffer GL_NV_read_depth GL_NV_read_depth_stencil GL_NV_read_stencil GL_OES_EGL_image GL_OES_EGL_image_external GL_OES_EGL_image_external_essl3 GL_OES_EGL_sync GL_OES_compressed_ETC1_RGB8_texture GL_OES_copy_image GL_OES_depth24 GL_OES_depth_texture GL_OES_depth_texture_cube_map GL_OES_draw_buffers_indexed GL_OES_draw_elements_base_vertex GL_OES_element_index_uint GL_OES_fbo_render_mipmap GL_OES_get_program_binary GL_OES_mapbuffer GL_OES_packed_depth_stencil GL_OES_required_internalformat GL_OES_rgb8_rgba8 GL_OES_standard_derivatives GL_OES_stencil8 GL_OES_surfaceless_context GL_OES_texture_3D GL_OES_texture_border_clamp GL_OES_texture_float GL_OES_texture_float_linear GL_OES_texture_half_float GL_OES_texture_half_float_linear GL_OES_texture_npot GL_OES_texture_stencil8 GL_OES_vertex_array_object GL_OES_vertex_half_float 
    gl_renderer         : llvmpipe (LLVM 6.0, 256 bits)
    gl_reset_notification_strategy: 0
    gl_vendor           : VMware, Inc.
    gl_version          : OpenGL ES 3.0 Mesa 18.2.0-devel (git-0f959215c3)
    gl_ws_extensions    : EGL_EXT_image_dma_buf_import EGL_EXT_image_dma_buf_import_modifiers EGL_KHR_cl_event2 EGL_KHR_config_attribs EGL_KHR_create_context EGL_KHR_create_context_no_error EGL_KHR_fence_sync EGL_KHR_get_all_proc_addresses EGL_KHR_gl_colorspace EGL_KHR_gl_renderbuffer_image EGL_KHR_gl_texture_2D_image EGL_KHR_gl_texture_3D_image EGL_KHR_gl_texture_cubemap_image EGL_KHR_image_base EGL_KHR_no_config_context EGL_KHR_reusable_sync EGL_KHR_surfaceless_context EGL_EXT_pixel_format_float EGL_KHR_wait_sync EGL_MESA_configless_context EGL_MESA_image_dma_buf_export 
    gl_ws_vendor        : Mesa Project
    gl_ws_version       : 1.4 (DRI2)
    in_process_gpu      : False
    initialization_time : 0.053839
    jpeg_decode_accelerator_supported: False
    max_msaa_samples    : 1
    oop_rasterization_supported: True
    optimus             : False
    passthrough_cmd_decoder: False
    pixel_shader_version: 3.00
    process_crash_count : 0
    sandboxed           : False
    software_rendering  : False
    vertex_shader_version: 3.00
    video_decode_accelerator_flags: 0
  Feature Status:
    2d_canvas           : enabled
    flash_3d            : enabled
    flash_stage3d       : enabled
    flash_stage3d_baseline: enabled
    gpu_compositing     : enabled
    multiple_raster_threads: enabled_on
    native_gpu_memory_buffers: disabled_software
    oop_rasterization   : unavailable_off
    protected_video_decode: unavailable_off
    rasterization       : unavailable_off
    skia_deferred_display_list: disabled_off
    skia_renderer       : disabled_off
    surface_control     : disabled_off
    surface_synchronization: enabled_on
    video_decode        : enabled
    viz_display_compositor: disabled_off
    webgl               : enabled
    webgl2              : enabled
  Driver Bug Workarounds:
    clear_uniforms_before_first_program_use
    count_all_in_varyings_packing
    disable_discard_framebuffer
    disable_framebuffer_cmaa
    scalarize_vec_and_mat_constructor_args
    disabled_extension__gl__khr_blend_equation_advanced
    disabled_extension__gl__khr_blend_equation_advanced_coherent
  DevTools console [network]: Failed to load resource: net::ERR_FAILED chrome-search://local-ntp/one-google.js
  Created trace config file in /tmp/chrome-trace-config.json
  Start Tracing Request: {'params': {'transferMode': 'ReturnAsStream', 'traceConfig': {'recordMode': 'recordAsMuchAsPossible'}}, 'method': 'Tracing.start'}
  Chrome version: 3579
  Remove trace config file in /tmp/chrome-trace-config.json
  *************** BROWSER STANDARD OUTPUT ***************
  Cannot get standard output on CrOS
  *********** END OF BROWSER STANDARD OUTPUT ************
  ********************* BROWSER LOG *********************
  No log file
  ***************** END OF BROWSER LOG ******************
  ********************* SYMBOLIZED MINIDUMP *********************
  ***************** END OF SYMBOLIZED MINIDUMP ******************
  Closing browser (pid=11646) ...
  (Re)starting the ui (logs the user out)
  Browser is closed.
  Traceback (most recent call last):
    File "/usr/local/google/home/achuith/code/chrome/src/third_party/catapult/telemetry/telemetry/testing/browser_test_case.py", line 39, in WrappedMethod
      method(self)
    File "/usr/local/google/home/achuith/code/chrome/src/third_party/catapult/telemetry/telemetry/decorators.py", line 219, in wrapper
      func(*args, **kwargs)
    File "/usr/local/google/home/achuith/code/chrome/src/tools/perf/measurements/clock_domain_test.py", line 43, in testTelemetryUsesChromeClockDomain
      assert ts_chrome > ts_telemetry_start
  AssertionError



 
Cc: -nednguyen@chromium.org crouleau@chromium.org nedngu...@google.com
Components: Speed>Telemetry
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bcb2dfd37ce46124e02cd9d53797cd58fd46a382

commit bcb2dfd37ce46124e02cd9d53797cd58fd46a382
Author: Achuith Bhandarkar <achuith@chromium.org>
Date: Thu Oct 18 18:37:49 2018

cros-chrome test fixes.

Remote Chrome OS fails on these tests.
* Disable testTelemetryUsesChromeClockDomain.
* Fix testVariationArgs.

BUG= chromium:895977 

Change-Id: I62c852017033b57d942c5e7eb07b9cdc8a526e8b
Reviewed-on: https://chromium-review.googlesource.com/c/1284756
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600838}
[modify] https://crrev.com/bcb2dfd37ce46124e02cd9d53797cd58fd46a382/tools/perf/core/perf_benchmark_unittest.py
[modify] https://crrev.com/bcb2dfd37ce46124e02cd9d53797cd58fd46a382/tools/perf/measurements/clock_domain_test.py

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3931a4fc567d09973ae04175cab10e9dcf9ac435

commit 3931a4fc567d09973ae04175cab10e9dcf9ac435
Author: Achuith Bhandarkar <achuith@chromium.org>
Date: Fri Oct 19 02:26:04 2018

These tests don't need to be skipped.

testVariationArgs and testTelemetryUsesChromeClockDomain should be
handled by https://chromium-review.googlesource.com/c/1284756

Bug:  895977 
Test: chromeos-amd64-generic-rel
Change-Id: I2627df526bfa56d5ae6e32d4954cb08c8f8c8378
Reviewed-on: https://chromium-review.googlesource.com/c/1289949
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601030}
[modify] https://crrev.com/3931a4fc567d09973ae04175cab10e9dcf9ac435/testing/buildbot/chromium.chromiumos.json
[modify] https://crrev.com/3931a4fc567d09973ae04175cab10e9dcf9ac435/testing/buildbot/test_suites.pyl

Status: Fixed (was: Started)

Comment 6 by benhenry@google.com, Jan 16 (6 days ago)

Components: Test>Telemetry

Comment 7 by benhenry@google.com, Jan 16 (6 days ago)

Components: -Speed>Telemetry

Sign in to add a comment