New issue
Advanced search Search tips

Issue 895971 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Relands bypassing all checks are horrible

Project Member Reported by oprypin@chromium.org, Oct 16

Issue description

In the last month there have been 3 accidents where WebRTC developers pressed "Revert" on a Gerrit CL which is already a revert, and had their relands instantly merged, bypassing all checks. But, none of them expected that to happen, and in most cases they had to also re-revert them immediately.

Some things that I think should never happen:

* Adding "No-Tree-Checks: true, No-Try: true" and also "Automatically send revert change to CQ" without any confirmation.
* Adding "No-Tree-Checks: true, No-Try: true" to a reland.
* Adding "No-Presubmit: true", EVER.


In https://chromium.googlesource.com/infra/gerrit-plugins/chromium-behavior
there is already logic to detect nested reverts as relands. The first easy thing to do would be to not add those scary tags if it is such a nested revert.

And I quite dislike relands done through the "Revert" button in general, they contain too much noise compared to a "Reland". Would be nice to steer people away from that.
 
Description: Show this description
Components: Infra>Platform>CQ
Components: -Infra>Platform>CQ
This is pure-Gerrit stuff, nothing to do with CQ, IMO.
Status: Available (was: Untriaged)
These seem like good suggestions.

It sounds like you are somewhat familiar with the chromium behavior plugin. If you want to make contributions to address this that would be great.
Cc: ajp@chromium.org

Sign in to add a comment