New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 895967 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

gsubmodd needs an additional builder, starting at a much more recent point in history

Project Member Reported by flyboy@chromium.org, Oct 16

Issue description

per a conversation between flyboy@ and jsca@
 
Joey, when we talked I said that I thought the effect of specifying a starting commit (be it a week ago, or whenever) was that only commits after that would be "fortified" with submodules, but that earlier commits would still be included in the mirror.

However, that was wrong.  In the mirror repo, the oldest commit is the one corresponding to the one following the specified starting point in the origin.

Does that mean that our idea of creating this new, only-a-week-old experimental mirror repo is useless?
No, I think we should do it anyway. We don't care much about the history for the purposes of this prototype, I think.
I think the main reason to get it up and running is to have a version of chromium/src at HEAD, with submodules, that we can test xrefs on.
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 18

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/b98462948ebde10ce49ccf2e5e9a732a37302541

commit b98462948ebde10ce49ccf2e5e9a732a37302541
Author: Alan Bram <flyboy@chromium.org>
Date: Thu Oct 18 00:57:27 2018

Plumb through the new "epoch" parameter in the gsubmodd recipe.

Bug: 895967
Change-Id: I2a5cd2dc08caf2820e77d2bf5bd7ce2485ec048f
Reviewed-on: https://chromium-review.googlesource.com/c/1287151
Reviewed-by: Joey Scarr <jsca@chromium.org>
Commit-Queue: Alan Bram <flyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18419}
[modify] https://crrev.com/b98462948ebde10ce49ccf2e5e9a732a37302541/recipes/recipes/gsubmodd.py
[modify] https://crrev.com/b98462948ebde10ce49ccf2e5e9a732a37302541/recipes/README.recipes.md
[add] https://crrev.com/b98462948ebde10ce49ccf2e5e9a732a37302541/recipes/recipes/gsubmodd.expected/epoch.json

Project Member

Comment 6 by bugdroid1@chromium.org, Oct 19

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/eb01039b772ca16db17ff4dc0daa0216a96e18c3

commit eb01039b772ca16db17ff4dc0daa0216a96e18c3
Author: Alan Bram <flyboy@chromium.org>
Date: Fri Oct 19 00:10:37 2018

Fix bug where new `epoch` arg didn't get plumbed all the way through.

Bug: 895967
Change-Id: I2b8518ea8b0b743a672075924cbaf2b38b206618
Reviewed-on: https://chromium-review.googlesource.com/c/1288999
Reviewed-by: Joey Scarr <jsca@chromium.org>
Commit-Queue: Alan Bram <flyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18465}
[modify] https://crrev.com/eb01039b772ca16db17ff4dc0daa0216a96e18c3/infra/services/gsubmodd/__main__.py

Sign in to add a comment