Issue metadata
Sign in to add a comment
|
need to include <sys/sysmacros.h> for major() and minor() |
||||||||||||||||||||||
Issue descriptionglibc 2.25 has removed sys/sysmacros.h from types.h, as a result, some package would fail to build with error undefined reference to `minor'
,
Oct 17
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/portage-stable/+/05c7bf0a320fa656657a5be1983ad400ea918a08 commit 05c7bf0a320fa656657a5be1983ad400ea918a08 Author: Yunlian Jiang <yunlian@google.com> Date: Wed Oct 17 12:55:10 2018 mtd-utils: use latest Gentoo upstream version. This get the latest Gentoo upstream mtd-utils-1.5.2. It changes the KEYWORD to '*' and bumped version. BUG= chromium:895954 TEST=sudo emerge mtd-utils Change-Id: I00db0c190aa7467234de0648a62cd3402e7c85b2 Reviewed-on: https://chromium-review.googlesource.com/1284150 Commit-Ready: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> Reviewed-by: Brian Norris <briannorris@chromium.org> [add] https://crrev.com/05c7bf0a320fa656657a5be1983ad400ea918a08/sys-fs/mtd-utils/files/mtd-utils-1.5.2-sysmacros.patch [modify] https://crrev.com/05c7bf0a320fa656657a5be1983ad400ea918a08/sys-fs/mtd-utils/Manifest [rename] https://crrev.com/05c7bf0a320fa656657a5be1983ad400ea918a08/sys-fs/mtd-utils/mtd-utils-1.5.2-r1.ebuild [modify] https://crrev.com/05c7bf0a320fa656657a5be1983ad400ea918a08/sys-fs/mtd-utils/metadata.xml
,
Oct 17
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/ltp/+/85d0b774f6e640bbb6c70829e1084d9b367a2c64 commit 85d0b774f6e640bbb6c70829e1084d9b367a2c64 Author: Yunlian Jiang <yunlian@google.com> Date: Wed Oct 17 21:23:27 2018 ltp: backport upstream patch to build with glibc 2.27 This backports the commit below to make it build with glibc 2.27. commit b0bd0ad871ce94fcb83084bc573c8eeb99fbc508 Author: Matthew Dawson <matthew@mjdsystems.ca> Date: Thu Aug 24 00:53:46 2017 -0400 misc: Add sys/sysmacros.h header to includes when makedev is used. According to makedev(3), the makedev macro is defined in sys/sysmacros.h. On later versions of glibc, this seems to now be enforced and the build fails. Once added the code compiles as usual. Signed-off-by: Matthew Dawson <matthew@mjdsystems.ca> BUG= chromium:895954 TEST=emerge-kevin autotest-deps-ltp with glibc 2.27 Change-Id: I8da5eb170fc20ea28dad307d4b9b6a33d34a5fbb Reviewed-on: https://chromium-review.googlesource.com/1285389 Commit-Ready: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/85d0b774f6e640bbb6c70829e1084d9b367a2c64/testcases/kernel/syscalls/getxattr/getxattr02.c [modify] https://crrev.com/85d0b774f6e640bbb6c70829e1084d9b367a2c64/testcases/kernel/syscalls/mount/mount02.c [modify] https://crrev.com/85d0b774f6e640bbb6c70829e1084d9b367a2c64/testcases/kernel/device-drivers/tbio/tbio_user/tbio.c [modify] https://crrev.com/85d0b774f6e640bbb6c70829e1084d9b367a2c64/testcases/kernel/syscalls/setxattr/setxattr02.c [modify] https://crrev.com/85d0b774f6e640bbb6c70829e1084d9b367a2c64/testcases/kernel/syscalls/open/open11.c [modify] https://crrev.com/85d0b774f6e640bbb6c70829e1084d9b367a2c64/testcases/kernel/syscalls/mknod/mknod01.c
,
Oct 17
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/287b5f968780e125d0643a26b2b0d83bf1dc4603 commit 287b5f968780e125d0643a26b2b0d83bf1dc4603 Author: Yunlian Jiang <yunlian@google.com> Date: Wed Oct 17 21:23:27 2018 libv4l: add missing sys/sysmacros.h glibc 2.25 has dropped sys/sysmacros.h from sys/types.h, we need to add it explicitly if we want to use minor/major. BUG= chromium:895954 TEST=emerge-kevin libv4l with glibc 2.27 Change-Id: Ib9042408cf709f33885968aa7630afce271625b0 Reviewed-on: https://chromium-review.googlesource.com/1284753 Commit-Ready: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [rename] https://crrev.com/287b5f968780e125d0643a26b2b0d83bf1dc4603/media-libs/libv4l/libv4l-1.6.0-r7.ebuild [modify] https://crrev.com/287b5f968780e125d0643a26b2b0d83bf1dc4603/media-libs/libv4l/libv4l-1.6.0.ebuild [add] https://crrev.com/287b5f968780e125d0643a26b2b0d83bf1dc4603/media-libs/libv4l/files/v4l-utils-1.6.0-sysmacros.patch
,
Oct 17
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/48f42ead01a383a55d9217cef13aee7e0291f015 commit 48f42ead01a383a55d9217cef13aee7e0291f015 Author: Yunlian Jiang <yunlian@google.com> Date: Wed Oct 17 21:23:30 2018 v4l-utils: add missing sys/sysmacros.h glibc 2.25 has dropped sys/sysmacros.h from sys/types.h, we need to add it explicitly if we want to use minor/major. BUG= chromium:895954 TEST=emerge-kevin v4l-utils with glibc 2.27 Change-Id: I681a4ee1844f5261a481de27077d5e67b4b64b80 Reviewed-on: https://chromium-review.googlesource.com/1285012 Commit-Ready: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [rename] https://crrev.com/48f42ead01a383a55d9217cef13aee7e0291f015/media-tv/v4l-utils/v4l-utils-1.6.0-r2.ebuild [add] https://crrev.com/48f42ead01a383a55d9217cef13aee7e0291f015/media-tv/v4l-utils/files/v4l-utils-1.6.0-sysmacro.patch [modify] https://crrev.com/48f42ead01a383a55d9217cef13aee7e0291f015/media-tv/v4l-utils/v4l-utils-1.6.0.ebuild
,
Oct 17
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/42f6c32c9cee633d46dd47076a82d2f857b6844d commit 42f6c32c9cee633d46dd47076a82d2f857b6844d Author: Yunlian Jiang <yunlian@google.com> Date: Wed Oct 17 21:23:25 2018 installer: include sys/sysmacros.h for major/minor These functions have always been defined in sys/sysmacros.h under Linux C libraries. For some, including sys/types.h implicitly includes that as well, but glibc 2.25 deprecated that. Include the header explicitly for the funcs to make glibc 2.27 happy. BUG= chromium:895954 TEST=sudo emerge chromeos-installer with glibc 2.27. Change-Id: I2b6d2ba3fd33c6ca375558732153721dd9f60dbb Reviewed-on: https://chromium-review.googlesource.com/1284111 Commit-Ready: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/42f6c32c9cee633d46dd47076a82d2f857b6844d/installer/chromeos_verity.cc [modify] https://crrev.com/42f6c32c9cee633d46dd47076a82d2f857b6844d/installer/cgpt_manager.cc
,
Oct 17
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/3843b2e9b9fb2554fe22c754301e319fdbdd2cbc commit 3843b2e9b9fb2554fe22c754301e319fdbdd2cbc Author: Yunlian Jiang <yunlian@google.com> Date: Wed Oct 17 21:23:31 2018 cryptohome: add missing sys/sysmacros.h glibc 2.25 has dropped sys/sysmacros.h from sys/types.h, we need to add it explicitly if we want to use minor/major. BUG= chromium:895954 TEST=emerge-kevin cryptohome with glibc 2.27 Change-Id: I63719b5ba2a14925558b8867bd842085c484f6a3 Reviewed-on: https://chromium-review.googlesource.com/1284706 Commit-Ready: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/3843b2e9b9fb2554fe22c754301e319fdbdd2cbc/cryptohome/mount_helpers.cc
,
Oct 17
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/5043ef6a07b70fb5d8fb39c4c4c7cdaf2f9410b3 commit 5043ef6a07b70fb5d8fb39c4c4c7cdaf2f9410b3 Author: Yunlian Jiang <yunlian@google.com> Date: Wed Oct 17 21:23:31 2018 arc-setup: add missing sys/sysmacros.h glibc 2.25 has dropped sys/sysmacros.h from sys/types.h, we need to add it explicitly if we want to use minor/major. BUG= chromium:895954 TEST=emerge-kevin arc-setup with glibc 2.27 Change-Id: Ic3be147a9f1bce586ceb3f727b60432a5281149f Reviewed-on: https://chromium-review.googlesource.com/1284851 Commit-Ready: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> Reviewed-by: Yusuke Sato <yusukes@chromium.org> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/5043ef6a07b70fb5d8fb39c4c4c7cdaf2f9410b3/arc/setup/arc_setup_util.cc
,
Oct 17
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/6b42302d446a19ad01c97e7564bab02f18946297 commit 6b42302d446a19ad01c97e7564bab02f18946297 Author: Yunlian Jiang <yunlian@google.com> Date: Wed Oct 17 21:23:29 2018 libcontainer: add missing sys/sysmacros.h glibc 2.25 has dropped sys/sysmacros.h from sys/types.h, we need to add it explicitly if we want to use minor/major. BUG= chromium:895954 TEST=emerge-kevin libcontainer with glibc 2.27 Change-Id: Ia4c1b13f532d35513b020aa63b5408b071e10723 Reviewed-on: https://chromium-review.googlesource.com/1284852 Commit-Ready: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> Reviewed-by: Keigo Oka <oka@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/6b42302d446a19ad01c97e7564bab02f18946297/libcontainer/libcontainer.cc
,
Oct 17
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/96cbe267f2892c780a410f14f50e5eda61c61ae2 commit 96cbe267f2892c780a410f14f50e5eda61c61ae2 Author: Yunlian Jiang <yunlian@google.com> Date: Wed Oct 17 21:23:23 2018 init: include sys/sysmacros.h for major/minor/makedev These functions have always been defined in sys/sysmacros.h under Linux C libraries. For some, including sys/types.h implicitly includes that as well, but glibc 2.25 deprecated that. Include the header explicitly for the funcs to make glibc 2.27 happy. BUG= chromium:895954 TEST=sudo emerge chromeos-init with glibc 2.27. Change-Id: I6cf234fc2499876f3e3ea5131fba50bd7aac5a55 Reviewed-on: https://chromium-review.googlesource.com/1285535 Commit-Ready: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/96cbe267f2892c780a410f14f50e5eda61c61ae2/init/static_node_tool.cc
,
Oct 17
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/portage-stable/+/f009467c41507000e6959f967f14c23077aa412e commit f009467c41507000e6959f967f14c23077aa412e Author: Yunlian Jiang <yunlian@google.com> Date: Wed Oct 17 21:23:32 2018 hdparm: pull Gentoo upstream 9.52 This pulls Gentoo upstream hdparm 9.52 to make it build with glibc 2.27. BUG= chromium:895954 TEST=sudo emerge hdparm with glibc 2.27 Change-Id: I60ecd9ce4ba642f16e55914edafad11dbf2421db Reviewed-on: https://chromium-review.googlesource.com/1284149 Commit-Ready: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [add] https://crrev.com/f009467c41507000e6959f967f14c23077aa412e/sys-apps/hdparm/files/hdparm-9.51-build.patch [add] https://crrev.com/f009467c41507000e6959f967f14c23077aa412e/sys-apps/hdparm/files/hdparm-9.48-sysmacros.patch [delete] https://crrev.com/3bbf6aabe6a632e2434d9736045023f33d91bd40/sys-apps/hdparm/hdparm-9.45.ebuild [add] https://crrev.com/f009467c41507000e6959f967f14c23077aa412e/sys-apps/hdparm/hdparm-9.52.ebuild [modify] https://crrev.com/f009467c41507000e6959f967f14c23077aa412e/sys-apps/hdparm/Manifest [modify] https://crrev.com/f009467c41507000e6959f967f14c23077aa412e/sys-apps/hdparm/metadata.xml [modify] https://crrev.com/f009467c41507000e6959f967f14c23077aa412e/sys-apps/hdparm/files/hdparm-init-8
,
Oct 18
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/acae9cd40ae1e84bf5a7e841945b180cddfc333b commit acae9cd40ae1e84bf5a7e841945b180cddfc333b Author: Yunlian Jiang <yunlian@google.com> Date: Thu Oct 18 21:53:42 2018 parted: add missing sys/sysmacros.h glibc 2.25 has dropped sys/sysmacros.h from sys/types.h, we need to add it explicitly if we want to use minor/major. BUG= chromium:895954 TEST=emerge-kevin parted with glibc 2.27 Change-Id: If10b2daa3553a2d4250f5898d3e2e65bd64dee94 Reviewed-on: https://chromium-review.googlesource.com/1285011 Commit-Ready: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [rename] https://crrev.com/acae9cd40ae1e84bf5a7e841945b180cddfc333b/sys-block/parted/parted-3.1-r2.ebuild [add] https://crrev.com/acae9cd40ae1e84bf5a7e841945b180cddfc333b/sys-block/parted/files/parted-3.1-sysmacro.patch
,
Oct 18
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/686c15699ec0712a0eebcbfcec80a3380036f059 commit 686c15699ec0712a0eebcbfcec80a3380036f059 Author: Yunlian Jiang <yunlian@google.com> Date: Thu Oct 18 21:53:44 2018 brltty: add missing sys/sysmacros.h glibc 2.25 has dropped sys/sysmacros.h from sys/types.h, we need to add it explicitly if we want to use minor/major. BUG= chromium:895954 TEST=emerge-kevin brltty with glibc 2.27 Change-Id: Ifa741a5faa4ea280498b4cf391f252a30fe3e7e1 Reviewed-on: https://chromium-review.googlesource.com/1285297 Commit-Ready: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> Reviewed-by: Benjamin Gordon <bmgordon@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [add] https://crrev.com/686c15699ec0712a0eebcbfcec80a3380036f059/app-accessibility/brltty/files/brltty-5.4-sysmacros.patch [rename] https://crrev.com/686c15699ec0712a0eebcbfcec80a3380036f059/app-accessibility/brltty/brltty-5.4-r9.ebuild [modify] https://crrev.com/686c15699ec0712a0eebcbfcec80a3380036f059/app-accessibility/brltty/brltty-5.4.ebuild
,
Oct 24
,
Oct 25
,
Oct 25
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/d25646bb8942c5866adefdabd01cf3aecc9663aa commit d25646bb8942c5866adefdabd01cf3aecc9663aa Author: Yunlian Jiang <yunlian@google.com> Date: Thu Oct 25 11:26:38 2018 libcontainer: add missing sys/sysmacros.h glibc 2.25 has dropped sys/sysmacros.h from sys/types.h, we need to add it explicitly if we want to use minor/major. BUG= chromium:895954 TEST=emerge-kevin brltty with glibc 2.27 Change-Id: I39683b8caf349fc9d7e1f1219874093ba4464bf5 Reviewed-on: https://chromium-review.googlesource.com/1298285 Commit-Ready: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> Reviewed-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/d25646bb8942c5866adefdabd01cf3aecc9663aa/libcontainer/libcontainer_test.cc
,
Oct 28
,
Oct 30
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/97358575bbca2516749bfcdab31faaa4cfbcd1dc commit 97358575bbca2516749bfcdab31faaa4cfbcd1dc Author: Yunlian Jiang <yunlian@google.com> Date: Tue Oct 30 23:54:18 2018 cloud-disk-resize: fix build error with glibc 2.27 glibc 2.25 has dropped sys/sysmacros.h from sys/types.h, we need to add it explicitly if we want to use minor/major. RELEASE_NOTE=BUGFIX BUG= chromium:895954 TEST=emerge-lakitu cloud-dis-resize with glibc 2.27 Change-Id: I552991d87238f2e3b97aff212318091b46250ada Reviewed-on: https://chromium-review.googlesource.com/1306453 Commit-Ready: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> Reviewed-by: Luis Lozano <llozano@chromium.org> Reviewed-by: Daniel Wang <wonderfly@google.com> [rename] https://crrev.com/97358575bbca2516749bfcdab31faaa4cfbcd1dc/overlay-lakitu/sys-apps/cloud-disk-resize/cloud-disk-resize-0.0.1-r9.ebuild [add] https://crrev.com/97358575bbca2516749bfcdab31faaa4cfbcd1dc/overlay-lakitu/sys-apps/cloud-disk-resize/files/cloud-disk-resize-sysmacro.patch [modify] https://crrev.com/97358575bbca2516749bfcdab31faaa4cfbcd1dc/overlay-lakitu/sys-apps/cloud-disk-resize/cloud-disk-resize-0.0.1.ebuild
,
Nov 13
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/94cc1d597a4f98141c1aff70f9d2db7488294ad3 commit 94cc1d597a4f98141c1aff70f9d2db7488294ad3 Author: Manoj Gupta <manojgupta@google.com> Date: Tue Nov 13 06:45:48 2018 xwayland: Fix compilation issues with glibc2.27. glibc 2.25 has dropped sys/sysmacros.h from sys/types.h, we need to add it explicitly if we want to use minor/major. BUG= chromium:895954 TEST=emerge-tael xwayland works with glibc 2.27 Change-Id: I2eac706ad4dc743ac0c19f865001ef36df139013 Reviewed-on: https://chromium-review.googlesource.com/1331008 Commit-Ready: Manoj Gupta <manojgupta@chromium.org> Tested-by: Stephen Barber <smbarber@chromium.org> Reviewed-by: Zach Reizner <zachr@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [rename] https://crrev.com/94cc1d597a4f98141c1aff70f9d2db7488294ad3/x11-base/xwayland/xwayland-1.20.1-r1.ebuild [add] https://crrev.com/94cc1d597a4f98141c1aff70f9d2db7488294ad3/x11-base/xwayland/files/0001-xwayland-sysmacros.patch |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by bugdroid1@chromium.org
, Oct 17