Remove net-wireless/marvell_sd8787 from most devices |
|||
Issue descriptionI was taking a look at what cruft we have installed on coral, and I noticed these files: sd8787_uapsta.bin sd8797_uapsta.bin sd8897_uapsta.bin Those do not belong on most device images, and they're wasting ~2 MB of space.
,
Oct 16
great!
,
Oct 16
Kirtika noted to me:
there's also a bunch of "marvell" in stuff like
overlay-enguarde/profiles/base/package.use:1:net-wireless/marvell_sd8787 pcie
in various overlays. If I understand my history correctly, this is from old failed experiments on trying Marvell PCIe on some Intel platforms. AIUI, there's no way that stuff actually shipped, and if it did...it ain't working today.
So I'll probably also drop any mentions of 'net-wireless/marvell_sd8787 pcie' from package.use too.
Additionally, I think these are all wasting space in LINUX_FIRMWARE -- we never stabilized or shipped PCIe variants of 8897:
baseboard-auron/profiles/base/make.defaults:11:LINUX_FIRMWARE="marvell-pcie8897 iwlwifi-7260 ibt-hw"
baseboard-glados/profiles/base/make.defaults:19:LINUX_FIRMWARE="${LINUX_FIRMWARE} marvell-pcie8897 iwlwifi-7265D ibt-hw"
baseboard-jecht/profiles/base/make.defaults:13:LINUX_FIRMWARE="marvell-pcie8897 iwlwifi-7260 ibt-hw"
baseboard-strago/profiles/base/make.defaults:18:LINUX_FIRMWARE="marvell-pcie8897 iwlwifi-7260 iwlwifi-7265D ibt-hw fw_sst"
overlay-samus/profiles/base/make.defaults:41:LINUX_FIRMWARE="cros-pd fw_sst2 ibt-hw iwlwifi-7260 marvell-pcie8897"
,
Oct 16
The comment about enguarde above applies to most (if not all) BYT boards: src/overlays/overlay-kip/profiles/base/package.use src/overlays/overlay-enguarde/profiles/base/package.use src/overlays/overlay-rambi/profiles/base/package.use src/overlays/overlay-gnawty/profiles/base/package.use src/overlays/overlay-quawks/profiles/base/package.use src/overlays/overlay-swanky/profiles/base/package.use src/overlays/overlay-squawks/profiles/base/package.use src/overlays/overlay-glimmer/profiles/base/package.use src/overlays/overlay-clapper/profiles/base/package.use src/overlays/overlay-expresso/profiles/base/package.use
,
Oct 17
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/4cb330823dc015a7d5fcac0b634db51215ece44f commit 4cb330823dc015a7d5fcac0b634db51215ece44f Author: Brian Norris <briannorris@chromium.org> Date: Wed Oct 17 05:17:33 2018 overlays: add marvell firmware dependency The marvell_sd8787 ebuild installs the following into /lib/firmware/mrvl/: sd8787_uapsta.bin sd8797_uapsta.bin sd8897_uapsta.bin These are only used on a handful of platforms, but the ebuild is included as a base dependency of the top-level virtual/target-chromium-os ebuild. We should instead only pull it in where necessary, to avoid wasting space on other boards. Baseboards / base overlays that use the relevant Marvell firmware: 8797: daisy peach 8897: nyan oak veyron Once this is merged, we can remove the dependency in virtual/target-chromium-os. I referred to go/crconn (internal Google link), as well as running the network_WlanDriver test to ensure existing devices still boot to working Wifi. BUG= chromium:895941 TEST=network_WlanDriver on a variety of devices Change-Id: I9bf1576d49fb300e0c28ac5b00531fa551713039 Signed-off-by: Brian Norris <briannorris@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1284031 Reviewed-by: Douglas Anderson <dianders@chromium.org> Reviewed-by: Kirtika Ruchandani <kirtika@chromium.org> Reviewed-by: Nicolas Boichat <drinkcat@chromium.org> [modify] https://crrev.com/4cb330823dc015a7d5fcac0b634db51215ece44f/baseboard-oak/chromeos-base/chromeos-bsp-baseboard-oak/chromeos-bsp-baseboard-oak-0.0.1.ebuild [rename] https://crrev.com/4cb330823dc015a7d5fcac0b634db51215ece44f/baseboard-oak/chromeos-base/chromeos-bsp-baseboard-oak/chromeos-bsp-baseboard-oak-0.0.1-r8.ebuild [modify] https://crrev.com/4cb330823dc015a7d5fcac0b634db51215ece44f/overlay-veyron/chromeos-base/chromeos-bsp-veyron/chromeos-bsp-veyron-0.0.1.ebuild [modify] https://crrev.com/4cb330823dc015a7d5fcac0b634db51215ece44f/overlay-nyan/chromeos-base/chromeos-bsp-nyan/chromeos-bsp-nyan-0.0.1.ebuild [rename] https://crrev.com/4cb330823dc015a7d5fcac0b634db51215ece44f/overlay-nyan/chromeos-base/chromeos-bsp-nyan/chromeos-bsp-nyan-0.0.1-r19.ebuild [modify] https://crrev.com/4cb330823dc015a7d5fcac0b634db51215ece44f/overlay-peach/chromeos-base/chromeos-bsp-peach/chromeos-bsp-peach-0.0.2.ebuild [rename] https://crrev.com/4cb330823dc015a7d5fcac0b634db51215ece44f/overlay-peach/chromeos-base/chromeos-bsp-peach/chromeos-bsp-peach-0.0.2-r4.ebuild [rename] https://crrev.com/4cb330823dc015a7d5fcac0b634db51215ece44f/overlay-daisy/chromeos-base/chromeos-bsp-daisy/chromeos-bsp-daisy-0.0.2-r11.ebuild [rename] https://crrev.com/4cb330823dc015a7d5fcac0b634db51215ece44f/overlay-veyron/chromeos-base/chromeos-bsp-veyron/chromeos-bsp-veyron-0.0.1-r29.ebuild [modify] https://crrev.com/4cb330823dc015a7d5fcac0b634db51215ece44f/overlay-daisy/chromeos-base/chromeos-bsp-daisy/chromeos-bsp-daisy-0.0.2.ebuild
,
Oct 17
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/cd1b35798e8892eb0a2fb89eea2b48dc32449425 commit cd1b35798e8892eb0a2fb89eea2b48dc32449425 Author: Brian Norris <briannorris@chromium.org> Date: Wed Oct 17 21:23:33 2018 overlays: drop 'marvell-pcie8897' from LINUX_FIRMWARE We aren't shipping PCIe 8897 anywhere, and definitely not on these boards. BUG= chromium:895941 TEST=precq; `network_WlanDriver` in lab Change-Id: I78329425f3ecf2b52e0d21a3c18fcae5504a6b7a Signed-off-by: Brian Norris <briannorris@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1284912 Reviewed-by: Kirtika Ruchandani <kirtika@chromium.org> [modify] https://crrev.com/cd1b35798e8892eb0a2fb89eea2b48dc32449425/baseboard-glados/profiles/base/make.defaults [modify] https://crrev.com/cd1b35798e8892eb0a2fb89eea2b48dc32449425/baseboard-jecht/profiles/base/make.defaults [modify] https://crrev.com/cd1b35798e8892eb0a2fb89eea2b48dc32449425/baseboard-strago/profiles/base/make.defaults [modify] https://crrev.com/cd1b35798e8892eb0a2fb89eea2b48dc32449425/baseboard-auron/profiles/base/make.defaults [modify] https://crrev.com/cd1b35798e8892eb0a2fb89eea2b48dc32449425/overlay-samus/profiles/base/make.defaults
,
Oct 17
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/fd53dcfbdab995177bbb12d9c230bd1e6d36199b commit fd53dcfbdab995177bbb12d9c230bd1e6d36199b Author: Brian Norris <briannorris@chromium.org> Date: Wed Oct 17 21:23:24 2018 target-chromium-os: remove marvell_sd8787 dependency There are a handful of baseboards that use the relevant Wifi devices (and firmware). We're migrating the dependency to the relevant overlays, instead of in the base chromium-os target, so we can save space on most other boards. CQ-DEPEND=CL:1284031 BUG= chromium:895941 TEST=network_WlanDriver on a variety of devices Change-Id: I21aa5109bf7376ddca73166b20e0b222c244c7c9 Signed-off-by: Brian Norris <briannorris@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1284032 Reviewed-by: Douglas Anderson <dianders@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [rename] https://crrev.com/fd53dcfbdab995177bbb12d9c230bd1e6d36199b/virtual/target-chromium-os/target-chromium-os-1-r109.ebuild [modify] https://crrev.com/fd53dcfbdab995177bbb12d9c230bd1e6d36199b/virtual/target-chromium-os/target-chromium-os-1.ebuild
,
Oct 17
This is still in flight, but it doesn't have a material difference in terms of packages included or disk usage: https://chromium-review.googlesource.com/c/chromiumos/overlays/board-overlays/+/1284913 Marking Fixed.
,
Oct 18
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/506c6c2c093a03ed1e9c46362cd39ebe140bca76 commit 506c6c2c093a03ed1e9c46362cd39ebe140bca76 Author: Brian Norris <briannorris@chromium.org> Date: Thu Oct 18 21:53:47 2018 overlays: drop 'net-wireless/marvell_sd8787 pcie' USE These boards will never use a Marvell chipset supported by net-wireless/marvell_sd8787, and we've never really supported the PCIe variant of those chipsets anyway. Drop the package.use listing, so we can avoid the needless copy/paste. BUG= chromium:895941 TEST=build Change-Id: I58eefd01c34e87fa61826b4b6189f6cd34fbaae7 Signed-off-by: Brian Norris <briannorris@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1284913 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Reviewed-by: Kirtika Ruchandani <kirtika@chromium.org> [delete] https://crrev.com/f5d16de40014cf69cecf655bd75f7c0838304d30/overlay-clapper/profiles/base/package.use [delete] https://crrev.com/f5d16de40014cf69cecf655bd75f7c0838304d30/overlay-enguarde/profiles/base/package.use [delete] https://crrev.com/f5d16de40014cf69cecf655bd75f7c0838304d30/overlay-gnawty/profiles/base/package.use [delete] https://crrev.com/f5d16de40014cf69cecf655bd75f7c0838304d30/overlay-kip/profiles/base/package.use [delete] https://crrev.com/f5d16de40014cf69cecf655bd75f7c0838304d30/overlay-rambi/profiles/base/package.use [modify] https://crrev.com/506c6c2c093a03ed1e9c46362cd39ebe140bca76/overlay-squawks/profiles/base/package.use [delete] https://crrev.com/f5d16de40014cf69cecf655bd75f7c0838304d30/overlay-quawks/profiles/base/package.use [delete] https://crrev.com/f5d16de40014cf69cecf655bd75f7c0838304d30/overlay-swanky/profiles/base/package.use [delete] https://crrev.com/f5d16de40014cf69cecf655bd75f7c0838304d30/overlay-expresso/profiles/base/package.use [delete] https://crrev.com/f5d16de40014cf69cecf655bd75f7c0838304d30/overlay-glimmer/profiles/base/package.use |
|||
►
Sign in to add a comment |
|||
Comment 1 by briannorris@chromium.org
, Oct 16